Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-24680 Refactor the checkAndMutate code on the server side #2184

Merged
merged 1 commit into from
Aug 10, 2020
Merged

HBASE-24680 Refactor the checkAndMutate code on the server side #2184

merged 1 commit into from
Aug 10, 2020

Conversation

brfrn169
Copy link
Member

@brfrn169 brfrn169 commented Aug 1, 2020

Signed-off-by: Duo Zhang zhangduo@apache.org
Signed-off-by: Josh Elser elserj@apache.org

@brfrn169
HBASE-24680 Refactor the checkAndMutate code on the server side
8a95f04 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
@brfrn169 brfrn169 self-assigned this Aug 1, 2020
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@brfrn169
Copy link
Member Author

brfrn169 commented Aug 8, 2020

The test failures in the QA are related to HBASE-24830. Will wait for the fix of the Jira to be committed.

@Apache-HBase

This comment has been minimized.

Sign in to view
@brfrn169
Copy link
Member Author

brfrn169 commented Aug 9, 2020

HBASE-24830 is resolved. Just re-triggered QA.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 3m 32s branch-2 passed
+1 💚 checkstyle 2m 18s branch-2 passed
+1 💚 spotbugs 3m 52s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 14s the patch passed
+1 💚 checkstyle 0m 12s The patch passed checkstyle in hbase-hadoop-compat
+1 💚 checkstyle 0m 13s The patch passed checkstyle in hbase-hadoop2-compat
+1 💚 checkstyle 0m 35s The patch passed checkstyle in hbase-client
+1 💚 checkstyle 1m 18s hbase-server: The patch generated 0 new + 428 unchanged - 22 fixed = 428 total (was 450)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 35s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 4m 31s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 50s The patch does not generate ASF License warnings.
41m 2s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2184/8/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2184
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 261ef742355b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 457234c
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-client hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2184/8/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 59s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 30s Maven dependency ordering for branch
+1 💚 mvninstall 4m 23s branch-2 passed
+1 💚 compile 2m 16s branch-2 passed
+1 💚 shadedjars 7m 4s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 19s hbase-hadoop-compat in branch-2 failed.
-0 ⚠️ javadoc 0m 18s hbase-hadoop2-compat in branch-2 failed.
-0 ⚠️ javadoc 0m 28s hbase-client in branch-2 failed.
-0 ⚠️ javadoc 0m 40s hbase-server in branch-2 failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 4m 2s the patch passed
+1 💚 compile 2m 14s the patch passed
+1 💚 javac 2m 14s the patch passed
+1 💚 shadedjars 5m 54s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 19s hbase-hadoop-compat in the patch failed.
-0 ⚠️ javadoc 0m 18s hbase-hadoop2-compat in the patch failed.
-0 ⚠️ javadoc 0m 29s hbase-client in the patch failed.
-0 ⚠️ javadoc 0m 40s hbase-server in the patch failed.
_ Other Tests _
+1 💚 unit 0m 28s hbase-hadoop-compat in the patch passed.
+1 💚 unit 0m 32s hbase-hadoop2-compat in the patch passed.
+1 💚 unit 2m 25s hbase-client in the patch passed.
+1 💚 unit 131m 7s hbase-server in the patch passed.
167m 33s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2184/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2184
Optional Tests javac javadoc unit shadedjars compile
uname Linux 081839309c18 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 457234c
Default Java 2020-01-14
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2184/8/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2184/8/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop2-compat.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2184/8/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2184/8/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2184/8/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2184/8/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop2-compat.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2184/8/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2184/8/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2184/8/testReport/
Max. process+thread count 4197 (vs. ulimit of 12500)
modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-client hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2184/8/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 25s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for branch
+1 💚 mvninstall 4m 24s branch-2 passed
+1 💚 compile 2m 18s branch-2 passed
+1 💚 shadedjars 6m 37s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 42s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 4m 26s the patch passed
+1 💚 compile 2m 19s the patch passed
+1 💚 javac 2m 19s the patch passed
+1 💚 shadedjars 6m 32s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 38s the patch passed
_ Other Tests _
+1 💚 unit 0m 27s hbase-hadoop-compat in the patch passed.
+1 💚 unit 0m 29s hbase-hadoop2-compat in the patch passed.
+1 💚 unit 2m 25s hbase-client in the patch passed.
+1 💚 unit 158m 14s hbase-server in the patch passed.
198m 41s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2184/8/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #2184
Optional Tests javac javadoc unit shadedjars compile
uname Linux cf556ca87974 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 457234c
Default Java 1.8.0_232
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2184/8/testReport/
Max. process+thread count 3884 (vs. ulimit of 12500)
modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-client hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2184/8/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@brfrn169 brfrn169 merged commit 22bf9a3 into apache:branch-2 Aug 10, 2020
clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
@brfrn169 @clarax
HBASE-24680 Refactor the checkAndMutate code on the server side (apac…
273753a 
…he#2184)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brfrn169 brfrn169

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@brfrn169 @Apache-HBase