HBASE-22404 Open/Close region request may be executed twice when mast… #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apache9
requested changes
May 13, 2019
| @@ -1272,6 +1279,10 @@ public RSRpcServices(HRegionServer rs) throws IOException { | |||
|
|
|||
| closedScanners = CacheBuilder.newBuilder() | |||
| .expireAfterAccess(scannerLeaseTimeoutPeriod, TimeUnit.MILLISECONDS).build(); | |||
| sumbittedOpenProcedures = | |||
| CacheBuilder.newBuilder().expireAfterAccess(600, TimeUnit.SECONDS).build(); | |||
| sumbittedCloseProcedures = | |||
There was a problem hiding this comment.
Is this enough? What if the master crashed for an hour and then restart...
infraio
force-pushed
the
only-once-open-close
branch
3 times, most recently
from
dafd0c1
to
037e081
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Apache9
requested changes
May 13, 2019
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
infraio
force-pushed
the
only-once-open-close
branch
3 times, most recently
from
b96bb38
to
d435f7f
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Apache9
requested changes
May 14, 2019
| * | ||
| * After the open/close region request executed and report region transition succeed, cache it in | ||
| * executed region procedures cache. See {@link #finishRegionProcedure(long)}. And the cache will | ||
| * expire after 600 seconds. Because the duplicate open/close region request should not be delayed |
There was a problem hiding this comment.
'Because the duplicated open/close region request is not likely to be delayed...'
And maybe we should also do something at master side? When reportRegionStateTransition succeeded, let's also remove the pending operations in RSProcedureDispatcher if possible? Or maybe add some checks in splitAndResolveOperation, if a RemoteProcedure has already been marked as succeeded, just give up and do not schedule it again. Otherwise we may still got duplicate requests if RSProcedureDispatcher keep retrying more than 10 minutes? Not likely but theoretically it is possible...
infraio
force-pushed
the
only-once-open-close
branch
from
d435f7f
to
e62519e
Compare
Apache9
requested changes
May 15, 2019
| @@ -232,8 +233,9 @@ public RemoteProcedure getRemoteProcedure() { | |||
| public interface RemoteProcedure<TEnv, TRemote> { | |||
| /** | |||
| * For building the remote operation. | |||
| * May be empty if no need to send remote call. | |||
There was a problem hiding this comment.
Please append this 'Usually, this means the RemoteProcedure has been finished already. This is possible, as we may have already sent the procedure to RS but then the rpc connection is broken so the executeProcedures call fails, but the RS does receive the procedure and execute it and then report back, before we retry again.'
| @@ -84,11 +85,12 @@ protected void deserializeStateData(ProcedureStateSerializer serializer) throws | |||
| } | |||
|
|
|||
| @Override | |||
| public RemoteProcedureDispatcher.RemoteOperation remoteCallBuild(MasterProcedureEnv env, | |||
| public Optional<RemoteProcedureDispatcher.RemoteOperation> remoteCallBuild(MasterProcedureEnv env, | |||
There was a problem hiding this comment.
I think for these procedures we should also test whether the procedure has already been finished. Anyway, should be another issue.
infraio
force-pushed
the
only-once-open-close
branch
from
e62519e
to
36c4fd2
Compare
|
💔 -1 overall
This message was automatically generated. |
infraio
force-pushed
the
only-once-open-close
branch
from
36c4fd2
to
fc75239
Compare
Apache9
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er restart