Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-25119: Fix property name added as part of HBASE-24764 in branch-1 #2471

Closed
wants to merge 1 commit into from

Conversation

ankitjain64
Copy link
Contributor

A new property was added as part of this https://issues.apache.org/jira/browse/HBASE-24764.

Master branch has the name as "hbase.replication.peer.base.config"

while branch-1 has the name as "hbase.replication.peer.default.config"

As part of this Jira fix the name in branch-1 to be consistent.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 21s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
+1 💚 mvninstall 10m 52s branch-1 passed
+1 💚 compile 0m 25s branch-1 passed with JDK v1.8.0_262
+1 💚 compile 0m 32s branch-1 passed with JDK v1.7.0_272
+1 💚 checkstyle 1m 0s branch-1 passed
+1 💚 shadedjars 4m 30s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 43s branch-1 passed with JDK v1.8.0_262
+1 💚 javadoc 0m 36s branch-1 passed with JDK v1.7.0_272
+0 🆗 spotbugs 2m 23s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 18s branch-1 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 1s the patch passed
+1 💚 compile 0m 25s the patch passed with JDK v1.8.0_262
+1 💚 javac 0m 25s the patch passed
+1 💚 compile 0m 32s the patch passed with JDK v1.7.0_272
+1 💚 javac 0m 32s the patch passed
+1 💚 checkstyle 0m 50s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 4m 15s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 6m 46s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 javadoc 0m 26s the patch passed with JDK v1.8.0_262
+1 💚 javadoc 0m 34s the patch passed with JDK v1.7.0_272
+1 💚 findbugs 2m 21s the patch passed
_ Other Tests _
+1 💚 unit 3m 16s hbase-client in the patch passed.
+1 💚 asflicense 0m 24s The patch does not generate ASF License warnings.
52m 20s
Subsystem Report/Notes
Docker Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2471/1/artifact/out/Dockerfile
GITHUB PR #2471
JIRA Issue HBASE-25119
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux c029d87a8a07 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2471/out/precommit/personality/provided.sh
git revision branch-1 / e719a5b
Default Java 1.7.0_272
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2471/1/testReport/
Max. process+thread count 148 (vs. ulimit of 10000)
modules C: hbase-client U: hbase-client
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2471/1/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

virajjasani pushed a commit that referenced this pull request Sep 30, 2020
Closes #2471

Signed-off-by: Viraj Jasani <vjasani@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants