New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-25116 RegionMonitor support RegionTask count normalize #2535
base: master
Are you sure you want to change the base?
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
ffd024d
to
9804a79
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@@ -1422,6 +1424,10 @@ public RegionMonitor(Connection connection, String[] monitorTargets, boolean use | |||
this.configuredReadTableTimeouts = new HashMap<>(configuredReadTableTimeouts); | |||
this.configuredWriteTableTimeout = configuredWriteTableTimeout; | |||
this.readAllCF = conf.getBoolean(HConstants.HBASE_CANARY_READ_ALL_CF, true); | |||
this.minTaskCount = conf.getInt(HConstants.HBASE_CANARY_REGION_MONITOR_TASK_COUNT_MIN, 1000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to disable this if I don't want normalize?
@@ -1504,6 +1504,13 @@ | |||
public static final String HBASE_CANARY_READ_RAW_SCAN_KEY = "hbase.canary.read.raw.enabled"; | |||
|
|||
public static final String HBASE_CANARY_READ_ALL_CF = "hbase.canary.read.all.column.famliy"; | |||
|
|||
public static final String HBASE_CANARY_REGION_MONITOR_TASK_COUNT_MAX = | |||
"hbase.canary.region.monitor.task.count.max"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
region.monitor.task => region.task
9804a79
to
e5e74c7
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Large count of region task from canary may affect user normal request, meanwhile if region task is few, the availability monitoring may shake for occasional exception.
so , if the task count is large , we will randomly trim tasks for each table, according to the raito of the table region count in whole tasks region count. If the task count is few, we will repeat tasks