New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-24977 Meta table shouldn't be modified as read only #2537
Conversation
🎊 +1 overall
This message was automatically generated. |
Since there is no damage to meta if you set it to read only I'm neutral on this... |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Yes, it won't damage meta but impacts the internal region assignment. IMO, it will be good to have this validation to maintain the availability. |
If you set the table read-only, you can unset it and make it writable again? |
Yeah, unset will work here. But should we allow admin to alter meta with read-only which will break availability? Please provide your opinion, I'm OK with the current behavior as well. :) |
Better to stop folks shooting themselves in the foot where we can. |
hbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChecker.java
Outdated
Show resolved
Hide resolved
b89dd07
to
0d695e9
Compare
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@saintstack Sir, Do you know why continuous-integration/jenkins/pr-merge can't be build? |
Tried it locally. |
Signed-off-by: stack <stack@apache.org>
Signed-off-by: stack <stack@apache.org>
Added a sanity check for meta table before modifying the table schema