HBASE-25242 Add Increment/Append support to RowMutations #2630

brfrn169 · 2020-11-07T14:16:30Z

No description provided.

brfrn169 · 2020-11-07T23:01:34Z

Can you please review this? @Apache9

hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java

hbase-client/src/main/java/org/apache/hadoop/hbase/client/CheckAndMutate.java

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

Apache9 · 2020-11-10T07:35:11Z

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

+    OperationStatus[] operationStatuses = batchMutate(m.toArray(new Mutation[0]), true,
+      HConstants.NO_NONCE, HConstants.NO_NONCE);
+
+    List<Result> results = Arrays.stream(operationStatuses)


At least for JDK8, stream is slow so let's avoid stream on critical read/write path as much as possible for now.

Sure, I will change it not to use stream. Thanks.

Apache9 · 2020-11-10T07:36:37Z

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java

          default:
-            throw new DoNotRetryIOException("Atomic put and/or delete only, not " + type.name());
+            throw new AssertionError("invalid mutation type : " + type);


Why change to AssertionError?

MutationType can be set to only Put/Delete/Increment/Append. And this switch statement has all the cases (Put/Delete/Increment/Append) after this change, so it is impossible to go the default case. That's why I change it to AssertionError, which means if we hit this AssertionError, it's something a bug. Do you think we should still use DoNotRetryIOException?

I think what you said is also reasonable, but since this is an rpc method, we can not make sure whether the remote side has the same code with us at server side, so I still prefer a DoNotRetryIOException here. Let's not change it for now.

Sure. I will revert this change.

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java

brfrn169

@Apache9 Thank you very much for reviewing this!

Just left some comments. Can you please check them?

I will change this not to use stream in the meanwhile.

hbase-client/src/main/java/org/apache/hadoop/hbase/client/CheckAndMutate.java

hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

brfrn169 · 2020-11-13T12:44:57Z

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

+    OperationStatus[] operationStatuses = batchMutate(m.toArray(new Mutation[0]), true,
+      HConstants.NO_NONCE, HConstants.NO_NONCE);
+
+    List<Result> results = Arrays.stream(operationStatuses)


Sure, I will change it not to use stream. Thanks.

brfrn169 · 2020-11-13T12:50:30Z

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java

          default:
-            throw new DoNotRetryIOException("Atomic put and/or delete only, not " + type.name());
+            throw new AssertionError("invalid mutation type : " + type);


MutationType can be set to only Put/Delete/Increment/Append. And this switch statement has all the cases (Put/Delete/Increment/Append) after this change, so it is impossible to go the default case. That's why I change it to AssertionError, which means if we hit this AssertionError, it's something a bug. Do you think we should still use DoNotRetryIOException?

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java

brfrn169 · 2020-11-18T00:21:18Z

Ping @Apache9 . Thanks.

Apache9

OVerall LGTM. Just a small question and some minor nits.

Apache9 · 2020-11-21T15:12:45Z

hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java

@@ -459,9 +459,10 @@ default CheckAndMutateResult checkAndMutate(CheckAndMutate checkAndMutate) throw
   * {@link Put} and {@link Delete} are supported.
   *
   * @param rm object that specifies the set of mutations to perform atomically
+   * @return results of Increment/Append operations
   * @throws IOException


nits: could remove the empty throws so we could fix on checkstyle warning.

Sure. I will do that.

hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ResponseConverter.java

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java

Apache9 · 2020-11-21T15:24:24Z

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java

@@ -972,11 +1002,44 @@ private void doBatchOp(final RegionActionResult.Builder builder, final HRegion r

      OperationStatus[] codes = region.batchMutate(mArray, atomic, HConstants.NO_NONCE,
        HConstants.NO_NONCE);
+      if (atomic) {
+        LinkedList<ResultOrException> resultOrExceptions = new LinkedList<>();


Better to use ArrayList instead of LinkedList. ArrayList is faster than LinkedList for most cases. I can not recall the exact number but at least for thousands elements ArrayList is still faster.

The reason why I use LinkedList here is that I need to add a element at the beginning of the list as follows:
https://github.com/apache/hbase/pull/2630/files#diff-e4052cd5a1f1c93375e3fbc931dc4df220deebc78c0d53fd2435b47fd04cd807R1019-R1020
https://github.com/apache/hbase/pull/2630/files#diff-e4052cd5a1f1c93375e3fbc931dc4df220deebc78c0d53fd2435b47fd04cd807R1031

Still ArrayList is faster in that case?

Oh, if we want to add element at first then ArrayList is not suitable. But usually we could use other array based data structure such as ArrayDeque. Let me take a look at the code.

brfrn169

Thank you very much @Apache9 for the reviews.

Just left some comments. Could you please check it?
As I mentioned in one of the comments, we need to include it in hbase-2.4. Thanks.

hbase-client/src/main/java/org/apache/hadoop/hbase/client/CheckAndMutate.java

brfrn169 · 2020-11-21T16:14:27Z

hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java

@@ -459,9 +459,10 @@ default CheckAndMutateResult checkAndMutate(CheckAndMutate checkAndMutate) throw
   * {@link Put} and {@link Delete} are supported.
   *
   * @param rm object that specifies the set of mutations to perform atomically
+   * @return results of Increment/Append operations
   * @throws IOException


Sure. I will do that.

hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java

brfrn169 · 2020-11-21T16:17:32Z

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java

          default:
-            throw new DoNotRetryIOException("Atomic put and/or delete only, not " + type.name());
+            throw new AssertionError("invalid mutation type : " + type);


Sure. I will revert this change.

brfrn169 · 2020-11-21T16:27:08Z

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java

@@ -972,11 +1002,44 @@ private void doBatchOp(final RegionActionResult.Builder builder, final HRegion r

      OperationStatus[] codes = region.batchMutate(mArray, atomic, HConstants.NO_NONCE,
        HConstants.NO_NONCE);
+      if (atomic) {
+        LinkedList<ResultOrException> resultOrExceptions = new LinkedList<>();


The reason why I use LinkedList here is that I need to add a element at the beginning of the list as follows:
https://github.com/apache/hbase/pull/2630/files#diff-e4052cd5a1f1c93375e3fbc931dc4df220deebc78c0d53fd2435b47fd04cd807R1019-R1020
https://github.com/apache/hbase/pull/2630/files#diff-e4052cd5a1f1c93375e3fbc931dc4df220deebc78c0d53fd2435b47fd04cd807R1031

Still ArrayList is faster in that case?

hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ResponseConverter.java

brfrn169 · 2020-11-22T00:55:25Z

I just changed the patch regarding the following:

Add testing for Append and keep the last else branch throwing DoNotRetryIOException
Use DoNotRetryIOException instead of AssertionError
Use ArrayList instead of LinkedList

Can you please take a look at this? @Apache9

brfrn169 · 2020-11-22T02:25:39Z

I made a mistake and the compile in the last QA failed.. Just fixed it and pushed the latest patch.

Apache-HBase · 2020-11-22T03:27:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 44s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 21s	master passed
+1 💚	checkstyle	3m 4s	master passed
+1 💚	spotbugs	5m 56s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 15s	the patch passed
+1 💚	checkstyle	0m 35s	hbase-client: The patch generated 0 new + 276 unchanged - 1 fixed = 276 total (was 277)
+1 💚	checkstyle	1m 25s	The patch passed checkstyle in hbase-server
+1 💚	checkstyle	0m 46s	The patch passed checkstyle in hbase-thrift
+1 💚	checkstyle	0m 17s	The patch passed checkstyle in hbase-rest
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 1s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	7m 11s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 50s	The patch does not generate ASF License warnings.
		61m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2630
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 6852841e4b90 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c9156e7`
Max. process+thread count	94 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-11-22T05:39:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 43s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 29s	master passed
+1 💚	compile	3m 34s	master passed
+1 💚	shadedjars	9m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 47s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 41s	the patch passed
+1 💚	compile	3m 17s	the patch passed
+1 💚	javac	3m 17s	the patch passed
+1 💚	shadedjars	9m 23s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 42s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 23s	hbase-client in the patch passed.
+1 💚	unit	137m 48s	hbase-server in the patch passed.
+1 💚	unit	4m 5s	hbase-thrift in the patch passed.
+1 💚	unit	3m 18s	hbase-rest in the patch passed.
		193m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2630
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5a892764f1f1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c9156e7`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/4/testReport/
Max. process+thread count	3807 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-11-22T06:34:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 3s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 28s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 59s	master passed
+1 💚	compile	2m 18s	master passed
+1 💚	shadedjars	7m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 49s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 48s	the patch passed
+1 💚	compile	2m 18s	the patch passed
+1 💚	javac	2m 18s	the patch passed
+1 💚	shadedjars	7m 15s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 49s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 7s	hbase-client in the patch passed.
+1 💚	unit	203m 42s	hbase-server in the patch passed.
+1 💚	unit	4m 42s	hbase-thrift in the patch passed.
+1 💚	unit	4m 2s	hbase-rest in the patch passed.
		248m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2630
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c9540b7d6ab0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c9156e7`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/4/testReport/
Max. process+thread count	3482 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2020-11-22T15:12:30Z

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java

+        }
+
+        if (results.isEmpty()) {
+          resultOrExceptions.add(0, getResultOrException(


I think here we could just call builder.addResultOrException directly to add the first ResultOrException? And then call addAllResultOrException to add the remaining ResultOrExceptions in the list, so we do not need to add a new element in front?

Yes, you are right. I will do that. Thanks.

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java

apurtell

lgtm

Please wait for @Apache9 's approval before merging.

brfrn169 · 2020-11-25T00:18:57Z

Thank you @apurtell

Can you please review this? @Apache9

brfrn169 · 2020-11-25T12:40:56Z

I just added the following comment:
https://github.com/apache/hbase/pull/2630/files#diff-e4052cd5a1f1c93375e3fbc931dc4df220deebc78c0d53fd2435b47fd04cd807R1005-R1008

Can you please take a look at this? @Apache9
Thanks.

Apache9

+1

Thanks for your patient.

Apache9 · 2020-11-25T16:18:44Z

Are the failed UTs related? TestAsyncTable?

brfrn169 · 2020-11-25T16:40:32Z

Seems the failed UTs for TestAsyncTable are not related to this patch.

But it looks like the root cause of the failed UTs are that we don't wait until AsyncTable.put() completes at the following lines:

hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTable.java

Line 998 in d81b541

    
           table.put(new Put(row).addColumn(FAMILY, Bytes.toBytes("A"), Bytes.toBytes("a")));

hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTable.java

Line 1055 in d81b541

    
           table.put(new Put(row).addColumn(FAMILY, Bytes.toBytes("A"), Bytes.toBytes("a")));

We need to call get() method to wait until AsyncTable.put() completes as follows:

table.put(...).get();

I will fix it and re-push it.

brfrn169 · 2020-11-26T00:30:58Z

I don't think the failed UTs in the last QA are related to this patch, but I will trigger QA again just in case.

Apache-HBase · 2020-11-26T01:38:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 56s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 29s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 12s	master passed
+1 💚	checkstyle	3m 3s	master passed
+1 💚	spotbugs	5m 47s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 18s	the patch passed
+1 💚	checkstyle	0m 34s	hbase-client: The patch generated 0 new + 276 unchanged - 1 fixed = 276 total (was 277)
+1 💚	checkstyle	1m 23s	The patch passed checkstyle in hbase-server
+1 💚	checkstyle	0m 50s	The patch passed checkstyle in hbase-thrift
+1 💚	checkstyle	0m 18s	The patch passed checkstyle in hbase-rest
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 38s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	7m 7s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 48s	The patch does not generate ASF License warnings.
		65m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/8/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2630
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux a3bc474bfd4e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1726160`
Max. process+thread count	95 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/8/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-11-26T03:45:08Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 30s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 38s	master passed
+1 💚	compile	3m 31s	master passed
+1 💚	shadedjars	9m 27s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 1s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 16s	the patch passed
+1 💚	compile	3m 15s	the patch passed
+1 💚	javac	3m 15s	the patch passed
+1 💚	shadedjars	9m 26s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 27s	hbase-client in the patch passed.
-1 ❌	unit	137m 14s	hbase-server in the patch failed.
+1 💚	unit	4m 4s	hbase-thrift in the patch passed.
+1 💚	unit	3m 13s	hbase-rest in the patch passed.
		192m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2630
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4ac48571b6d4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1726160`
Default Java	AdoptOpenJDK-11.0.6+10
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/8/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/8/testReport/
Max. process+thread count	4218 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/8/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-11-26T03:46:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 46s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 47s	master passed
+1 💚	compile	2m 32s	master passed
+1 💚	shadedjars	7m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 3s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 7s	the patch passed
+1 💚	compile	2m 35s	the patch passed
+1 💚	javac	2m 35s	the patch passed
+1 💚	shadedjars	7m 51s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 13s	hbase-client in the patch passed.
-1 ❌	unit	144m 4s	hbase-server in the patch failed.
+1 💚	unit	4m 28s	hbase-thrift in the patch passed.
+1 💚	unit	4m 1s	hbase-rest in the patch passed.
		194m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2630
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux da7413adfbf6 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1726160`
Default Java	AdoptOpenJDK-1.8.0_232-b09
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/8/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/8/testReport/
Max. process+thread count	4008 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/8/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

brfrn169 · 2020-11-26T04:29:52Z

I don't think the failed UTs are related to this change. The failed UTs were successful locally. I will merge this PR.

brfrn169 self-assigned this Nov 7, 2020

This comment has been minimized.

Sign in to view

brfrn169 requested a review from Apache9 November 7, 2020 23:00

Apache9 requested changes Nov 10, 2020

View reviewed changes

brfrn169 commented Nov 13, 2020

View reviewed changes

brfrn169 requested a review from Apache9 November 13, 2020 13:01

brfrn169 force-pushed the HBASE-25242 branch from d086fea to 399e3fd Compare November 13, 2020 13:34

This comment has been minimized.

Sign in to view

Apache9 requested changes Nov 21, 2020

View reviewed changes

brfrn169 commented Nov 21, 2020

View reviewed changes

brfrn169 requested a review from Apache9 November 21, 2020 17:46

brfrn169 force-pushed the HBASE-25242 branch from 399e3fd to 2a3bf95 Compare November 22, 2020 00:51

This comment has been minimized.

Sign in to view

brfrn169 force-pushed the HBASE-25242 branch from 2a3bf95 to 2baf627 Compare November 22, 2020 02:25

Apache9 requested changes Nov 22, 2020

View reviewed changes

brfrn169 force-pushed the HBASE-25242 branch from 2baf627 to c58d778 Compare November 22, 2020 15:36

This comment has been minimized.

Sign in to view

apurtell approved these changes Nov 23, 2020

View reviewed changes

brfrn169 requested a review from Apache9 November 25, 2020 00:17

brfrn169 force-pushed the HBASE-25242 branch from c58d778 to 66a915d Compare November 25, 2020 12:38

This comment has been minimized.

Sign in to view

Apache9 approved these changes Nov 25, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

HBASE-25242 Add Increment/Append support to RowMutations

b76370a

brfrn169 force-pushed the HBASE-25242 branch from 66a915d to b76370a Compare November 25, 2020 16:42

This comment has been minimized.

Sign in to view

brfrn169 merged commit b142f5d into apache:master Nov 26, 2020

HBASE-25242 Add Increment/Append support to RowMutations #2630

HBASE-25242 Add Increment/Append support to RowMutations #2630

Conversation

brfrn169 commented Nov 7, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

brfrn169 commented Nov 7, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brfrn169 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

brfrn169 commented Nov 18, 2020

Apache9 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brfrn169 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brfrn169 commented Nov 22, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

brfrn169 commented Nov 22, 2020

Apache-HBase commented Nov 22, 2020

Apache-HBase commented Nov 22, 2020

Apache-HBase commented Nov 22, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

apurtell left a comment

Choose a reason for hiding this comment

brfrn169 commented Nov 25, 2020

brfrn169 commented Nov 25, 2020

This comment has been minimized.

Apache9 left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

Apache9 commented Nov 25, 2020

brfrn169 commented Nov 25, 2020

This comment has been minimized.

This comment has been minimized.

brfrn169 commented Nov 26, 2020

Apache-HBase commented Nov 26, 2020

Apache-HBase commented Nov 26, 2020

Apache-HBase commented Nov 26, 2020

brfrn169 commented Nov 26, 2020