HBASE-24850 CellComparator perf improvement #2802

ramkrish86 · 2020-12-22T05:59:59Z

No description provided.

matcher where we have more cols

Apache-HBase · 2020-12-22T06:44:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 37s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 42s	master passed
+1 💚	checkstyle	1m 33s	master passed
+1 💚	spotbugs	2m 43s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 29s	the patch passed
-0 ⚠️	checkstyle	0m 27s	hbase-common: The patch generated 2 new + 145 unchanged - 0 fixed = 147 total (was 145)
+1 💚	whitespace	0m 1s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 11s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 1s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 26s	The patch does not generate ASF License warnings.
		43m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2802/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2802
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux a74bd0c150b4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dcb38f4`
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2802/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt
Max. process+thread count	94 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2802/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-12-22T08:50:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 41s	master passed
+1 💚	compile	1m 23s	master passed
+1 💚	shadedjars	6m 42s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 1s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 29s	the patch passed
+1 💚	compile	1m 20s	the patch passed
+1 💚	javac	1m 20s	the patch passed
+1 💚	shadedjars	6m 38s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 22s	hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	unit	1m 34s	hbase-common in the patch passed.
+1 💚	unit	139m 24s	hbase-server in the patch passed.
		169m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2802/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2802
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2f17994e3d9e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dcb38f4`
Default Java	AdoptOpenJDK-1.8.0_232-b09
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2802/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-common.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2802/1/testReport/
Max. process+thread count	4051 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2802/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-12-22T13:43:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 48s	master passed
+1 💚	checkstyle	1m 32s	master passed
+1 💚	spotbugs	2m 42s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 26s	the patch passed
+1 💚	checkstyle	1m 30s	the patch passed
+1 💚	whitespace	0m 1s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 16s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 1s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 26s	The patch does not generate ASF License warnings.
		42m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2802/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2802
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 4d3b8cf6d706 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dcb38f4`
Max. process+thread count	94 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2802/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-12-22T15:46:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 4s	master passed
+1 💚	compile	1m 32s	master passed
+1 💚	shadedjars	6m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 4s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 6s	the patch passed
+1 💚	compile	1m 32s	the patch passed
+1 💚	javac	1m 32s	the patch passed
+1 💚	shadedjars	6m 34s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	hbase-common generated 0 new + 12 unchanged - 3 fixed = 12 total (was 15)
+1 💚	javadoc	0m 39s	hbase-server in the patch passed.
		_ Other Tests _
+1 💚	unit	1m 46s	hbase-common in the patch passed.
+1 💚	unit	133m 29s	hbase-server in the patch passed.
		165m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2802/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2802
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3f32c104fdad 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dcb38f4`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2802/2/testReport/
Max. process+thread count	4100 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2802/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-12-22T15:52:07Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 43s	master passed
+1 💚	compile	1m 18s	master passed
+1 💚	shadedjars	6m 32s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 0s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 29s	the patch passed
+1 💚	compile	1m 20s	the patch passed
+1 💚	javac	1m 20s	the patch passed
+1 💚	shadedjars	6m 32s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 58s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 33s	hbase-common in the patch passed.
-1 ❌	unit	140m 59s	hbase-server in the patch failed.
		170m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2802/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2802
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7429f7574144 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dcb38f4`
Default Java	AdoptOpenJDK-1.8.0_232-b09
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2802/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2802/2/testReport/
Max. process+thread count	3857 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2802/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ramkrish86 added 10 commits December 22, 2020 11:23

Using ContiguousCellFormat as a marker alone

297e898

Commit the new file

cafe8af

Fix the comparator logic that was an oversight

849faf1

Fix the sequenceId check order

82272a4

Adding few more static methods that helps in scan flow like query

9884df3

matcher where we have more cols

Remove ContiguousCellFormat and ensure compare() can be inlined

77074b4

applying negation as per review comment

beabe69

Fix checkstyle comments

34b6e55

fix review comments

96fb77a

Address review comments

b8f67db

Fix the checkstyle issues

11015ba

Fix javadoc

572169b

ramkrish86 merged commit 140c7f6 into apache:master Dec 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-24850 CellComparator perf improvement #2802

HBASE-24850 CellComparator perf improvement #2802

ramkrish86 commented Dec 22, 2020

Apache-HBase commented Dec 22, 2020

Apache-HBase commented Dec 22, 2020

Apache-HBase commented Dec 22, 2020

Apache-HBase commented Dec 22, 2020

Apache-HBase commented Dec 22, 2020

HBASE-24850 CellComparator perf improvement #2802

HBASE-24850 CellComparator perf improvement #2802

Conversation

ramkrish86 commented Dec 22, 2020

Apache-HBase commented Dec 22, 2020

Apache-HBase commented Dec 22, 2020

Apache-HBase commented Dec 22, 2020

Apache-HBase commented Dec 22, 2020

Apache-HBase commented Dec 22, 2020