HBASE-25570 On largish cluster, "CleanerChore: Could not delete dir..… #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahrs87
reviewed
Feb 12, 2021
| + "happening, use following exception when asking on mailing list.", | ||
| type, dir, ioe); | ||
| if (LOG.isTraceEnabled()) { | ||
| LOG.info("Could not delete {} under {}; will retry. If it keeps happening, " + |
There was a problem hiding this comment.
should this be at LOG.trace ?
There was a problem hiding this comment.
You are right (though I suppose it doesn't matter much because of the if-check.. but let me fix. Thanks for review.
|
🎊 +1 overall
This message was automatically generated. |
shahrs87
reviewed
Feb 12, 2021
| } else { | ||
| LOG.info("Could not delete {} under {}; will retry. If it keeps happening, enable" + | ||
| "TRACE-level logging and quote the exception when asking on mailing list.", | ||
| type, dir, ioe.getMessage()); |
There was a problem hiding this comment.
nit: space between enable and TRACE-level.
One more concern. I may be wrong in this. ioe.getMessage() will be treated as string and not Throwable. Since we are using string formatter, we need another {} formatter to add exception's message to log.
@saintstack Could you please verify that log is printed as expected ? Thank you !
There was a problem hiding this comment.
This is a good one. Thank you. Fixed.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
force-pushed
the
HBASE-25570
branch
from
4d27473
to
793c6e7
Compare
…." makes master log unreadable Turn down the amount we log. If you want to see the full exception enable TRACE-level logging.
saintstack
force-pushed
the
HBASE-25570
branch
from
793c6e7
to
25bab67
Compare
|
Address the helpful @shahrs87 feedback. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
shahrs87
approved these changes
Feb 15, 2021
| LOG.trace("Could not delete {} under {}; will retry. If it keeps happening, " + | ||
| "quote the exception when asking on mailing list.", type, dir, ioe); | ||
| } else { | ||
| LOG.info("Could not delete {} under {} because {}; will retry. If it keeps happening, enable" + |
There was a problem hiding this comment.
super nit: space between enable and TRACE-level for better readability.
Apache9
approved these changes
Mar 3, 2021
saintstack
added a commit
that referenced
this pull request
Mar 12, 2021
…." makes master log unreadable (#2949) Turn down the amount we log. If you want to see the full exception enable TRACE-level logging. Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: shahrs87
saintstack
added a commit
that referenced
this pull request
Mar 12, 2021
…." makes master log unreadable (#2949) Turn down the amount we log. If you want to see the full exception enable TRACE-level logging. Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: shahrs87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…." makes master log unreadable
Turn down the amount we log. If you want to see the full exception
enable TRACE-level logging.