HBASE-22551 TestMasterOperationsForRegionReplicas is flakey #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersomogyi
approved these changes
Jun 9, 2019
| } finally { | ||
| ADMIN.disableTable(tableName); | ||
| ADMIN.deleteTable(tableName); | ||
| } | ||
| } | ||
|
|
||
| @Test @Ignore("Enable when we have support for alter_table- HBASE-10361") | ||
| @Test | ||
| @Ignore("Enable when we have support for alter_table- HBASE-10361") |
There was a problem hiding this comment.
Unrelated, but HBASE-10361 has merged ages ago. I will open a JIRA to remove @ignore.
There was a problem hiding this comment.
Let me include this in the new patch, just a one line change.
There was a problem hiding this comment.
Oh the test fails locally for me... Then let's use a new issue to address it...
There was a problem hiding this comment.
It also fails for me and the try block catches the underlying exception from ADMIN.enableTable(tableName);. Better to work on this on a new issue.
|
💔 -1 overall
This message was automatically generated. |
saintstack
approved these changes
Jun 9, 2019
| if (ADMIN != null) ADMIN.close(); | ||
| if (CONNECTION != null && !CONNECTION.isClosed()) CONNECTION.close(); | ||
| Closeables.close(ADMIN, true); | ||
| Closeables.close(CONNECTION, true); |
There was a problem hiding this comment.
This is a nice utility...
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.