HBASE-25562 ReplicationSourceWALReader log and handle exception immed… #2966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddupg
added
the
backport
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
| } else { | ||
| LOG.error("Failed to read stream of replication entries", e); | ||
| handleEofException(e); | ||
| if (!handleEofException(e)) { |
There was a problem hiding this comment.
let's reset the sleep multiplier it EOF was handled, something like.
if (handleEofException(e))
{
sleepMultiplier = 1;
}There was a problem hiding this comment.
Thank @sandeepvinayak for reviewing.
How about keeping resetting sleepMultiplier only in there where read WAL successfully? What I'm thinking is that handleEofException just deals with exceptions and we still need to retry to get back to the correct logic. We reset sleepMultiplier only after the logic getting back correct?
There was a problem hiding this comment.
yeah, but in handleEofException, we deque the bad(or empty) log file and do the repair work. So if we did the repair work why not reset the sleep multiplier?
There was a problem hiding this comment.
OK, I modified the code as your comments.
sandeepvinayak
suggested changes
Feb 22, 2021
…iately without retrying
ddupg
force-pushed
the
branch-2.3-HBASE-25562
branch
from
e7e463e
to
a6f7c39
Compare
sandeepvinayak
approved these changes
Feb 22, 2021
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iately without retrying