HBASE-25656 Backport to branch-2.2: [HBASE-25548 Optionally allow sna… #3055

wchevreuil · 2021-03-16T16:40:45Z

…pshots to preserve cluster's max filesize config by setting it into table descriptor]

saintstack

LGTM. Its safe to backport because we provide defaults for the API added?

Apache-HBase · 2021-03-16T21:19:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ branch-2.2 Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 23s	branch-2.2 passed
+1 💚	compile	1m 57s	branch-2.2 passed
+1 💚	checkstyle	4m 38s	branch-2.2 passed
+0 🆗	refguide	16m 14s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	shadedjars	4m 17s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 46s	branch-2.2 passed
+0 🆗	spotbugs	3m 3s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	17m 12s	branch-2.2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 3s	the patch passed
+1 💚	compile	2m 7s	the patch passed
+1 💚	cc	2m 7s	the patch passed
+1 💚	javac	2m 7s	the patch passed
-1 ❌	checkstyle	0m 40s	hbase-client: The patch generated 3 new + 270 unchanged - 0 fixed = 273 total (was 270)
-1 ❌	checkstyle	2m 17s	root: The patch generated 3 new + 298 unchanged - 0 fixed = 301 total (was 298)
-1 ❌	rubocop	0m 10s	The patch generated 3 new + 370 unchanged - 1 fixed = 373 total (was 371)
-1 ❌	whitespace	0m 0s	The patch has 25 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+0 🆗	refguide	5m 22s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	shadedjars	3m 55s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	27m 38s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚	hbaseprotoc	5m 28s	the patch passed
-1 ❌	javadoc	0m 25s	hbase-client generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
-1 ❌	javadoc	2m 18s	root generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
-1 ❌	findbugs	1m 28s	hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-1 ❌	findbugs	9m 16s	root generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	unit	138m 52s	root in the patch passed.
+1 💚	asflicense	2m 40s	The patch does not generate ASF License warnings.
		277m 25s

Reason	Tests
FindBugs	module:hbase-client
	Useless object stored in variable snapshotProps of method org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.createSnapshotDesc(SnapshotProtos$SnapshotDescription) At ProtobufUtil.java:snapshotProps of method org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.createSnapshotDesc(SnapshotProtos$SnapshotDescription) At ProtobufUtil.java:[line 2946]
FindBugs	module:root
	Useless object stored in variable snapshotProps of method org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.createSnapshotDesc(SnapshotProtos$SnapshotDescription) At ProtobufUtil.java:snapshotProps of method org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.createSnapshotDesc(SnapshotProtos$SnapshotDescription) At ProtobufUtil.java:[line 2946]

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/Dockerfile
GITHUB PR	#3055
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop refguide
uname	Linux 2a972c14b5e6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3055/out/precommit/personality/provided.sh
git revision	branch-2.2 / `bf6fad3`
Default Java	Oracle Corporation-1.8.0_282-b08
refguide	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/branch-site/book.html
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/diff-checkstyle-root.txt
rubocop	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/diff-patch-rubocop.txt
whitespace	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/whitespace-eol.txt
refguide	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/patch-site/book.html
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/diff-javadoc-javadoc-hbase-client.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/diff-javadoc-javadoc-root.txt
findbugs	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/new-findbugs-hbase-client.html
findbugs	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/new-findbugs-root.html
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/testReport/
Max. process+thread count	3101 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-shell . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/console
versions	git=2.20.1 maven=3.6.3 findbugs=3.1.11 rubocop=0.81.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

petersomogyi

Looks fine to me. I only have a question on the RSGroup related doc changes.

src/main/asciidoc/_chapters/ops_mgt.adoc

…y-pick

wchevreuil · 2021-03-17T14:35:34Z

LGTM. Its safe to backport because we provide defaults for the API added?

Correct, the parameter is optional, if not specified, we'll not apply it.

petersomogyi

🚢

Apache-HBase · 2021-03-17T17:36:47Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ branch-2.2 Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 13s	branch-2.2 passed
+1 💚	compile	1m 56s	branch-2.2 passed
+1 💚	checkstyle	4m 32s	branch-2.2 passed
+0 🆗	refguide	16m 17s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	shadedjars	4m 0s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 29s	branch-2.2 passed
+0 🆗	spotbugs	2m 48s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	15m 21s	branch-2.2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 54s	the patch passed
+1 💚	compile	1m 55s	the patch passed
+1 💚	cc	1m 55s	the patch passed
+1 💚	javac	1m 55s	the patch passed
-1 ❌	checkstyle	0m 43s	hbase-client: The patch generated 1 new + 270 unchanged - 0 fixed = 271 total (was 270)
-1 ❌	checkstyle	2m 8s	root: The patch generated 1 new + 298 unchanged - 0 fixed = 299 total (was 298)
-1 ❌	rubocop	0m 11s	The patch generated 3 new + 370 unchanged - 1 fixed = 373 total (was 371)
-1 ❌	whitespace	0m 0s	The patch has 25 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+0 🆗	refguide	5m 9s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	shadedjars	4m 4s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	27m 29s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚	hbaseprotoc	5m 27s	the patch passed
+1 💚	javadoc	3m 48s	the patch passed
+1 💚	findbugs	16m 7s	the patch passed
		_ Other Tests _
+1 💚	unit	136m 51s	root in the patch passed.
+1 💚	asflicense	2m 37s	The patch does not generate ASF License warnings.
		269m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/2/artifact/out/Dockerfile
GITHUB PR	#3055
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop refguide
uname	Linux 9cba0eb71fdb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3055/out/precommit/personality/provided.sh
git revision	branch-2.2 / `bf6fad3`
Default Java	Oracle Corporation-1.8.0_282-b08
refguide	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/2/artifact/out/branch-site/book.html
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/2/artifact/out/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/2/artifact/out/diff-checkstyle-root.txt
rubocop	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/2/artifact/out/diff-patch-rubocop.txt
whitespace	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/2/artifact/out/whitespace-eol.txt
refguide	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/2/artifact/out/patch-site/book.html
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/2/testReport/
Max. process+thread count	3829 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-shell . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/2/console
versions	git=2.20.1 maven=3.6.3 findbugs=3.1.11 rubocop=0.81.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-03-17T22:07:07Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ branch-2.2 Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 11s	branch-2.2 passed
+1 💚	compile	1m 56s	branch-2.2 passed
+1 💚	checkstyle	4m 26s	branch-2.2 passed
+0 🆗	refguide	16m 19s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	shadedjars	4m 2s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 31s	branch-2.2 passed
+0 🆗	spotbugs	2m 38s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	15m 6s	branch-2.2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 52s	the patch passed
+1 💚	compile	1m 57s	the patch passed
+1 💚	cc	1m 57s	the patch passed
+1 💚	javac	1m 57s	the patch passed
-1 ❌	checkstyle	0m 44s	hbase-client: The patch generated 1 new + 270 unchanged - 0 fixed = 271 total (was 270)
-1 ❌	checkstyle	2m 10s	root: The patch generated 1 new + 298 unchanged - 0 fixed = 299 total (was 298)
-1 ❌	rubocop	0m 10s	The patch generated 3 new + 370 unchanged - 1 fixed = 373 total (was 371)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+0 🆗	refguide	5m 17s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	shadedjars	4m 0s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	25m 42s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚	hbaseprotoc	5m 20s	the patch passed
+1 💚	javadoc	3m 42s	the patch passed
+1 💚	findbugs	18m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	137m 53s	root in the patch passed.
+1 💚	asflicense	2m 34s	The patch does not generate ASF License warnings.
		269m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/3/artifact/out/Dockerfile
GITHUB PR	#3055
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop refguide
uname	Linux e39fdb1ecec1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3055/out/precommit/personality/provided.sh
git revision	branch-2.2 / `bf6fad3`
Default Java	Oracle Corporation-1.8.0_282-b08
refguide	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/3/artifact/out/branch-site/book.html
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/3/artifact/out/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/3/artifact/out/diff-checkstyle-root.txt
rubocop	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/3/artifact/out/diff-patch-rubocop.txt
refguide	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/3/artifact/out/patch-site/book.html
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/3/testReport/
Max. process+thread count	3938 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-shell . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/3/console
versions	git=2.20.1 maven=3.6.3 findbugs=3.1.11 rubocop=0.81.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

apache#3055) Signed-off-by: Peter Somogyi <psomogyi@apache.org> Signed-off-by: Michael Stack <stack@apache.org> (cherry picked from commit 36a0f01) Change-Id: I2a73d3a466dea1bd7d6d440a6905d4c044828def

HBASE-25656 Backport to branch-2.2: [HBASE-25548 Optionally allow sna…

344a0a4

…pshots to preserve cluster's max filesize config by setting it into table descriptor]

wchevreuil requested review from petersomogyi and anoopsjohn March 16, 2021 16:40

saintstack approved these changes Mar 16, 2021

View reviewed changes

fixing checkstyles and findbugs

10fbfcd

petersomogyi approved these changes Mar 17, 2021

View reviewed changes

src/main/asciidoc/_chapters/ops_mgt.adoc Outdated Show resolved Hide resolved

wchevreuil added 2 commits March 17, 2021 14:26

reverting change on rs group chapter inadvertently added by git cherr…

699307d

…y-pick

removed other portions that had also been changed by the cherry-pick

c44fc7e

petersomogyi approved these changes Mar 17, 2021

View reviewed changes

wchevreuil merged commit 36a0f01 into apache:branch-2.2 Mar 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-25656 Backport to branch-2.2: [HBASE-25548 Optionally allow sna… #3055

HBASE-25656 Backport to branch-2.2: [HBASE-25548 Optionally allow sna… #3055

wchevreuil commented Mar 16, 2021

saintstack left a comment

Apache-HBase commented Mar 16, 2021

petersomogyi left a comment

wchevreuil commented Mar 17, 2021

petersomogyi left a comment

Apache-HBase commented Mar 17, 2021

Apache-HBase commented Mar 17, 2021

HBASE-25656 Backport to branch-2.2: [HBASE-25548 Optionally allow sna… #3055

HBASE-25656 Backport to branch-2.2: [HBASE-25548 Optionally allow sna… #3055

Conversation

wchevreuil commented Mar 16, 2021

saintstack left a comment

Choose a reason for hiding this comment

Apache-HBase commented Mar 16, 2021

petersomogyi left a comment

Choose a reason for hiding this comment

wchevreuil commented Mar 17, 2021

petersomogyi left a comment

Choose a reason for hiding this comment

Apache-HBase commented Mar 17, 2021

Apache-HBase commented Mar 17, 2021