HBASE-25781 Add cacheBlocks option to RowCounter #3177
+13
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
saintstack
requested changes
Apr 16, 2021
| @@ -64,13 +64,15 @@ | |||
|
|
|||
| private final static String OPT_START_TIME = "starttime"; | |||
| private final static String OPT_END_TIME = "endtime"; | |||
| private final static String OPT_IS_CACHE_BLOCKS = "isCacheBlocks"; | |||
There was a problem hiding this comment.
Should be named 'cacheBlocks'?
| private final static String OPT_RANGE = "range"; | ||
| private final static String OPT_EXPECTED_COUNT = "expectedCount"; | ||
|
|
||
| private String tableName; | ||
| private List<MultiRowRangeFilter.RowRange> rowRangeList; | ||
| private long startTime; | ||
| private long endTime; | ||
| private boolean isCacheBlocks; |
There was a problem hiding this comment.
isCacheBlocks is name of the method that looks at the cacheBlock data member content, not the name of the data member... so suggest s/isCacheBlocks/cacheBlocks/
There was a problem hiding this comment.
Okay, I'll fix it right away, as well as the changes I missed to submit last time
shenshengli
changed the title
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
anoopsjohn
reviewed
Apr 19, 2021
| this.startTime = getOptionAsLong(cmd, OPT_START_TIME, 0L); | ||
| this.endTime = getOptionAsLong(cmd, OPT_END_TIME, HConstants.LATEST_TIMESTAMP); | ||
| this.expectedCount = getOptionAsLong(cmd, OPT_EXPECTED_COUNT, Long.MIN_VALUE); | ||
| this.cacheBlocks = cmd.hasOption(OPT_CACHE_BLOCKS) ? true : false; |
There was a problem hiding this comment.
this.cacheBlocks = cmd.hasOption(OPT_CACHE_BLOCKS);
Is enough no?
There was a problem hiding this comment.
What u mean?
The state var is a variable and assign it with o/p of the check is enough.
We dont need like if hasOption() the set to true or else set to false.
Its a minor thing though.
So instead of having
this.cacheBlocks = cmd.hasOption(OPT_CACHE_BLOCKS) ? true : false;
Below is enough
this.cacheBlocks = cmd.hasOption(OPT_CACHE_BLOCKS) ;
There was a problem hiding this comment.
I made a ridiculous mistake. I'll correct it right away. Thank you very much
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.