Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-25809 [branch-1] TestAtomicOperation.testMultiRowMutationMultiThreads deadlock #3198

Merged
merged 1 commit into from Apr 24, 2021

Conversation

apurtell
Copy link
Contributor

@apurtell apurtell commented Apr 23, 2021

TestAtomicOperation.testMultiRowMutationMultiThreads deadlocks.

There is an easy fix for the test that synchronizes on the CHM instead of the object. We already have a Findbugs exceptions for synchronization on the CHM and get-then-set on it is what we synchronizing for anyway.

This is only relevant for branch-1 because we have to synchronize get-then-set due to Java 7 compatibility. For branch-2 and master we use CHM#computeIfPresent.

@apurtell apurtell requested a review from Reidddddd April 23, 2021 22:10
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 6m 44s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
+1 💚 mvninstall 10m 5s branch-1 passed
+1 💚 compile 0m 42s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 compile 0m 47s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 checkstyle 1m 49s branch-1 passed
+1 💚 shadedjars 3m 2s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 48s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 0m 41s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗 spotbugs 3m 6s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 3s branch-1 passed
_ Patch Compile Tests _
+1 💚 mvninstall 1m 56s the patch passed
+1 💚 compile 0m 41s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javac 0m 41s the patch passed
+1 💚 compile 0m 44s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 javac 0m 44s the patch passed
+1 💚 checkstyle 1m 40s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 2m 49s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 4m 44s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 javadoc 0m 32s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 0m 41s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 findbugs 2m 54s the patch passed
_ Other Tests _
+1 💚 unit 104m 0s hbase-server in the patch passed.
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
152m 38s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3198/1/artifact/out/Dockerfile
GITHUB PR #3198
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 121c4dee9762 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3198/out/precommit/personality/provided.sh
git revision branch-1 / 16304aa
Default Java Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3198/1/testReport/
Max. process+thread count 4294 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3198/1/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@Reidddddd Reidddddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Reidddddd Reidddddd merged commit 38b21f4 into apache:branch-1 Apr 24, 2021
@apurtell apurtell deleted the HBASE-25809-branch-1 branch April 24, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants