HBASE-25932: Ensure replication reads the trailer bytes from WAL. (#3… #3345

bharathv · 2021-06-01T05:58:34Z

…332)

This bug was exposed by the test from HBASE-25924. Since this wal
implementations close the wal asynchronously, replication can potentially
miss the trailer bytes. (see jira comment for detailed analysis).

While this is not a correctness problem (since trailer does not have any entry data),
it erroneously bumps a metric that is used to track skipped bytes in WAL resulting
in false alarms which is something we should avoid.

Reviewed-by: Rushabh Shah rushabh.shah@salesforce.com
Signed-off-by: Viraj Jasani vjasani@apache.org
Signed-off-by Anoop Sam John anoopsamjohn@apache.org
(cherry picked from commit b04c3c7)

…ache#3332) This bug was exposed by the test from HBASE-25924. Since this wal implementations close the wal asynchronously, replication can potentially miss the trailer bytes. (see jira comment for detailed analysis). While this is not a correctness problem (since trailer does not have any entry data), it erroneously bumps a metric that is used to track skipped bytes in WAL resulting in false alarms which is something we should avoid. Reviewed-by: Rushabh Shah <rushabh.shah@salesforce.com> Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by Anoop Sam John <anoopsamjohn@apache.org> (cherry picked from commit b04c3c7)

Apache-HBase · 2021-06-01T06:39:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 40s	branch-2 passed
+1 💚	compile	3m 13s	branch-2 passed
+1 💚	checkstyle	1m 8s	branch-2 passed
+1 💚	spotbugs	2m 6s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 17s	the patch passed
+1 💚	compile	3m 9s	the patch passed
+1 💚	javac	3m 9s	the patch passed
-0 ⚠️	checkstyle	1m 5s	hbase-server: The patch generated 2 new + 15 unchanged - 0 fixed = 17 total (was 15)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 43s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 14s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		39m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3345/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3345
JIRA Issue	HBASE-25932
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 3c8b147c8c0d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0ede56d`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3345/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3345/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-06-01T08:40:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	4m 22s	branch-2 passed
+1 💚	compile	1m 8s	branch-2 passed
+1 💚	shadedjars	6m 52s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 58s	the patch passed
+1 💚	compile	1m 7s	the patch passed
+1 💚	javac	1m 7s	the patch passed
+1 💚	shadedjars	6m 45s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	the patch passed
		_ Other Tests _
+1 💚	unit	132m 16s	hbase-server in the patch passed.
		160m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3345/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3345
JIRA Issue	HBASE-25932
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c5e202ca984f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0ede56d`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3345/1/testReport/
Max. process+thread count	4120 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3345/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-06-01T08:55:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 47s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	4m 36s	branch-2 passed
+1 💚	compile	1m 10s	branch-2 passed
+1 💚	shadedjars	7m 53s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 45s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 14s	the patch passed
+1 💚	compile	1m 10s	the patch passed
+1 💚	javac	1m 10s	the patch passed
+1 💚	shadedjars	7m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	the patch passed
		_ Other Tests _
+1 💚	unit	144m 30s	hbase-server in the patch passed.
		176m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3345/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3345
JIRA Issue	HBASE-25932
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 38a1624acb8d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0ede56d`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3345/1/testReport/
Max. process+thread count	4242 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3345/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bharathv merged commit d4285be into apache:branch-2 Jun 1, 2021

bharathv deleted the HBASE-25932-branch-2 branch June 1, 2021 15:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-25932: Ensure replication reads the trailer bytes from WAL. (#3… #3345

HBASE-25932: Ensure replication reads the trailer bytes from WAL. (#3… #3345

bharathv commented Jun 1, 2021

Apache-HBase commented Jun 1, 2021

Apache-HBase commented Jun 1, 2021

Apache-HBase commented Jun 1, 2021

HBASE-25932: Ensure replication reads the trailer bytes from WAL. (#3… #3345

HBASE-25932: Ensure replication reads the trailer bytes from WAL. (#3… #3345

Conversation

bharathv commented Jun 1, 2021

Apache-HBase commented Jun 1, 2021

Apache-HBase commented Jun 1, 2021

Apache-HBase commented Jun 1, 2021