Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-25986 set default value of normalization enabled from hbase site #3372

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

mnpoonia
Copy link
Contributor

No description provided.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 3s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for branch
+1 💚 mvninstall 4m 13s master passed
+1 💚 compile 5m 2s master passed
+1 💚 checkstyle 2m 0s master passed
+0 🆗 refguide 3m 44s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotbugs 3m 56s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 4m 2s the patch passed
+1 💚 compile 5m 3s the patch passed
+1 💚 javac 5m 3s the patch passed
+1 💚 checkstyle 0m 23s The patch passed checkstyle in hbase-common
+1 💚 checkstyle 0m 28s hbase-client: The patch generated 0 new + 29 unchanged - 1 fixed = 29 total (was 30)
+1 💚 checkstyle 1m 10s The patch passed checkstyle in hbase-server
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+0 🆗 refguide 3m 38s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 hadoopcheck 19m 55s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 4m 31s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 33s The patch does not generate ASF License warnings.
69m 8s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3372
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile refguide xml
uname Linux a7501911cff8 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 329f0ba
Default Java AdoptOpenJDK-1.8.0_282-b08
refguide https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/1/artifact/yetus-general-check/output/branch-site/book.html
refguide https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/1/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 28s Maven dependency ordering for branch
+1 💚 mvninstall 4m 13s master passed
+1 💚 compile 2m 2s master passed
+1 💚 shadedjars 8m 40s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 31s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 3m 55s the patch passed
+1 💚 compile 2m 0s the patch passed
+1 💚 javac 2m 0s the patch passed
+1 💚 shadedjars 8m 33s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 29s the patch passed
_ Other Tests _
+1 💚 unit 1m 56s hbase-common in the patch passed.
+1 💚 unit 1m 25s hbase-client in the patch passed.
+1 💚 unit 157m 58s hbase-server in the patch passed.
197m 39s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3372
Optional Tests javac javadoc unit shadedjars compile
uname Linux 1c3d968cf2d9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 329f0ba
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/1/testReport/
Max. process+thread count 4227 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 34s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for branch
+1 💚 mvninstall 4m 59s master passed
+1 💚 compile 2m 21s master passed
+1 💚 shadedjars 9m 23s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 33s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 52s the patch passed
+1 💚 compile 2m 15s the patch passed
+1 💚 javac 2m 15s the patch passed
+1 💚 shadedjars 9m 3s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 31s the patch passed
_ Other Tests _
+1 💚 unit 2m 12s hbase-common in the patch passed.
+1 💚 unit 1m 40s hbase-client in the patch passed.
+1 💚 unit 208m 49s hbase-server in the patch passed.
253m 4s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3372
Optional Tests javac javadoc unit shadedjars compile
uname Linux 7a7d59788532 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 329f0ba
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/1/testReport/
Max. process+thread count 2655 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@mnpoonia
Copy link
Contributor Author

@virajjasani Mind having a look in your free cycles.

@virajjasani
Copy link
Contributor

virajjasani commented Jun 19, 2021

I think rather than site config, having a switch command would be more beneficial.
Something like switch_cluster_normalizer <true>/<false> would not require us to re-deploy with updated site config.
WDYT @ndimiduk ?

@mnpoonia
Copy link
Contributor Author

mnpoonia commented Jun 21, 2021

I think rather than site config, having a switch command would be more beneficial.
Something like switch_cluster_normalizer <true>/<false> would not require us to re-deploy with updated site config.

We already have a switch command which switch the cluster level normalizer. This change is to set default table descriptor value that to something a user wants. The idea here is to enable normalizer by default to true/false for a table using configuration similar to what we do for cluster level normalizer configuration.

We can always switch the normalizer to false at cluster level if there is an issue.

@virajjasani virajjasani requested a review from Apache9 June 22, 2021 10:10
Copy link
Member

@ndimiduk ndimiduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the intended behavior? Can you outline how the system should behave based on presence/absence of values in hbase-site, TableDescriptor, and the ZooKeeper flag using a truth table?

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 1s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for branch
+1 💚 mvninstall 4m 14s master passed
+1 💚 compile 5m 1s master passed
+1 💚 checkstyle 2m 4s master passed
+0 🆗 refguide 3m 40s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotbugs 3m 56s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 4m 2s the patch passed
+1 💚 compile 5m 6s the patch passed
+1 💚 javac 5m 6s the patch passed
+1 💚 checkstyle 0m 23s The patch passed checkstyle in hbase-common
+1 💚 checkstyle 0m 29s hbase-client: The patch generated 0 new + 29 unchanged - 1 fixed = 29 total (was 30)
+1 💚 checkstyle 1m 9s The patch passed checkstyle in hbase-server
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+0 🆗 refguide 3m 40s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 hadoopcheck 20m 1s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
-1 ❌ spotbugs 2m 25s hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 💚 asflicense 0m 33s The patch does not generate ASF License warnings.
69m 17s
Reason Tests
FindBugs module:hbase-server
Nullcheck of tblDesc at line 191 of value previously dereferenced in org.apache.hadoop.hbase.master.normalizer.RegionNormalizerWorker.calculatePlans(TableName) At RegionNormalizerWorker.java:191 of value previously dereferenced in org.apache.hadoop.hbase.master.normalizer.RegionNormalizerWorker.calculatePlans(TableName) At RegionNormalizerWorker.java:[line 191]
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3372
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile refguide xml
uname Linux 774707785bf0 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 22ec681
Default Java AdoptOpenJDK-1.8.0_282-b08
refguide https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/artifact/yetus-general-check/output/branch-site/book.html
refguide https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/artifact/yetus-general-check/output/patch-site/book.html
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for branch
+1 💚 mvninstall 3m 53s master passed
+1 💚 compile 1m 49s master passed
+1 💚 shadedjars 8m 14s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 23s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 38s the patch passed
+1 💚 compile 1m 52s the patch passed
+1 💚 javac 1m 52s the patch passed
+1 💚 shadedjars 8m 17s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 22s the patch passed
_ Other Tests _
+1 💚 unit 1m 46s hbase-common in the patch passed.
+1 💚 unit 1m 15s hbase-client in the patch passed.
+1 💚 unit 130m 7s hbase-server in the patch passed.
167m 22s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3372
Optional Tests javac javadoc unit shadedjars compile
uname Linux 65e16b7d73b5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 22ec681
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/testReport/
Max. process+thread count 4095 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 37s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for branch
+1 💚 mvninstall 6m 3s master passed
+1 💚 compile 2m 36s master passed
+1 💚 shadedjars 10m 44s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 18s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 5m 52s the patch passed
+1 💚 compile 2m 18s the patch passed
+1 💚 javac 2m 18s the patch passed
+1 💚 shadedjars 9m 9s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 30s the patch passed
_ Other Tests _
+1 💚 unit 2m 15s hbase-common in the patch passed.
+1 💚 unit 1m 43s hbase-client in the patch passed.
+1 💚 unit 181m 30s hbase-server in the patch passed.
230m 41s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3372
Optional Tests javac javadoc unit shadedjars compile
uname Linux 7d198451a57a 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 22ec681
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/testReport/
Max. process+thread count 2763 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 4s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for branch
+1 💚 mvninstall 4m 14s master passed
+1 💚 compile 5m 4s master passed
+1 💚 checkstyle 2m 2s master passed
+0 🆗 refguide 3m 42s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotbugs 3m 55s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 58s the patch passed
+1 💚 compile 5m 1s the patch passed
+1 💚 javac 5m 1s the patch passed
+1 💚 checkstyle 0m 24s The patch passed checkstyle in hbase-common
+1 💚 checkstyle 0m 28s hbase-client: The patch generated 0 new + 29 unchanged - 1 fixed = 29 total (was 30)
+1 💚 checkstyle 1m 8s The patch passed checkstyle in hbase-server
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+0 🆗 refguide 3m 45s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 hadoopcheck 20m 3s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 4m 33s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 32s The patch does not generate ASF License warnings.
69m 19s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3372
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile refguide xml
uname Linux 510c5b923e14 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 22ec681
Default Java AdoptOpenJDK-1.8.0_282-b08
refguide https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/artifact/yetus-general-check/output/branch-site/book.html
refguide https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 36s master passed
+1 💚 compile 1m 54s master passed
+1 💚 shadedjars 8m 18s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 22s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 41s the patch passed
+1 💚 compile 1m 49s the patch passed
+1 💚 javac 1m 49s the patch passed
+1 💚 shadedjars 8m 12s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 21s the patch passed
_ Other Tests _
+1 💚 unit 1m 46s hbase-common in the patch passed.
+1 💚 unit 1m 17s hbase-client in the patch passed.
-1 ❌ unit 129m 52s hbase-server in the patch failed.
166m 48s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3372
Optional Tests javac javadoc unit shadedjars compile
uname Linux 318ab4c2091d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 22ec681
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/testReport/
Max. process+thread count 4113 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 5s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 4m 43s master passed
+1 💚 compile 2m 13s master passed
+1 💚 shadedjars 9m 1s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 29s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 4m 48s the patch passed
+1 💚 compile 2m 13s the patch passed
+1 💚 javac 2m 13s the patch passed
+1 💚 shadedjars 8m 57s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 29s the patch passed
_ Other Tests _
+1 💚 unit 2m 13s hbase-common in the patch passed.
+1 💚 unit 1m 39s hbase-client in the patch passed.
+1 💚 unit 183m 54s hbase-server in the patch passed.
226m 23s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3372
Optional Tests javac javadoc unit shadedjars compile
uname Linux 6545d7a31364 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 22ec681
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/testReport/
Max. process+thread count 2772 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@mnpoonia
Copy link
Contributor Author

hbase-site table descriptor used
defined defined table descriptor value
defined not defined hbase-site value
not defined defined table descriptor value
not defined not defined use from hbase-default

@ndimiduk - The above table defines the order in which value is being considered.
Basically if the property is defined in table descriptor than value of that is used else hbase-site value will be used. And we will always have default value false in hbase-default

Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, still trying to understand compatibility concerns.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 6m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 4m 17s master passed
+1 💚 compile 5m 1s master passed
+1 💚 checkstyle 2m 1s master passed
+0 🆗 refguide 3m 38s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotbugs 3m 54s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 59s the patch passed
+1 💚 compile 5m 4s the patch passed
+1 💚 javac 5m 4s the patch passed
+1 💚 checkstyle 0m 24s The patch passed checkstyle in hbase-common
+1 💚 checkstyle 0m 28s hbase-client: The patch generated 0 new + 29 unchanged - 1 fixed = 29 total (was 30)
+1 💚 checkstyle 1m 11s The patch passed checkstyle in hbase-server
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+0 🆗 refguide 3m 36s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 hadoopcheck 20m 17s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 4m 57s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 32s The patch does not generate ASF License warnings.
75m 31s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3372
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile refguide xml
uname Linux db09279e7677 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a3ad97f
Default Java AdoptOpenJDK-1.8.0_282-b08
refguide https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/artifact/yetus-general-check/output/branch-site/book.html
refguide https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 3m 52s master passed
+1 💚 compile 1m 54s master passed
+1 💚 shadedjars 8m 54s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 31s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 4m 7s the patch passed
+1 💚 compile 2m 0s the patch passed
+1 💚 javac 2m 0s the patch passed
+1 💚 shadedjars 9m 14s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 22s the patch passed
_ Other Tests _
+1 💚 unit 1m 41s hbase-common in the patch passed.
+1 💚 unit 1m 17s hbase-client in the patch passed.
+1 💚 unit 147m 53s hbase-server in the patch passed.
187m 20s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3372
Optional Tests javac javadoc unit shadedjars compile
uname Linux 6d0797ac4230 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a3ad97f
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/testReport/
Max. process+thread count 4469 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 8s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 4m 54s master passed
+1 💚 compile 2m 12s master passed
+1 💚 shadedjars 9m 6s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 32s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 44s the patch passed
+1 💚 compile 2m 13s the patch passed
+1 💚 javac 2m 13s the patch passed
+1 💚 shadedjars 9m 3s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 29s the patch passed
_ Other Tests _
+1 💚 unit 2m 23s hbase-common in the patch passed.
+1 💚 unit 1m 39s hbase-client in the patch passed.
-1 ❌ unit 213m 1s hbase-server in the patch failed.
256m 14s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3372
Optional Tests javac javadoc unit shadedjars compile
uname Linux fcac66082cfb 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a3ad97f
Default Java AdoptOpenJDK-11.0.10+9
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/testReport/
Max. process+thread count 3602 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@mnpoonia
Copy link
Contributor Author

mnpoonia commented Jul 7, 2021

Test failure seems to be unrelated. @virajjasani FYI

Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments, almost there.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 19s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 3m 51s master passed
+1 💚 compile 4m 56s master passed
+1 💚 checkstyle 1m 55s master passed
+0 🆗 refguide 3m 53s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotbugs 3m 55s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 37s the patch passed
+1 💚 compile 4m 55s the patch passed
+1 💚 javac 4m 55s the patch passed
+1 💚 checkstyle 0m 23s The patch passed checkstyle in hbase-common
+1 💚 checkstyle 0m 28s hbase-client: The patch generated 0 new + 29 unchanged - 1 fixed = 29 total (was 30)
+1 💚 checkstyle 1m 1s The patch passed checkstyle in hbase-server
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+0 🆗 refguide 3m 26s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 hadoopcheck 18m 14s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 4m 19s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 40s The patch does not generate ASF License warnings.
65m 52s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3372
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile refguide xml
uname Linux 0a22ab1484fb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 875b63c
Default Java AdoptOpenJDK-1.8.0_282-b08
refguide https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/5/artifact/yetus-general-check/output/branch-site/book.html
refguide https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/5/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count 96 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/5/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for branch
+1 💚 mvninstall 3m 38s master passed
+1 💚 compile 1m 52s master passed
+1 💚 shadedjars 8m 17s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 21s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 40s the patch passed
+1 💚 compile 1m 56s the patch passed
+1 💚 javac 1m 56s the patch passed
+1 💚 shadedjars 8m 15s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 21s the patch passed
_ Other Tests _
+1 💚 unit 1m 46s hbase-common in the patch passed.
+1 💚 unit 1m 17s hbase-client in the patch passed.
+1 💚 unit 144m 52s hbase-server in the patch passed.
181m 57s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3372
Optional Tests javac javadoc unit shadedjars compile
uname Linux 921443a92c82 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 875b63c
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/5/testReport/
Max. process+thread count 3890 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/5/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, please create branch-2 and branch-1 PRs. We can merge them together once QA results are published.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 3m 39s master passed
+1 💚 compile 1m 52s master passed
+1 💚 shadedjars 8m 6s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 23s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 3m 43s the patch passed
+1 💚 compile 1m 50s the patch passed
+1 💚 javac 1m 50s the patch passed
+1 💚 shadedjars 8m 16s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 23s the patch passed
_ Other Tests _
+1 💚 unit 1m 48s hbase-common in the patch passed.
+1 💚 unit 1m 16s hbase-client in the patch passed.
+1 💚 unit 144m 12s hbase-server in the patch passed.
180m 24s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3372
Optional Tests javac javadoc unit shadedjars compile
uname Linux 86773fe5383c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 875b63c
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/7/testReport/
Max. process+thread count 4017 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/7/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani virajjasani merged commit 0f31317 into apache:master Jul 19, 2021
virajjasani pushed a commit that referenced this pull request Jul 19, 2021
#3476) (#3372)

Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani pushed a commit that referenced this pull request Jul 19, 2021
#3476) (#3372)

Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani pushed a commit that referenced this pull request Jul 19, 2021
#3492) (#3372)

Signed-off-by: Viraj Jasani <vjasani@apache.org>
@mnpoonia mnpoonia deleted the normalizer_HBASE-25986 branch July 19, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants