HBASE-22923 min version of RegionServer to move system table regions #3438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
apurtell
approved these changes
Jun 29, 2021
| * "hbase.min.version.move.system.tables" as "2.0.0". | ||
| * When operator uses this config, it should be used with care, meaning | ||
| * we should be confident that even if user table regions come to RS with | ||
| * higher version (that rest of cluster), it would not cause any |
There was a problem hiding this comment.
The language here is ambiguous. Better to say something like
When the operator uses this configuration option, any version between the current version and the new value of "hbase.min.version.move.system.tables" does not trigger any region movement. It is assumed the configured range of versions do not require special handling.
This should also be committed to all branches, not just branch-1, for consistent functionality across all future releasing versions.
bharathv
requested changes
Jun 29, 2021
| * | ||
| * @return List of Excluded servers for System table regions. | ||
| */ | ||
| private List<ServerName> getExcludedServersForSystemTableUnlessAllowed() { |
There was a problem hiding this comment.
Can we club the logic of both the methods and pass an optional boolean for version check?
The two functions that look very much alike except for the tail part.
|
Also, the "localhost" part is suspicious, why does AM look for a localhost address? |
It is And it is and similar logic is available few other places in |
bharathv
approved these changes
Jun 30, 2021
Comment on lines
+2598
to
+2599
| if (checkForMinVersion) { | ||
| if (!DEFAULT_MIN_VERSION_MOVE_SYS_TABLES_CONFIG.equals(minVersionToMoveSysTables)) { |
There was a problem hiding this comment.
super nit: club the conditions
There was a problem hiding this comment.
Since the argument checkForMinVersion controls this specific flow, I thought keeping it this way would make it more readable. Thought?
There was a problem hiding this comment.
I don't have a strong opinion. If you ask me, I like the following version but its subjective. I'm fine with whatever you think is good.
checkForMinVersion = checkForMinVersion && !DEFAULT_MIN_VERSION_MOVE_SYS_TABLES_CONFIG.equals(minVersionToMoveSysTables);
if (checkForMinVersion) {
,,,,
}
There was a problem hiding this comment.
Love these discussions, always learn a thing or two :)
decisionFactor = decisionFactor && additionalFactors yeah, this is also nice way. I wish we had some standards around this.
For now, let me keep it as is as you don't have strong opinion, I still find this simpler from readability viewpoint:
if (decisionFactor) {
if (additionalFactors) {
}
}
I think this is why we don't have standards because individuals find different approaches as simpler ones than others (but CPU doesn't care :) )
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.