Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-26150 Let region server also carry ClientMetaService #3550

Merged
merged 2 commits into from
Aug 4, 2021
Merged

HBASE-26150 Let region server also carry ClientMetaService #3550

merged 2 commits into from
Aug 4, 2021

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Aug 2, 2021

No description provided.

@Apache9 Apache9 self-assigned this Aug 2, 2021
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 3m 53s master passed
+1 💚 compile 2m 31s master passed
+1 💚 shadedjars 8m 7s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 30s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 39s the patch passed
+1 💚 compile 2m 33s the patch passed
+1 💚 javac 2m 33s the patch passed
+1 💚 shadedjars 8m 11s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 22s hbase-client generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)
_ Other Tests _
+1 💚 unit 0m 46s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 14s hbase-client in the patch passed.
+1 💚 unit 0m 46s hbase-zookeeper in the patch passed.
-1 ❌ unit 7m 59s hbase-server in the patch failed.
45m 51s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3550
Optional Tests javac javadoc unit shadedjars compile
uname Linux 0e9b08079cc5 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2e9ab3c
Default Java AdoptOpenJDK-1.8.0_282-b08
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-client.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/testReport/
Max. process+thread count 1022 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 31s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 4m 43s master passed
+1 💚 compile 3m 14s master passed
+1 💚 shadedjars 8m 41s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 46s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 4m 28s the patch passed
+1 💚 compile 3m 5s the patch passed
+1 💚 javac 3m 5s the patch passed
+1 💚 shadedjars 8m 32s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 27s hbase-client generated 1 new + 55 unchanged - 0 fixed = 56 total (was 55)
_ Other Tests _
+1 💚 unit 1m 0s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 21s hbase-client in the patch passed.
+1 💚 unit 0m 46s hbase-zookeeper in the patch passed.
-1 ❌ unit 8m 57s hbase-server in the patch failed.
51m 36s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3550
Optional Tests javac javadoc unit shadedjars compile
uname Linux 328d8c697e89 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2e9ab3c
Default Java AdoptOpenJDK-11.0.10+9
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-client.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/testReport/
Max. process+thread count 1045 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 20s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 4m 26s master passed
+1 💚 compile 6m 49s master passed
+1 💚 checkstyle 2m 4s master passed
+1 💚 spotbugs 7m 55s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 4m 5s the patch passed
+1 💚 compile 6m 26s the patch passed
+1 💚 cc 6m 26s the patch passed
+1 💚 javac 6m 26s the patch passed
-0 ⚠️ checkstyle 1m 11s hbase-server: The patch generated 4 new + 172 unchanged - 7 fixed = 176 total (was 179)
-0 ⚠️ whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 hadoopcheck 24m 37s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 hbaseprotoc 3m 43s the patch passed
+1 💚 spotbugs 14m 35s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 30s The patch does not generate ASF License warnings.
92m 53s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3550
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname Linux 0e536760ff4a 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2e9ab3c
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bharathv
bharathv reviewed Aug 2, 2021
View reviewed changes
Copy link
Contributor

@bharathv bharathv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor seems straight forward. A couple of minor comments, mainly one on client facing configuration name.

hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java Outdated Show resolved Hide resolved
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcConnectionRegistry.java Outdated Show resolved Hide resolved
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 35s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 3m 55s master passed
+1 💚 compile 2m 33s master passed
+1 💚 shadedjars 8m 17s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 35s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
-1 ❌ mvninstall 1m 11s root in the patch failed.
-1 ❌ compile 0m 29s hbase-client in the patch failed.
-1 ❌ compile 0m 39s hbase-server in the patch failed.
-0 ⚠️ javac 0m 29s hbase-client in the patch failed.
-0 ⚠️ javac 0m 39s hbase-server in the patch failed.
-1 ❌ shadedjars 4m 26s patch has 24 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 41s hbase-server generated 3 new + 21 unchanged - 0 fixed = 24 total (was 21)
_ Other Tests _
+1 💚 unit 0m 55s hbase-protocol-shaded in the patch passed.
-1 ❌ unit 0m 30s hbase-client in the patch failed.
+1 💚 unit 0m 46s hbase-zookeeper in the patch passed.
-1 ❌ unit 0m 41s hbase-server in the patch failed.
31m 38s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3550
Optional Tests javac javadoc unit shadedjars compile
uname Linux 2d950bc12a6f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / de84c17
Default Java AdoptOpenJDK-1.8.0_282-b08
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-client.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-client.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-client.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/testReport/
Max. process+thread count 492 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 7m 1s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 5m 13s master passed
+1 💚 compile 3m 18s master passed
+1 💚 shadedjars 9m 15s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 42s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
-1 ❌ mvninstall 1m 32s root in the patch failed.
-1 ❌ compile 0m 31s hbase-client in the patch failed.
-1 ❌ compile 0m 47s hbase-server in the patch failed.
-0 ⚠️ javac 0m 31s hbase-client in the patch failed.
-0 ⚠️ javac 0m 47s hbase-server in the patch failed.
-1 ❌ shadedjars 4m 18s patch has 24 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 23s hbase-server in the patch failed.
_ Other Tests _
+1 💚 unit 1m 6s hbase-protocol-shaded in the patch passed.
-1 ❌ unit 0m 30s hbase-client in the patch failed.
+1 💚 unit 0m 51s hbase-zookeeper in the patch passed.
-1 ❌ unit 0m 45s hbase-server in the patch failed.
41m 51s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3550
Optional Tests javac javadoc unit shadedjars compile
uname Linux c2d2d9cc967a 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / de84c17
Default Java AdoptOpenJDK-11.0.10+9
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/testReport/
Max. process+thread count 274 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 1s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 29s Maven dependency ordering for branch
+1 💚 mvninstall 3m 58s master passed
+1 💚 compile 6m 48s master passed
+1 💚 checkstyle 2m 8s master passed
+1 💚 spotbugs 8m 35s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
-1 ❌ mvninstall 1m 16s root in the patch failed.
-1 ❌ compile 0m 56s hbase-client in the patch failed.
-1 ❌ compile 0m 50s hbase-server in the patch failed.
-0 ⚠️ cc 0m 56s hbase-client in the patch failed.
-0 ⚠️ cc 0m 50s hbase-server in the patch failed.
-0 ⚠️ javac 0m 56s hbase-client in the patch failed.
-0 ⚠️ javac 0m 50s hbase-server in the patch failed.
-0 ⚠️ checkstyle 1m 16s hbase-server: The patch generated 1 new + 172 unchanged - 7 fixed = 173 total (was 179)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
-1 ❌ hadoopcheck 1m 30s The patch causes 24 errors with Hadoop v3.1.2.
-1 ❌ hadoopcheck 3m 3s The patch causes 24 errors with Hadoop v3.2.1.
-1 ❌ hadoopcheck 4m 41s The patch causes 24 errors with Hadoop v3.3.0.
-1 ❌ hbaseprotoc 0m 23s hbase-client in the patch failed.
-1 ❌ hbaseprotoc 0m 50s hbase-server in the patch failed.
-1 ❌ spotbugs 0m 19s hbase-client in the patch failed.
-1 ❌ spotbugs 0m 32s hbase-server in the patch failed.
_ Other Tests _
+1 💚 asflicense 0m 41s The patch does not generate ASF License warnings.
47m 4s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3550
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname Linux 52bc432bf9f6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / de84c17
Default Java AdoptOpenJDK-1.8.0_282-b08
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
cc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
cc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-general-check/output/patch-javac-3.2.1.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-general-check/output/patch-javac-3.3.0.txt
hbaseprotoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-client.txt
hbaseprotoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-server.txt
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-client.txt
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt
Max. process+thread count 96 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/2/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 46s master passed
+1 💚 compile 6m 14s master passed
+1 💚 checkstyle 2m 0s master passed
+1 💚 spotbugs 7m 45s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 44s the patch passed
+1 💚 compile 6m 14s the patch passed
+1 💚 cc 6m 14s the patch passed
+1 💚 javac 6m 14s the patch passed
-0 ⚠️ checkstyle 1m 6s hbase-server: The patch generated 1 new + 172 unchanged - 7 fixed = 173 total (was 179)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 18m 26s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 hbaseprotoc 2m 19s the patch passed
+1 💚 spotbugs 8m 33s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 49s The patch does not generate ASF License warnings.
71m 59s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3550
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname Linux f8ad221f3b61 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f3175c5
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 96 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bharathv
bharathv approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@bharathv bharathv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 59s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 3m 52s master passed
+1 💚 compile 2m 34s master passed
+1 💚 shadedjars 8m 9s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 31s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 40s the patch passed
+1 💚 compile 2m 36s the patch passed
+1 💚 javac 2m 36s the patch passed
+1 💚 shadedjars 8m 15s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 29s the patch passed
_ Other Tests _
+1 💚 unit 0m 45s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 16s hbase-client in the patch passed.
+1 💚 unit 0m 45s hbase-zookeeper in the patch passed.
-1 ❌ unit 149m 29s hbase-server in the patch failed.
191m 55s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3550
Optional Tests javac javadoc unit shadedjars compile
uname Linux dd7076410109 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f3175c5
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/testReport/
Max. process+thread count 4329 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 11s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 4m 54s master passed
+1 💚 compile 3m 19s master passed
+1 💚 shadedjars 9m 17s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 41s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 4m 53s the patch passed
+1 💚 compile 3m 21s the patch passed
+1 💚 javac 3m 21s the patch passed
+1 💚 shadedjars 9m 14s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 42s the patch passed
_ Other Tests _
+1 💚 unit 1m 6s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 40s hbase-client in the patch passed.
+1 💚 unit 0m 50s hbase-zookeeper in the patch passed.
-1 ❌ unit 204m 30s hbase-server in the patch failed.
250m 45s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3550
Optional Tests javac javadoc unit shadedjars compile
uname Linux 89c96543e322 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f3175c5
Default Java AdoptOpenJDK-11.0.10+9
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/testReport/
Max. process+thread count 3530 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 53s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 4m 17s master passed
+1 💚 compile 6m 29s master passed
+1 💚 checkstyle 1m 59s master passed
+1 💚 spotbugs 8m 10s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 8s the patch passed
+1 💚 compile 6m 39s the patch passed
+1 💚 cc 6m 39s the patch passed
+1 💚 javac 6m 39s the patch passed
-0 ⚠️ checkstyle 1m 13s hbase-server: The patch generated 1 new + 172 unchanged - 7 fixed = 173 total (was 179)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 20m 50s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 hbaseprotoc 2m 35s the patch passed
+1 💚 spotbugs 9m 29s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 47s The patch does not generate ASF License warnings.
83m 12s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3550
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname Linux c8f58d521665 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f3175c5
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 96 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/4/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for branch
+1 💚 mvninstall 3m 37s master passed
+1 💚 compile 2m 36s master passed
+1 💚 shadedjars 8m 12s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 31s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 42s the patch passed
+1 💚 compile 2m 34s the patch passed
+1 💚 javac 2m 34s the patch passed
+1 💚 shadedjars 8m 10s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 30s the patch passed
_ Other Tests _
+1 💚 unit 0m 46s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 14s hbase-client in the patch passed.
+1 💚 unit 0m 45s hbase-zookeeper in the patch passed.
+1 💚 unit 147m 43s hbase-server in the patch passed.
186m 33s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3550
Optional Tests javac javadoc unit shadedjars compile
uname Linux 267d814a01c3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f3175c5
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/4/testReport/
Max. process+thread count 4265 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 3s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 5m 4s master passed
+1 💚 compile 3m 12s master passed
+1 💚 shadedjars 9m 12s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 38s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 51s the patch passed
+1 💚 compile 3m 12s the patch passed
+1 💚 javac 3m 12s the patch passed
+1 💚 shadedjars 9m 3s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 36s the patch passed
_ Other Tests _
+1 💚 unit 1m 5s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 38s hbase-client in the patch passed.
+1 💚 unit 0m 46s hbase-zookeeper in the patch passed.
+1 💚 unit 202m 54s hbase-server in the patch passed.
248m 16s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3550
Optional Tests javac javadoc unit shadedjars compile
uname Linux 801c5ee43d0b 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f3175c5
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/4/testReport/
Max. process+thread count 3626 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 45s master passed
+1 💚 compile 6m 8s master passed
+1 💚 checkstyle 1m 59s master passed
+1 💚 spotbugs 7m 52s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 45s the patch passed
+1 💚 compile 6m 22s the patch passed
+1 💚 cc 6m 22s the patch passed
+1 💚 javac 6m 22s the patch passed
+1 💚 checkstyle 0m 11s The patch passed checkstyle in hbase-protocol-shaded
+1 💚 checkstyle 0m 29s The patch passed checkstyle in hbase-client
+1 💚 checkstyle 0m 14s The patch passed checkstyle in hbase-zookeeper
+1 💚 checkstyle 1m 10s hbase-server: The patch generated 0 new + 172 unchanged - 7 fixed = 172 total (was 179)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 18m 35s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 hbaseprotoc 2m 22s the patch passed
+1 💚 spotbugs 8m 32s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 46s The patch does not generate ASF License warnings.
72m 5s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3550
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname Linux 5a417a9da91a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 73a0411
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 96 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/5/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit 63d4970 into apache:master Aug 4, 2021
Apache9 added a commit that referenced this pull request Aug 4, 2021
@Apache9
HBASE-26150 Let region server also carry ClientMetaService (#3550)
620806e 
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 1s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 4m 45s master passed
+1 💚 compile 3m 12s master passed
+1 💚 shadedjars 9m 5s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 35s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 4m 49s the patch passed
+1 💚 compile 3m 14s the patch passed
+1 💚 javac 3m 14s the patch passed
+1 💚 shadedjars 9m 4s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 37s the patch passed
_ Other Tests _
+1 💚 unit 1m 4s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 42s hbase-client in the patch passed.
+1 💚 unit 0m 47s hbase-zookeeper in the patch passed.
+1 💚 unit 204m 14s hbase-server in the patch passed.
249m 15s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3550
Optional Tests javac javadoc unit shadedjars compile
uname Linux 6f45b974b649 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 73a0411
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/5/testReport/
Max. process+thread count 3543 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/5/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 6s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 29s Maven dependency ordering for branch
+1 💚 mvninstall 4m 10s master passed
+1 💚 compile 2m 35s master passed
+1 💚 shadedjars 9m 2s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 24s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 7s the patch passed
+1 💚 compile 2m 33s the patch passed
+1 💚 javac 2m 33s the patch passed
+1 💚 shadedjars 9m 3s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 23s the patch passed
_ Other Tests _
+1 💚 unit 0m 48s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 24s hbase-client in the patch passed.
+1 💚 unit 0m 46s hbase-zookeeper in the patch passed.
+1 💚 unit 209m 36s hbase-server in the patch passed.
251m 8s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3550
Optional Tests javac javadoc unit shadedjars compile
uname Linux 20acb5b9370e 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 73a0411
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/5/testReport/
Max. process+thread count 3368 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/5/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

saintstack
saintstack reviewed Aug 9, 2021
View reviewed changes
Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

...-client/src/main/java/org/apache/hadoop/hbase/client/AbstractRpcBasedConnectionRegistry.java Show resolved Hide resolved
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcConnectionRegistry.java
* <p/>
* Usually, you could set masters as the bootstrap nodes,as they will also implement the
* {@link ClientMetaService}, and then, we will switch to use region servers after refreshing the
* bootstrap nodes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting. Is there pointer to how this will work -- the transition to RSs fielding Registry calls?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will replace the bootstrap nodes every time when we fetch the new bootstrap nodes. So once the client connects to cluster, no matter what the first bootstrap nodes are, it will switch to the new bootstrap nodes we want the client to use.

hbase-protocol-shaded/src/main/protobuf/server/Registry.proto
* Get nodes which could be used as ClientMetaService
*/
rpc GetBootstrapNodes(GetBootstrapNodesRequest) returns (GetBootstrapNodesResponse);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good -- i.e. moving to own proto file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saintstack saintstack saintstack left review comments

@bharathv bharathv bharathv approved these changes

Assignees

@Apache9 Apache9

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Apache9 @Apache-HBase @saintstack @bharathv