Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-25849 Backport HBASE-22738, HBASE-24760, & HBASE-25298 (Fallback feature for RS groups when there are no RS in current group) to branch-1 #3581

Merged
merged 1 commit into from
Aug 17, 2021
Merged

HBASE-25849 Backport HBASE-22738, HBASE-24760, & HBASE-25298 (Fallback feature for RS groups when there are no RS in current group) to branch-1 #3581

merged 1 commit into from
Aug 17, 2021

Conversation

caroliney14
Copy link
Contributor

No description provided.

@caroliney14 caroliney14 changed the title Backport HBASE-22738 & HBASE-24760 (Fallback feature for RS groups when there are no RS in current group) to branch-1 HBASE-25849 Backport HBASE-22738 & HBASE-24760 (Fallback feature for RS groups when there are no RS in current group) to branch-1 Aug 12, 2021
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 6m 42s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗 mvndep 2m 31s Maven dependency ordering for branch
+1 💚 mvninstall 8m 6s branch-1 passed
+1 💚 compile 0m 58s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 compile 1m 9s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 checkstyle 1m 57s branch-1 passed
+1 💚 shadedjars 3m 3s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 57s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 0m 58s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗 spotbugs 2m 42s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 47s branch-1 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for patch
+1 💚 mvninstall 1m 51s the patch passed
+1 💚 compile 1m 0s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javac 1m 0s the patch passed
+1 💚 compile 1m 9s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 javac 1m 9s the patch passed
-1 ❌ checkstyle 1m 32s hbase-server: The patch generated 2 new + 24 unchanged - 0 fixed = 26 total (was 24)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 2m 54s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 4m 38s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 javadoc 0m 46s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 0m 58s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
-1 ❌ findbugs 1m 0s hbase-rsgroup generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
_ Other Tests _
+1 💚 unit 132m 45s hbase-server in the patch passed.
+1 💚 unit 14m 29s hbase-rsgroup in the patch passed.
+1 💚 asflicense 0m 59s The patch does not generate ASF License warnings.
201m 38s
Reason Tests
FindBugs module:hbase-rsgroup
org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.retainAssignment(Map, List) makes inefficient use of keySet iterator instead of entrySet iterator At RSGroupBasedLoadBalancer.java:of keySet iterator instead of entrySet iterator At RSGroupBasedLoadBalancer.java:[line 227]
org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.roundRobinAssignment(List, List) makes inefficient use of keySet iterator instead of entrySet iterator At RSGroupBasedLoadBalancer.java:of keySet iterator instead of entrySet iterator At RSGroupBasedLoadBalancer.java:[line 201]
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/1/artifact/out/Dockerfile
GITHUB PR #3581
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 721f8da151e9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3581/out/precommit/personality/provided.sh
git revision branch-1 / 75844c8
Default Java Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/1/artifact/out/diff-checkstyle-hbase-server.txt
findbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/1/artifact/out/new-findbugs-hbase-rsgroup.html
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/1/testReport/
Max. process+thread count 4435 (vs. ulimit of 10000)
modules C: hbase-server hbase-rsgroup U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/1/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗 mvndep 2m 31s Maven dependency ordering for branch
+1 💚 mvninstall 8m 9s branch-1 passed
+1 💚 compile 1m 0s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 compile 1m 7s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 checkstyle 1m 53s branch-1 passed
+1 💚 shadedjars 3m 5s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 56s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 1m 3s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗 spotbugs 2m 44s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 49s branch-1 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 1m 51s the patch passed
+1 💚 compile 1m 1s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javac 1m 1s the patch passed
+1 💚 compile 1m 10s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 javac 1m 10s the patch passed
-1 ❌ checkstyle 1m 31s hbase-server: The patch generated 2 new + 24 unchanged - 0 fixed = 26 total (was 24)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 2m 50s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 4m 32s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 javadoc 0m 45s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 1m 0s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
-1 ❌ findbugs 1m 1s hbase-rsgroup generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
_ Other Tests _
+1 💚 unit 133m 18s hbase-server in the patch passed.
+1 💚 unit 13m 54s hbase-rsgroup in the patch passed.
+1 💚 asflicense 0m 58s The patch does not generate ASF License warnings.
195m 15s
Reason Tests
FindBugs module:hbase-rsgroup
org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.retainAssignment(Map, List) makes inefficient use of keySet iterator instead of entrySet iterator At RSGroupBasedLoadBalancer.java:of keySet iterator instead of entrySet iterator At RSGroupBasedLoadBalancer.java:[line 227]
org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.roundRobinAssignment(List, List) makes inefficient use of keySet iterator instead of entrySet iterator At RSGroupBasedLoadBalancer.java:of keySet iterator instead of entrySet iterator At RSGroupBasedLoadBalancer.java:[line 201]
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/2/artifact/out/Dockerfile
GITHUB PR #3581
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux c9b449f000b7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3581/out/precommit/personality/provided.sh
git revision branch-1 / 75844c8
Default Java Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/2/artifact/out/diff-checkstyle-hbase-server.txt
findbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/2/artifact/out/new-findbugs-hbase-rsgroup.html
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/2/testReport/
Max. process+thread count 4362 (vs. ulimit of 10000)
modules C: hbase-server hbase-rsgroup U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/2/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗 mvndep 2m 31s Maven dependency ordering for branch
+1 💚 mvninstall 8m 17s branch-1 passed
+1 💚 compile 1m 0s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 compile 1m 7s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 checkstyle 1m 56s branch-1 passed
+1 💚 shadedjars 3m 3s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 57s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 1m 0s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗 spotbugs 2m 46s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 50s branch-1 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 1m 52s the patch passed
+1 💚 compile 0m 58s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javac 0m 58s the patch passed
+1 💚 compile 1m 8s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 javac 1m 8s the patch passed
+1 💚 checkstyle 1m 49s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 2m 51s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 4m 32s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 javadoc 0m 45s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 1m 1s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 findbugs 3m 51s the patch passed
_ Other Tests _
+1 💚 unit 133m 34s hbase-server in the patch passed.
+1 💚 unit 14m 10s hbase-rsgroup in the patch passed.
+1 💚 asflicense 0m 59s The patch does not generate ASF License warnings.
196m 12s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/3/artifact/out/Dockerfile
GITHUB PR #3581
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux d629ba99f852 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3581/out/precommit/personality/provided.sh
git revision branch-1 / 75844c8
Default Java Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/3/testReport/
Max. process+thread count 4430 (vs. ulimit of 10000)
modules C: hbase-server hbase-rsgroup U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/3/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bharathv
Copy link
Contributor

Backport lgtm.

@caroliney14 Any tricky conflicts you ran into that needs a closer look? If not we can merge this.

@caroliney14
HBASE-25849 Backport HBASE-22738, HBASE-24760, & HBASE-25298 (Fallbac…
790f615 
…k feature for RS groups when there are no RS in current group) to branch-1
@caroliney14 caroliney14 changed the title HBASE-25849 Backport HBASE-22738 & HBASE-24760 (Fallback feature for RS groups when there are no RS in current group) to branch-1 HBASE-25849 Backport HBASE-22738, HBASE-24760, & HBASE-25298 (Fallback feature for RS groups when there are no RS in current group) to branch-1 Aug 16, 2021
@caroliney14
Copy link
Contributor Author

@bharathv nothing I can think of, thanks for the review. I also backported HBASE-25298 as you suggested.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 4 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗 mvndep 2m 29s Maven dependency ordering for branch
+1 💚 mvninstall 8m 7s branch-1 passed
+1 💚 compile 0m 59s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 compile 1m 8s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 checkstyle 1m 57s branch-1 passed
+1 💚 shadedjars 3m 5s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 56s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 1m 0s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗 spotbugs 2m 47s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 52s branch-1 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 1m 52s the patch passed
+1 💚 compile 1m 0s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javac 1m 0s the patch passed
+1 💚 compile 1m 8s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 javac 1m 8s the patch passed
+1 💚 checkstyle 1m 49s the patch passed
+1 💚 whitespace 0m 1s The patch has no whitespace issues.
+1 💚 shadedjars 2m 53s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 4m 27s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 javadoc 0m 47s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 0m 59s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 findbugs 3m 53s the patch passed
_ Other Tests _
+1 💚 unit 133m 37s hbase-server in the patch passed.
+1 💚 unit 14m 32s hbase-rsgroup in the patch passed.
+1 💚 asflicense 0m 57s The patch does not generate ASF License warnings.
196m 26s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/4/artifact/out/Dockerfile
GITHUB PR #3581
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux dbca82165da6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3581/out/precommit/personality/provided.sh
git revision branch-1 / 75844c8
Default Java Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/4/testReport/
Max. process+thread count 4425 (vs. ulimit of 10000)
modules C: hbase-server hbase-rsgroup U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/4/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

apurtell
apurtell approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@apurtell apurtell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed the patch overall. Looked more at the tests. Approved pending precommit results. Merge only if the result is good (or any failures are proven unrelated).

@virajjasani
Copy link
Contributor

virajjasani commented Aug 17, 2021 •
edited

Changes look good (and this is indeed must-have change, I have seen cluster not coming up well if stop all services and start them soon as regions with destination bogus server are stuck), I have retriggered QA build. Let's wait one more time and this can be merged most likely by today EOD.
Thanks @caroliney14

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 1s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 4 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗 mvndep 2m 29s Maven dependency ordering for branch
+1 💚 mvninstall 8m 8s branch-1 passed
+1 💚 compile 1m 0s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 compile 1m 7s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 checkstyle 1m 54s branch-1 passed
+1 💚 shadedjars 3m 4s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 56s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 0m 59s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗 spotbugs 2m 43s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 48s branch-1 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 1m 50s the patch passed
+1 💚 compile 0m 59s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javac 0m 59s the patch passed
+1 💚 compile 1m 6s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 javac 1m 6s the patch passed
+1 💚 checkstyle 1m 47s the patch passed
+1 💚 whitespace 0m 1s The patch has no whitespace issues.
+1 💚 shadedjars 2m 52s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 4m 32s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 javadoc 0m 47s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 0m 58s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 findbugs 3m 53s the patch passed
_ Other Tests _
-1 ❌ unit 136m 1s hbase-server in the patch failed.
+1 💚 unit 15m 24s hbase-rsgroup in the patch passed.
+1 💚 asflicense 0m 59s The patch does not generate ASF License warnings.
199m 31s
Reason Tests
Failed junit tests hadoop.hbase.master.TestMasterBalanceThrottling
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/5/artifact/out/Dockerfile
GITHUB PR #3581
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux a065845da909 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3581/out/precommit/personality/provided.sh
git revision branch-1 / 75844c8
Default Java Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/5/artifact/out/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/5/testReport/
Max. process+thread count 4353 (vs. ulimit of 10000)
modules C: hbase-server hbase-rsgroup U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/5/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani
Copy link
Contributor

Recent test failure is not relevant. The one before that had all tests passing. Let me merge the changes.

@virajjasani virajjasani merged commit ecac266 into apache:branch-1 Aug 17, 2021
@caroliney14
Copy link
Contributor Author

thanks @virajjasani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apurtell apurtell apurtell approved these changes

@virajjasani virajjasani virajjasani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@caroliney14 @Apache-HBase @bharathv @virajjasani @apurtell