HBASE-26141 Add tracing support for HTable and sync connection on branch-2 #3696

taklwu · 2021-09-23T07:25:11Z

RPC and IPC tracing supported by HBASE-26125
WAL tracing supported by HBASE-26131

…nch-2 * RPC and IPC supported by HBASE-26125 * WAL tracing supported by HBASE-26131

Apache-HBase · 2021-09-23T07:49:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 2s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 38s	branch-2 passed
+1 💚	compile	2m 10s	branch-2 passed
+1 💚	checkstyle	1m 7s	branch-2 passed
+1 💚	spotbugs	2m 21s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 6s	the patch passed
+1 💚	compile	2m 10s	the patch passed
-0 ⚠️	javac	1m 17s	hbase-client generated 7 new + 157 unchanged - 1 fixed = 164 total (was 158)
-0 ⚠️	checkstyle	0m 8s	The patch fails to run checkstyle in hbase-common
-0 ⚠️	checkstyle	0m 21s	The patch fails to run checkstyle in hbase-client
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	0m 40s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
-1 ❌	spotbugs	0m 22s	hbase-common in the patch failed.
-1 ❌	spotbugs	0m 21s	hbase-client in the patch failed.
		_ Other Tests _
+0 🆗	asflicense	0m 43s	ASF License check generated no output?
		23m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3696
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 9fabdfb98c46 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `59d133e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/1/artifact/yetus-general-check/output/buildtool-patch-checkstyle-hbase-common.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/1/artifact/yetus-general-check/output/buildtool-patch-checkstyle-hbase-client.txt
spotbugs	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-common.txt
spotbugs	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-client.txt
Max. process+thread count	96 (vs. ulimit of 12500)
modules	C: hbase-common hbase-client U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-23T07:58:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 48s	branch-2 passed
+1 💚	compile	1m 0s	branch-2 passed
+1 💚	shadedjars	7m 18s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 58s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 5s	the patch passed
+1 💚	compile	0m 59s	the patch passed
+1 💚	javac	0m 59s	the patch passed
-1 ❌	shadedjars	4m 5s	patch has 10 errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 53s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 5s	hbase-common in the patch passed.
+1 💚	unit	3m 15s	hbase-client in the patch passed.
		32m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3696
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 41a470ee28f3 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `59d133e`
Default Java	AdoptOpenJDK-11.0.10+9
shadedjars	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/1/testReport/
Max. process+thread count	341 (vs. ulimit of 12500)
modules	C: hbase-common hbase-client U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-23T08:00:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 54s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 44s	branch-2 passed
+1 💚	compile	1m 3s	branch-2 passed
+1 💚	shadedjars	8m 38s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 59s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 42s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
-1 ❌	shadedjars	4m 9s	patch has 10 errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 56s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 45s	hbase-common in the patch passed.
+1 💚	unit	2m 55s	hbase-client in the patch passed.
		34m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3696
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4d2c77ec7db7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `59d133e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
shadedjars	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/1/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/1/testReport/
Max. process+thread count	418 (vs. ulimit of 12500)
modules	C: hbase-common hbase-client U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9

Overall LGTM.

We have another issue for tracing the Admin interface?

hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java

hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java

taklwu

We have another issue for tracing the Admin interface?

Hey Duo, Thanks for pointing out the missing part, and I would like to confirm if the Admin and HBaseAdmin are the interface you're referring?

basically, I didn't find tracing implemented for RawAsyncHBaseAdmin and AsyncHBaseAdmin in HBASE-22120, did I miss some JIRAs ?

anyhow, looks like the scope of support Admin interface is huge as well, so if it's needed, I would like to have a followup JIRA for the sync client if possible, what do you think?

hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java

hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java

Apache-HBase · 2021-09-23T09:45:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 33s	branch-2 passed
+1 💚	compile	0m 58s	branch-2 passed
+1 💚	shadedjars	7m 32s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 55s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 15s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
+1 💚	shadedjars	7m 30s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 54s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 42s	hbase-common in the patch passed.
+1 💚	unit	2m 57s	hbase-client in the patch passed.
		35m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3696
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 66e19523cca1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `59d133e`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/2/testReport/
Max. process+thread count	364 (vs. ulimit of 12500)
modules	C: hbase-common hbase-client U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2021-09-23T09:51:54Z

We have another issue for tracing the Admin interface?

Hey Duo, Thanks for pointing out the missing part, and I would like to confirm if the Admin and HBaseAdmin are the interface you're referring?

basically, I didn't find tracing implemented for RawAsyncHBaseAdmin and AsyncHBaseAdmin in HBASE-22120, did I miss some JIRAs ?

anyhow, looks like the scope of support Admin interface is huge as well, so if it's needed, I would like to have a followup JIRA for the sync client if possible, what do you think?

OK, checked the release note of HBASE-22120, it does not mention the tracing about the Admin interface too. I think the rpc level tracing can basically work for Admin operations. We could file another issue if there are real requirements in the future.

Thanks.

Apache-HBase · 2021-09-23T09:54:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 46s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 17s	branch-2 passed
+1 💚	compile	1m 55s	branch-2 passed
+1 💚	checkstyle	1m 2s	branch-2 passed
+1 💚	spotbugs	2m 3s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 47s	the patch passed
+1 💚	compile	1m 55s	the patch passed
-0 ⚠️	javac	1m 5s	hbase-client generated 1 new + 157 unchanged - 1 fixed = 158 total (was 158)
-0 ⚠️	checkstyle	0m 33s	hbase-client: The patch generated 10 new + 39 unchanged - 8 fixed = 49 total (was 47)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	14m 46s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
-1 ❌	spotbugs	1m 27s	hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 23s	The patch does not generate ASF License warnings.
		44m 34s

Reason	Tests
FindBugs	module:hbase-client
	Inconsistent synchronization of org.apache.hadoop.hbase.client.ConnectionImplementation.choreService; locked 50% of time Unsynchronized access at ConnectionImplementation.java:50% of time Unsynchronized access at ConnectionImplementation.java:[line 2131]

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3696
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux abb0ee9c32fc 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `59d133e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
spotbugs	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/2/artifact/yetus-general-check/output/new-spotbugs-hbase-client.html
Max. process+thread count	86 (vs. ulimit of 12500)
modules	C: hbase-common hbase-client U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-23T09:55:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
-1 ❌	mvninstall	4m 41s	root in branch-2 failed.
+1 💚	compile	1m 8s	branch-2 passed
+1 💚	shadedjars	8m 52s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 14s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 29s	the patch passed
+1 💚	compile	1m 21s	the patch passed
+1 💚	javac	1m 21s	the patch passed
+1 💚	shadedjars	9m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 59s	hbase-common in the patch passed.
+1 💚	unit	3m 52s	hbase-client in the patch passed.
		45m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3696
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 223e304b89d4 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `59d133e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
mvninstall	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/2/artifact/yetus-jdk8-hadoop2-check/output/branch-mvninstall-root.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/2/testReport/
Max. process+thread count	279 (vs. ulimit of 12500)
modules	C: hbase-common hbase-client U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-23T17:55:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 8s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 46s	branch-2 passed
+1 💚	compile	0m 54s	branch-2 passed
+1 💚	shadedjars	6m 37s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 48s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 31s	the patch passed
+1 💚	compile	0m 50s	the patch passed
+1 💚	javac	0m 50s	the patch passed
+1 💚	shadedjars	6m 27s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 46s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 27s	hbase-common in the patch passed.
+1 💚	unit	2m 38s	hbase-client in the patch passed.
		30m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3696
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4c5d5ef53964 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `59d133e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/3/testReport/
Max. process+thread count	427 (vs. ulimit of 12500)
modules	C: hbase-common hbase-client U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-23T18:02:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 18s	Docker mode activated.
-0 ⚠️	yetus	0m 8s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 47s	branch-2 passed
+1 💚	compile	1m 0s	branch-2 passed
+1 💚	shadedjars	7m 53s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 54s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 36s	the patch passed
+1 💚	compile	0m 58s	the patch passed
+1 💚	javac	0m 58s	the patch passed
+1 💚	shadedjars	7m 54s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 51s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 51s	hbase-common in the patch passed.
+1 💚	unit	3m 8s	hbase-client in the patch passed.
		37m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3696
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fe474d87a20c 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `59d133e`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/3/testReport/
Max. process+thread count	281 (vs. ulimit of 12500)
modules	C: hbase-common hbase-client U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-23T18:04:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 26s	branch-2 passed
+1 💚	compile	2m 0s	branch-2 passed
+1 💚	checkstyle	0m 57s	branch-2 passed
+1 💚	spotbugs	1m 58s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 26s	the patch passed
+1 💚	compile	1m 54s	the patch passed
-0 ⚠️	javac	1m 4s	hbase-client generated 1 new + 157 unchanged - 1 fixed = 158 total (was 158)
-0 ⚠️	checkstyle	0m 32s	hbase-client: The patch generated 13 new + 42 unchanged - 14 fixed = 55 total (was 56)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 27s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 19s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 25s	The patch does not generate ASF License warnings.
		39m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3696
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 5c119ff57ddc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `59d133e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count	96 (vs. ulimit of 12500)
modules	C: hbase-common hbase-client U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-23T18:53:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 8s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 19s	branch-2 passed
+1 💚	compile	0m 54s	branch-2 passed
+1 💚	shadedjars	6m 29s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 23s	the patch passed
+1 💚	compile	0m 51s	the patch passed
+1 💚	javac	0m 51s	the patch passed
+1 💚	shadedjars	6m 31s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 46s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 24s	hbase-common in the patch passed.
+1 💚	unit	2m 41s	hbase-client in the patch passed.
		29m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3696
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 335b7dc1eb6d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `59d133e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/4/testReport/
Max. process+thread count	380 (vs. ulimit of 12500)
modules	C: hbase-common hbase-client U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-23T19:03:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 43s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 46s	branch-2 passed
+1 💚	compile	1m 57s	branch-2 passed
+1 💚	checkstyle	0m 59s	branch-2 passed
+1 💚	spotbugs	1m 56s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 24s	the patch passed
+1 💚	compile	1m 59s	the patch passed
-0 ⚠️	javac	1m 8s	hbase-client generated 1 new + 157 unchanged - 1 fixed = 158 total (was 158)
-0 ⚠️	checkstyle	0m 33s	hbase-client: The patch generated 1 new + 42 unchanged - 14 fixed = 43 total (was 56)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 0s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 26s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 26s	The patch does not generate ASF License warnings.
		39m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3696
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux eb6bc1dda153 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `59d133e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count	96 (vs. ulimit of 12500)
modules	C: hbase-common hbase-client U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-23T19:07:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 50s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 10s	branch-2 passed
+1 💚	compile	1m 8s	branch-2 passed
+1 💚	shadedjars	9m 55s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 11s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 34s	the patch passed
+1 💚	compile	1m 11s	the patch passed
+1 💚	javac	1m 11s	the patch passed
+1 💚	shadedjars	9m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 8s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 8s	hbase-common in the patch passed.
+1 💚	unit	3m 19s	hbase-client in the patch passed.
		43m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3696
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux aa2d59cfa936 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `59d133e`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/4/testReport/
Max. process+thread count	355 (vs. ulimit of 12500)
modules	C: hbase-common hbase-client U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-23T20:33:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 38s	branch-2 passed
+1 💚	compile	0m 51s	branch-2 passed
+1 💚	shadedjars	6m 32s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 27s	the patch passed
+1 💚	compile	0m 51s	the patch passed
+1 💚	javac	0m 51s	the patch passed
+1 💚	shadedjars	6m 28s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 46s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 34s	hbase-common in the patch passed.
+1 💚	unit	2m 42s	hbase-client in the patch passed.
		30m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3696
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0fbf3b5d9dcb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `59d133e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/5/testReport/
Max. process+thread count	383 (vs. ulimit of 12500)
modules	C: hbase-common hbase-client U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-23T20:38:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 57s	branch-2 passed
+1 💚	compile	0m 57s	branch-2 passed
+1 💚	shadedjars	7m 13s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 53s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 0s	the patch passed
+1 💚	compile	0m 56s	the patch passed
+1 💚	javac	0m 56s	the patch passed
+1 💚	shadedjars	7m 15s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 53s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 51s	hbase-common in the patch passed.
+1 💚	unit	2m 57s	hbase-client in the patch passed.
		34m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3696
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ee4cd0a350ec 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `59d133e`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/5/testReport/
Max. process+thread count	358 (vs. ulimit of 12500)
modules	C: hbase-common hbase-client U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-23T20:40:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 17s	branch-2 passed
+1 💚	compile	1m 54s	branch-2 passed
+1 💚	checkstyle	0m 58s	branch-2 passed
+1 💚	spotbugs	1m 56s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 19s	the patch passed
+1 💚	compile	1m 52s	the patch passed
-0 ⚠️	javac	1m 3s	hbase-client generated 1 new + 157 unchanged - 1 fixed = 158 total (was 158)
+1 💚	checkstyle	0m 24s	The patch passed checkstyle in hbase-common
+1 💚	checkstyle	0m 33s	hbase-client: The patch generated 0 new + 42 unchanged - 14 fixed = 42 total (was 56)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 40s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 18s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 25s	The patch does not generate ASF License warnings.
		37m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3696
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 4c36a27a2d5e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `59d133e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
Max. process+thread count	96 (vs. ulimit of 12500)
modules	C: hbase-common hbase-client U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3696/5/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

taklwu · 2021-09-23T20:48:54Z

the javac warning of Scan.java:[1097,5] [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead. is unrelated to this change

taklwu · 2021-09-23T20:52:13Z

hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java

+      if (rpcClient != null) {
+        rpcClient.close();
+      }
+      synchronized (this) {


this fix the error of spotbugs report during one of the precommit checks

Bug type IS2_INCONSISTENT_SYNC (click for details) In class org.apache.hadoop.hbase.client.ConnectionImplementation Field org.apache.hadoop.hbase.client.ConnectionImplementation.choreService Synchronized 50% of the time Unsynchronized access at ConnectionImplementation.java:[line 2131] Unsynchronized access at ConnectionImplementation.java:[line 2132] Synchronized access at ConnectionImplementation.java:[line 617] Synchronized access at ConnectionImplementation.java:[line 620] Synchronized access at ConnectionImplementation.java:[line 618]

Apache9

Let's try it.

HBASE-26141 Add tracing support for HTable and sync connection on bra…

822c616

…nch-2 * RPC and IPC supported by HBASE-26125 * WAL tracing supported by HBASE-26131

Apache9 reviewed Sep 23, 2021

View reviewed changes

hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java Outdated Show resolved Hide resolved

hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java Show resolved Hide resolved

taklwu commented Sep 23, 2021

View reviewed changes

hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java Outdated Show resolved Hide resolved

hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java Show resolved Hide resolved

fix javac and address comments for getHbck

0d96e44

more fix for checkstyle, javac and spotbugs

b8fea34

fix indentation

43a0319

taklwu requested review from Apache9, apurtell and anoopsjohn September 23, 2021 18:23

last checkstyle/indentation

c96c6c6

taklwu commented Sep 23, 2021

View reviewed changes

Apache9 approved these changes Sep 25, 2021

View reviewed changes

taklwu merged commit 49ae675 into apache:branch-2 Sep 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-26141 Add tracing support for HTable and sync connection on branch-2 #3696

HBASE-26141 Add tracing support for HTable and sync connection on branch-2 #3696

taklwu commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache9 left a comment

taklwu left a comment

Apache-HBase commented Sep 23, 2021

Apache9 commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

taklwu commented Sep 23, 2021

taklwu Sep 23, 2021

Apache9 left a comment

HBASE-26141 Add tracing support for HTable and sync connection on branch-2 #3696

HBASE-26141 Add tracing support for HTable and sync connection on branch-2 #3696

Conversation

taklwu commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache9 left a comment

Choose a reason for hiding this comment

taklwu left a comment

Choose a reason for hiding this comment

Apache-HBase commented Sep 23, 2021

Apache9 commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

Apache-HBase commented Sep 23, 2021

taklwu commented Sep 23, 2021

taklwu Sep 23, 2021

Choose a reason for hiding this comment

Apache9 left a comment

Choose a reason for hiding this comment