HBASE-22673 Avoid to expose protobuf stuff in Hbck interface #372

infraio · 2019-07-11T02:11:34Z

No description provided.

hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseHbck.java

Apache9

+1.

Apache-HBase · 2019-07-12T20:12:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	88	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	304	master passed
+1	compile	25	master passed
+1	checkstyle	29	master passed
+1	shadedjars	267	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	62	master passed
+1	javadoc	21	master passed
		_ Patch Compile Tests _
+1	mvninstall	254	the patch passed
+1	compile	25	the patch passed
+1	javac	25	the patch passed
-1	checkstyle	29	hbase-client: The patch generated 3 new + 114 unchanged - 0 fixed = 117 total (was 114)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	270	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	801	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	64	the patch passed
+1	javadoc	19	the patch passed
		_ Other Tests _
+1	unit	107	hbase-client in the patch passed.
+1	asflicense	10	The patch does not generate ASF License warnings.
		2686

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/1/artifact/out/Dockerfile
GITHUB PR	#372
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux bf054a594670 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `438bf32`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/1/artifact/out/diff-checkstyle-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/1/testReport/
Max. process+thread count	253 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet · 2019-07-14T16:37:41Z

hbase-client/src/main/java/org/apache/hadoop/hbase/client/Hbck.java

-      throws IOException;
+  /**
+   * Use {@link #scheduleServerCrashProcedures(List)} instead.
+   * @deprecated since 2.2.1. Will removed in 2.3.0.


Can you please create a ticket targeting the 2.3.0 release and the current master for removal?

Open a new issue HBASE-22708 for it.

Apache-HBase · 2019-07-15T13:38:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	54	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	256	master passed
+1	compile	24	master passed
+1	checkstyle	29	master passed
+1	shadedjars	281	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	60	master passed
+1	javadoc	22	master passed
		_ Patch Compile Tests _
+1	mvninstall	253	the patch passed
+1	compile	24	the patch passed
+1	javac	24	the patch passed
-1	checkstyle	29	hbase-client: The patch generated 3 new + 114 unchanged - 0 fixed = 117 total (was 114)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	280	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	769	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	67	the patch passed
+1	javadoc	20	the patch passed
		_ Other Tests _
+1	unit	100	hbase-client in the patch passed.
+1	asflicense	10	The patch does not generate ASF License warnings.
		2596

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/2/artifact/out/Dockerfile
GITHUB PR	#372
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 9ee5269b13e0 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `74731c2`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/2/artifact/out/diff-checkstyle-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/2/testReport/
Max. process+thread count	294 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-16T10:40:26Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	36	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	267	master passed
+1	compile	23	master passed
+1	checkstyle	29	master passed
+1	shadedjars	275	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	59	master passed
+1	javadoc	20	master passed
		_ Patch Compile Tests _
+1	mvninstall	255	the patch passed
+1	compile	23	the patch passed
+1	javac	23	the patch passed
-1	checkstyle	31	hbase-client: The patch generated 3 new + 114 unchanged - 0 fixed = 117 total (was 114)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	272	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	779	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	70	the patch passed
+1	javadoc	22	the patch passed
		_ Other Tests _
+1	unit	113	hbase-client in the patch passed.
+1	asflicense	10	The patch does not generate ASF License warnings.
		2599

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/3/artifact/out/Dockerfile
GITHUB PR	#372
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 996e249e1054 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `cc38de1`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/3/artifact/out/diff-checkstyle-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/3/testReport/
Max. process+thread count	287 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-17T08:40:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	64	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
-1	mvninstall	244	root in master failed.
+1	compile	26	master passed
+1	checkstyle	30	master passed
+1	shadedjars	266	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	58	master passed
+1	javadoc	20	master passed
		_ Patch Compile Tests _
-1	mvninstall	254	root in the patch failed.
+1	compile	23	the patch passed
+1	javac	23	the patch passed
+1	checkstyle	28	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	268	patch has no errors when building our shaded downstream artifacts.
-1	hadoopcheck	247	The patch causes 10 errors with Hadoop v2.8.5.
-1	hadoopcheck	499	The patch causes 10 errors with Hadoop v2.9.2.
-1	hadoopcheck	759	The patch causes 10 errors with Hadoop v3.1.2.
+1	findbugs	66	the patch passed
+1	javadoc	20	the patch passed
		_ Other Tests _
+1	unit	104	hbase-client in the patch passed.
+1	asflicense	9	The patch does not generate ASF License warnings.
		2320

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/4/artifact/out/Dockerfile
GITHUB PR	#372
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux c180c7eeb633 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `72e58a8`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
mvninstall	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/4/artifact/out/branch-mvninstall-root.txt
findbugs	v3.1.11
mvninstall	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/4/artifact/out/patch-mvninstall-root.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/4/artifact/out/patch-javac-2.8.5.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/4/artifact/out/patch-javac-2.9.2.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/4/artifact/out/patch-javac-3.1.2.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/4/testReport/
Max. process+thread count	295 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/4/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache9 requested changes Jul 11, 2019

View reviewed changes

hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseHbck.java Outdated Show resolved Hide resolved

Apache9 approved these changes Jul 11, 2019

View reviewed changes

HorizonNet reviewed Jul 14, 2019

View reviewed changes

infraio force-pushed the hbck branch from cd2b0e1 to b197435 Compare July 17, 2019 07:50

infraio force-pushed the hbck branch from b197435 to 44764d4 Compare July 18, 2019 02:25

HBASE-22673 Avoid to expose protobuf stuff in Hbck interface

42cf98e

infraio force-pushed the hbck branch from 44764d4 to 42cf98e Compare July 18, 2019 04:22

saintstack approved these changes Jul 18, 2019

View reviewed changes

infraio merged commit 48c623c into apache:master Jul 19, 2019

infraio deleted the hbck branch July 19, 2019 00:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-22673 Avoid to expose protobuf stuff in Hbck interface #372

HBASE-22673 Avoid to expose protobuf stuff in Hbck interface #372

infraio commented Jul 11, 2019

Apache9 left a comment

Apache-HBase commented Jul 12, 2019

HorizonNet Jul 14, 2019

infraio Jul 18, 2019

Apache-HBase commented Jul 15, 2019

Apache-HBase commented Jul 16, 2019

Apache-HBase commented Jul 17, 2019

HBASE-22673 Avoid to expose protobuf stuff in Hbck interface #372

HBASE-22673 Avoid to expose protobuf stuff in Hbck interface #372

Conversation

infraio commented Jul 11, 2019

Apache9 left a comment

Choose a reason for hiding this comment

Apache-HBase commented Jul 12, 2019

HorizonNet Jul 14, 2019

Choose a reason for hiding this comment

infraio Jul 18, 2019

Choose a reason for hiding this comment

Apache-HBase commented Jul 15, 2019

Apache-HBase commented Jul 16, 2019

Apache-HBase commented Jul 17, 2019