HBASE-22527 [hbck2] Add a master web ui to show the problematic regions #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apache9
requested changes
Jul 11, 2019
| @@ -23,9 +23,12 @@ | |||
| import java.util.Collections; | |||
| import java.util.HashMap; | |||
| import java.util.HashSet; | |||
| import java.util.LinkedList; | |||
busbey
requested changes
Jul 11, 2019
| @@ -158,6 +161,8 @@ | |||
| private final RegionStates regionStates = new RegionStates(); | |||
| private final RegionStateStore regionStateStore; | |||
|
|
|||
| private final ConcurrentMap<ServerName, Set<byte[]>> rsReports = new ConcurrentHashMap<>(); | |||
There was a problem hiding this comment.
It looks like all of our access is synchronized, why are we using CHM?
There was a problem hiding this comment.
Changed to HashMap in new patch.
busbey
reviewed
Jul 11, 2019
| @@ -2028,4 +2036,41 @@ private void addToPendingAssignment(final HashMap<RegionInfo, RegionStateNode> r | |||
| MasterServices getMaster() { | |||
| return master; | |||
| } | |||
|
|
|||
| public Map<byte[], Pair<ServerName, Set<ServerName>>> getProblematicRegions() { | |||
There was a problem hiding this comment.
how do we get from this method to the master UI?
we need a way to get the same information via a cli, either hbck1 or shell.
There was a problem hiding this comment.
Added the UI in new patch.
There was a problem hiding this comment.
I thought hbck1 already have the ability to find these problematic regions?
busbey
reviewed
Jul 11, 2019
| @@ -2028,4 +2036,41 @@ private void addToPendingAssignment(final HashMap<RegionInfo, RegionStateNode> r | |||
| MasterServices getMaster() { | |||
| return master; | |||
| } | |||
|
|
|||
| public Map<byte[], Pair<ServerName, Set<ServerName>>> getProblematicRegions() { | |||
There was a problem hiding this comment.
this method needs a javadoc description of what we're returning
There was a problem hiding this comment.
Added the javadoc in new patch.
busbey
reviewed
Jul 11, 2019
| @@ -2028,4 +2036,41 @@ private void addToPendingAssignment(final HashMap<RegionInfo, RegionStateNode> r | |||
| MasterServices getMaster() { | |||
| return master; | |||
| } | |||
|
|
|||
| public Map<byte[], Pair<ServerName, Set<ServerName>>> getProblematicRegions() { | |||
| ConcurrentMap<byte[], Set<ServerName>> reportedOnlineRegions = new ConcurrentHashMap<>(); | |||
There was a problem hiding this comment.
why is this a concurrent map?
|
💔 -1 overall
This message was automatically generated. |
infraio
force-pushed
the
hbase-checker
branch
2 times, most recently
from
7d237eb
to
4b5243f
Compare
|
💔 -1 overall
This message was automatically generated. |
infraio
force-pushed
the
hbase-checker
branch
2 times, most recently
from
bc945a1
to
0b6fc5d
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
saintstack
approved these changes
Jul 17, 2019
| int numOfPages = (int) Math.ceil(totalSize * 1.0 / sizePerPage); | ||
| </%java> | ||
| <section> | ||
| <h2><a name="rit">Problematic Regions</a></h2> |
There was a problem hiding this comment.
On commit, add a sentence that says what a problematic region is. It seems like its one that has a meta entry that does not agree w/ where it is actually deployed?
There was a problem hiding this comment.
Or, you say below what it is... * case 1. Master thought this region opened, but no regionserver reported it.
- case 2. Master thought this region opened on Server1, but regionserver reported Server2
- case 3. More than one regionservers reported opened this region
Can this be added in the UI maybe in small text?
There was a problem hiding this comment.
Already committed it. Will add addendum for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.