New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-26410 Fix HBase TestCanaryTool for Java17 #3809
Conversation
🎊 +1 overall
This message was automatically generated. |
This maybe a big problem if Java17 changes the return value format of InetSocketAddress.toString. Does InetSockerAddress provide other method to get the colon concat result? We should change all the InetSocketAddress.toString call in our code base I think. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There is no method of InetSocketAddress return the colon concat result directly for unresolved address. Every usage of our tostring method should be reviewed if there could get unresolved address. Besides, what about not to use tostring() method here but just concatenate the string ourselves (could provide a util function for hostname and port concatenation). |
I like the approach to provide a util function. We could go this way. But maybe we need to make sure that we will not call this toString method again in the future? |
It seems that it is hard to guarantee, every InetSocketAddress is resolved. So that this problem will occur when we use tostring of an unresolved Address. In this case, we should try to avoid calling toString() I think. Not sure if there are other points that we should concern about. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
https://issues.apache.org/jira/browse/HBASE-26410