HBASE-26490 Add builder for class ReplicationLoadSink #3883

YutSean · 2021-11-26T08:02:13Z

https://issues.apache.org/jira/browse/HBASE-26490

Apache-HBase · 2021-11-26T08:34:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 16s	master passed
+1 💚	compile	0m 27s	master passed
+1 💚	shadedjars	8m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 5s	the patch passed
+1 💚	compile	0m 29s	the patch passed
+1 💚	javac	0m 29s	the patch passed
+1 💚	shadedjars	9m 6s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 19s	hbase-client in the patch passed.
		31m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3883
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 87d84b8f4f49 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `33287ac`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/1/testReport/
Max. process+thread count	342 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-26T08:51:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	9m 43s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 32s	master passed
+1 💚	compile	0m 37s	master passed
+1 💚	shadedjars	10m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 30s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 56s	the patch passed
+1 💚	compile	0m 36s	the patch passed
+1 💚	javac	0m 36s	the patch passed
+1 💚	shadedjars	10m 14s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 54s	hbase-client in the patch passed.
		48m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3883
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e5698033c0c6 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `33287ac`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/1/testReport/
Max. process+thread count	213 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-26T08:51:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 20s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 36s	master passed
+1 💚	compile	0m 58s	master passed
+1 💚	checkstyle	0m 33s	master passed
+1 💚	spotbugs	1m 6s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 21s	the patch passed
+1 💚	compile	0m 59s	the patch passed
+1 💚	javac	0m 59s	the patch passed
+1 💚	checkstyle	0m 32s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	23m 15s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	1m 35s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		48m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3883
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux b275fbdc55b6 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `33287ac`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Reidddddd · 2021-11-26T09:34:45Z

hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationLoadSink.java

@@ -22,7 +22,6 @@
  private final long timestampStarted;
  private final long totalOpsProcessed;

-  // TODO: add the builder for this class
  @InterfaceAudience.Private
  public ReplicationLoadSink(long age, long timestamp, long timestampStarted,


The constructor should be private when you use Builder pattern.

Right, will change it to private in the latest commit.

Reidddddd · 2021-11-26T09:35:12Z

hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java

@@ -2836,10 +2836,12 @@ public static void mergeFrom(Message.Builder builder, CodedInputStream codedInpu

  public static ReplicationLoadSink toReplicationLoadSink(
      ClusterStatusProtos.ReplicationLoadSink rls) {
-    return new ReplicationLoadSink(rls.getAgeOfLastAppliedOp(),


Have you replaced all? only here?

I checked the code and changed the constructor function to private. There is no problem with compiling. Here is the only invoke.

what about codes in unit tests.

No explicit invoke in UT. But I ran all the UTs in the same module. They all passed.

Apache-HBase · 2021-11-26T10:52:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 14s	master passed
+1 💚	compile	0m 31s	master passed
+1 💚	shadedjars	8m 34s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 54s	the patch passed
+1 💚	compile	0m 27s	the patch passed
+1 💚	javac	0m 27s	the patch passed
+1 💚	shadedjars	8m 24s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 24s	hbase-client in the patch passed.
		30m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3883
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 951a249281f0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `33287ac`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/2/testReport/
Max. process+thread count	339 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-26T10:55:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 1s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 8s	master passed
+1 💚	compile	0m 32s	master passed
+1 💚	shadedjars	9m 13s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 5s	the patch passed
+1 💚	compile	0m 32s	the patch passed
+1 💚	javac	0m 32s	the patch passed
+1 💚	shadedjars	9m 6s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 45s	hbase-client in the patch passed.
		34m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3883
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ccbb8baa6f73 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `33287ac`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/2/testReport/
Max. process+thread count	218 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-26T11:04:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 11s	master passed
+1 💚	compile	1m 3s	master passed
+1 💚	checkstyle	0m 32s	master passed
+1 💚	spotbugs	1m 3s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 49s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
-0 ⚠️	checkstyle	0m 32s	hbase-client: The patch generated 1 new + 181 unchanged - 0 fixed = 182 total (was 181)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 42s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	1m 11s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		42m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3883
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 041fea8de443 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `33287ac`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Reidddddd

+1 lgtm. Let's wait if there are other reviews.

Apache9 · 2021-11-29T07:18:08Z

hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationLoadSink.java

@@ -22,9 +22,8 @@
  private final long timestampStarted;
  private final long totalOpsProcessed;

-  // TODO: add the builder for this class
  @InterfaceAudience.Private


Since this is private now, we do not need IA.Private annotation then?

hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationLoadSink.java

Apache-HBase · 2021-11-30T13:07:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 46s	master passed
+1 💚	compile	0m 27s	master passed
+1 💚	shadedjars	8m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 55s	the patch passed
+1 💚	compile	0m 27s	the patch passed
+1 💚	javac	0m 27s	the patch passed
+1 💚	shadedjars	8m 37s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 23s	hbase-client in the patch passed.
		29m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3883
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 324d20d91ce5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f108997`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/3/testReport/
Max. process+thread count	345 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-30T13:08:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 39s	master passed
+1 💚	compile	0m 30s	master passed
+1 💚	shadedjars	8m 20s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 32s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 29s	the patch passed
+1 💚	compile	0m 29s	the patch passed
+1 💚	javac	0m 29s	the patch passed
+1 💚	shadedjars	8m 22s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 27s	hbase-client in the patch passed.
		30m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3883
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 577ae248225c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f108997`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/3/testReport/
Max. process+thread count	314 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-30T13:24:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 34s	master passed
+1 💚	compile	1m 7s	master passed
+1 💚	checkstyle	0m 37s	master passed
+1 💚	spotbugs	1m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 7s	the patch passed
+1 💚	compile	1m 3s	the patch passed
+1 💚	javac	1m 3s	the patch passed
-0 ⚠️	checkstyle	0m 33s	hbase-client: The patch generated 1 new + 181 unchanged - 0 fixed = 182 total (was 181)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 38s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	1m 23s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		46m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3883
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 08b6cdf6bd44 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f108997`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3883/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: Reid Chan <reidchan@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>

This reverts commit 02fa090.

Signed-off-by: Reid Chan <reidchan@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>

…#3883)" This reverts commit 02fa090. (cherry picked from commit 823b8fd) Change-Id: If3579b2c6bd72f471b846945ad31d8cf26c1626e

HBASE-26490 Add builder for class ReplicationLoadSink

bffecd0

Reidddddd reviewed Nov 26, 2021

View reviewed changes

Make the constructor function private

800affe

Reidddddd approved these changes Nov 26, 2021

View reviewed changes

Apache9 reviewed Nov 29, 2021

View reviewed changes

Refine the IA annotation

c57739b

Apache9 approved these changes Nov 30, 2021

View reviewed changes

Apache9 merged commit b5b286d into apache:master Dec 4, 2021

Apache9 pushed a commit that referenced this pull request Dec 4, 2021

HBASE-26490 Add builder for class ReplicationLoadSink (#3883)

02fa090

Signed-off-by: Reid Chan <reidchan@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>

Apache9 pushed a commit that referenced this pull request Dec 4, 2021

HBASE-26490 Add builder for class ReplicationLoadSink (#3883)

b471d75

Signed-off-by: Reid Chan <reidchan@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>

asfgit pushed a commit that referenced this pull request Dec 18, 2021

Revert "HBASE-26490 Add builder for class ReplicationLoadSink (#3883)"

823b8fd

This reverts commit 02fa090.

vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024

HBASE-26490 Add builder for class ReplicationLoadSink (apache#3883)

16d0685

Signed-off-by: Reid Chan <reidchan@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-26490 Add builder for class ReplicationLoadSink #3883

HBASE-26490 Add builder for class ReplicationLoadSink #3883

YutSean commented Nov 26, 2021

Apache-HBase commented Nov 26, 2021

Apache-HBase commented Nov 26, 2021

Apache-HBase commented Nov 26, 2021

Reidddddd Nov 26, 2021

YutSean Nov 26, 2021

Reidddddd Nov 26, 2021

YutSean Nov 26, 2021

Reidddddd Nov 26, 2021

YutSean Nov 26, 2021

Apache-HBase commented Nov 26, 2021

Apache-HBase commented Nov 26, 2021

Apache-HBase commented Nov 26, 2021

Reidddddd left a comment

Apache9 Nov 29, 2021

Apache-HBase commented Nov 30, 2021

Apache-HBase commented Nov 30, 2021

Apache-HBase commented Nov 30, 2021

HBASE-26490 Add builder for class ReplicationLoadSink #3883

HBASE-26490 Add builder for class ReplicationLoadSink #3883

Conversation

YutSean commented Nov 26, 2021

Apache-HBase commented Nov 26, 2021

Apache-HBase commented Nov 26, 2021

Apache-HBase commented Nov 26, 2021

Reidddddd Nov 26, 2021

Choose a reason for hiding this comment

YutSean Nov 26, 2021

Choose a reason for hiding this comment

Reidddddd Nov 26, 2021

Choose a reason for hiding this comment

YutSean Nov 26, 2021

Choose a reason for hiding this comment

Reidddddd Nov 26, 2021

Choose a reason for hiding this comment

YutSean Nov 26, 2021

Choose a reason for hiding this comment

Apache-HBase commented Nov 26, 2021

Apache-HBase commented Nov 26, 2021

Apache-HBase commented Nov 26, 2021

Reidddddd left a comment

Choose a reason for hiding this comment

Apache9 Nov 29, 2021

Choose a reason for hiding this comment

Apache-HBase commented Nov 30, 2021

Apache-HBase commented Nov 30, 2021

Apache-HBase commented Nov 30, 2021