HBASE-26643 AssignmentManager should check for empty result returned … #4005

Apache9 · 2022-01-05T15:43:00Z

…by LoadBalancer

Apache-HBase · 2022-01-05T16:33:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 11s	master passed
+1 💚	compile	3m 14s	master passed
+1 💚	checkstyle	1m 6s	master passed
+1 💚	spotbugs	2m 10s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 55s	the patch passed
+1 💚	compile	3m 14s	the patch passed
+1 💚	javac	3m 14s	the patch passed
+1 💚	checkstyle	1m 1s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 35s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	2m 14s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		49m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4005/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4005
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux cf03b209c271 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `baeb51f`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4005/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-01-05T18:47:48Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 42s	master passed
+1 💚	compile	1m 29s	master passed
+1 💚	shadedjars	9m 41s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 50s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 6s	the patch passed
+1 💚	compile	1m 28s	the patch passed
+1 💚	javac	1m 28s	the patch passed
+1 💚	shadedjars	9m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	the patch passed
		_ Other Tests _
-1 ❌	unit	146m 2s	hbase-server in the patch failed.
		183m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4005/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4005
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux da406b5b565b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `baeb51f`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4005/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4005/1/testReport/
Max. process+thread count	3623 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4005/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-01-05T18:59:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 58s	master passed
+1 💚	compile	1m 15s	master passed
+1 💚	shadedjars	10m 16s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 38s	the patch passed
+1 💚	compile	1m 16s	the patch passed
+1 💚	javac	1m 16s	the patch passed
+1 💚	shadedjars	10m 5s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	the patch passed
		_ Other Tests _
-1 ❌	unit	159m 27s	hbase-server in the patch failed.
		195m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4005/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4005
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 95591c47a84d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `baeb51f`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4005/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4005/1/testReport/
Max. process+thread count	3741 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4005/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

nyl3532016

+1

Apache9 · 2022-01-06T16:08:28Z

Ah, there is a problem. For RSGroupLoadBalancer, we have to use BOGUS_SERVER_NAME to indicate the upper layer that some regions can not be assigned, otherwise the upper layer needs iterator over all the regions to check wheter there are missing ones. Otherwise we need to redesign the return value to make it possible to tell upper layer that some regions are not assigned, through other ways...

So I suppose we should not return empty map to upper layer then, we should use BOGUS_SERVER_NAME to record the regions which can not be assigned.

Let me provide a new patch.

Apache-HBase · 2022-01-06T17:13:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 13s	master passed
+1 💚	compile	3m 51s	master passed
+1 💚	checkstyle	1m 17s	master passed
+1 💚	spotbugs	2m 51s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 49s	the patch passed
+1 💚	compile	3m 56s	the patch passed
+1 💚	javac	3m 56s	the patch passed
+1 💚	checkstyle	1m 15s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	22m 20s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	4m 15s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 29s	The patch does not generate ASF License warnings.
		59m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4005/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4005
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 5ec121cf0e09 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7972b2e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4005/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-01-06T19:39:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 24s	master passed
+1 💚	compile	1m 27s	master passed
+1 💚	shadedjars	8m 28s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 56s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 53s	the patch passed
+1 💚	compile	1m 27s	the patch passed
+1 💚	javac	1m 27s	the patch passed
+1 💚	shadedjars	8m 23s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 54s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 54s	hbase-balancer in the patch passed.
-1 ❌	unit	165m 0s	hbase-server in the patch failed.
		206m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4005/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4005
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 356aaaa6dc7a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7972b2e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4005/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4005/2/testReport/
Max. process+thread count	3486 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4005/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-01-06T20:45:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 57s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 41s	master passed
+1 💚	compile	1m 52s	master passed
+1 💚	shadedjars	10m 20s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 4s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 31s	the patch passed
+1 💚	compile	2m 13s	the patch passed
+1 💚	javac	2m 13s	the patch passed
+1 💚	shadedjars	10m 10s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 8s	the patch passed
		_ Other Tests _
+1 💚	unit	11m 15s	hbase-balancer in the patch passed.
+1 💚	unit	213m 41s	hbase-server in the patch passed.
		272m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4005/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4005
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 48694c11c842 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7972b2e`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4005/2/testReport/
Max. process+thread count	2597 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4005/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

nyl3532016 · 2022-01-07T12:31:44Z

It seems createTableProcedure only use roundRobinAssignment, and modify retainAssignment' return is also OK

nyl3532016 · 2022-01-07T12:34:24Z

Should we also modify randomAssignment to return BOGUS_SERVER_NAME instead of null for unified？

Apache9 · 2022-01-07T13:10:54Z

Should we also modify randomAssignment to return BOGUS_SERVER_NAME instead of null for unified？

I think this is fine... As null is enough to tell the upper layer we can not assign a region. BOGUS_SERVER_NAME is used in Map since put null key to map is not a good practise usually...

nyl3532016

+1

Signed-off-by: Yulin Niu <niuyulin@apache.org>

Signed-off-by: Yulin Niu <niuyulin@apache.org> (cherry picked from commit 3f68399) Change-Id: Ib3723293c001e10e2461d86f5a9c761af9c8ad9e

Apache9 self-assigned this Jan 5, 2022

nyl3532016 approved these changes Jan 6, 2022

View reviewed changes

HBASE-26643 LoadBalancer should not return empty map

2038e67

Apache9 force-pushed the HBASE-26643 branch from ec6b53a to 2038e67 Compare January 6, 2022 16:12

nyl3532016 approved these changes Jan 7, 2022

View reviewed changes

Apache9 merged commit 443bf30 into apache:master Jan 7, 2022

Apache9 added a commit that referenced this pull request Jan 7, 2022

HBASE-26643 LoadBalancer should not return empty map (#4005)

3f68399

Signed-off-by: Yulin Niu <niuyulin@apache.org>

Apache9 added a commit that referenced this pull request Jan 7, 2022

HBASE-26643 LoadBalancer should not return empty map (#4005)

2abd09f

Signed-off-by: Yulin Niu <niuyulin@apache.org>

Apache9 added a commit that referenced this pull request Jan 7, 2022

HBASE-26643 LoadBalancer should not return empty map (#4005)

2f0b5ae

Signed-off-by: Yulin Niu <niuyulin@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-26643 AssignmentManager should check for empty result returned … #4005

HBASE-26643 AssignmentManager should check for empty result returned … #4005

Apache9 commented Jan 5, 2022

Apache-HBase commented Jan 5, 2022

Apache-HBase commented Jan 5, 2022

Apache-HBase commented Jan 5, 2022

nyl3532016 left a comment

Apache9 commented Jan 6, 2022

Apache-HBase commented Jan 6, 2022

Apache-HBase commented Jan 6, 2022

Apache-HBase commented Jan 6, 2022

nyl3532016 commented Jan 7, 2022

nyl3532016 commented Jan 7, 2022

Apache9 commented Jan 7, 2022

nyl3532016 left a comment

HBASE-26643 AssignmentManager should check for empty result returned … #4005

HBASE-26643 AssignmentManager should check for empty result returned … #4005

Conversation

Apache9 commented Jan 5, 2022

Apache-HBase commented Jan 5, 2022

Apache-HBase commented Jan 5, 2022

Apache-HBase commented Jan 5, 2022

nyl3532016 left a comment

Choose a reason for hiding this comment

Apache9 commented Jan 6, 2022

Apache-HBase commented Jan 6, 2022

Apache-HBase commented Jan 6, 2022

Apache-HBase commented Jan 6, 2022

nyl3532016 commented Jan 7, 2022

nyl3532016 commented Jan 7, 2022

Apache9 commented Jan 7, 2022

nyl3532016 left a comment

Choose a reason for hiding this comment