HBASE-22721 Refactor HBaseFsck: move the inner class out

[infraio]

No description provided.

[saintstack]

Looks fine. You moving it out for UI reporting @infraio ?

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	37	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	271	master passed
+1	compile	60	master passed
+1	checkstyle	85	master passed
+1	shadedjars	276	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	34	master passed
0	spotbugs	227	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	225	master passed
		_ Patch Compile Tests _
+1	mvninstall	249	the patch passed
+1	compile	53	the patch passed
+1	javac	53	the patch passed
-1	checkstyle	80	hbase-server: The patch generated 34 new + 174 unchanged - 23 fixed = 208 total (was 197)
+1	whitespace	1	The patch has no whitespace issues.
+1	shadedjars	256	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	730	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	32	the patch passed
-1	findbugs	245	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1	unit	7857	hbase-server in the patch passed.
+1	asflicense	20	The patch does not generate ASF License warnings.
		10827

Reason	Tests
FindBugs	module:hbase-server
	Should org.apache.hadoop.hbase.util.HbckRegionInfo$OnlineEntry be a static inner class? At HbckRegionInfo.java:inner class? At HbckRegionInfo.java:[lines 346-361]

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/1/artifact/out/Dockerfile
GITHUB PR	#401
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 83f69176d395 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-401/out/precommit/personality/provided.sh
git revision	master / 9615c64
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/1/artifact/out/diff-checkstyle-hbase-server.txt
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/1/artifact/out/new-findbugs-hbase-server.html
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/1/testReport/
Max. process+thread count	4775 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	63	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	244	master passed
+1	compile	54	master passed
+1	checkstyle	75	master passed
+1	shadedjars	261	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	32	master passed
0	spotbugs	242	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	241	master passed
		_ Patch Compile Tests _
+1	mvninstall	247	the patch passed
+1	compile	55	the patch passed
+1	javac	55	the patch passed
-1	checkstyle	74	hbase-server: The patch generated 34 new + 174 unchanged - 23 fixed = 208 total (was 197)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	279	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	735	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	31	the patch passed
-1	findbugs	247	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1	unit	1571	hbase-server in the patch failed.
+1	asflicense	11	The patch does not generate ASF License warnings.
		4523

Reason	Tests
FindBugs	module:hbase-server
	Should org.apache.hadoop.hbase.util.HbckRegionInfo$OnlineEntry be a static inner class? At HbckRegionInfo.java:inner class? At HbckRegionInfo.java:[lines 346-361]
Failed junit tests	hadoop.hbase.filter.TestFilter
	hadoop.hbase.client.TestAsyncAccessControlAdminApi
	hadoop.hbase.filter.TestColumnPrefixFilter
	hadoop.hbase.filter.TestFilterFromRegionSide

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/3/artifact/out/Dockerfile
GITHUB PR	#401
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux e8d5e8453b19 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-401/out/precommit/personality/provided.sh
git revision	master / 06f5c43
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/3/artifact/out/diff-checkstyle-hbase-server.txt
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/3/artifact/out/new-findbugs-hbase-server.html
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/3/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/3/testReport/
Max. process+thread count	699 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	39	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	244	master passed
+1	compile	53	master passed
+1	checkstyle	77	master passed
+1	shadedjars	275	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	33	master passed
0	spotbugs	241	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	239	master passed
		_ Patch Compile Tests _
+1	mvninstall	253	the patch passed
+1	compile	54	the patch passed
+1	javac	54	the patch passed
-1	checkstyle	75	hbase-server: The patch generated 34 new + 174 unchanged - 23 fixed = 208 total (was 197)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	271	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	741	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	33	the patch passed
-1	findbugs	242	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1	unit	7594	hbase-server in the patch passed.
+1	asflicense	29	The patch does not generate ASF License warnings.
		10583

Reason	Tests
FindBugs	module:hbase-server
	Should org.apache.hadoop.hbase.util.HbckRegionInfo$OnlineEntry be a static inner class? At HbckRegionInfo.java:inner class? At HbckRegionInfo.java:[lines 346-361]

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/2/artifact/out/Dockerfile
GITHUB PR	#401
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 9e46ed7ed251 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-401/out/precommit/personality/provided.sh
git revision	master / fe450b5
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/2/artifact/out/diff-checkstyle-hbase-server.txt
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/2/artifact/out/new-findbugs-hbase-server.html
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/2/testReport/
Max. process+thread count	4267 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	57	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	231	master passed
+1	compile	48	master passed
+1	checkstyle	72	master passed
+1	shadedjars	256	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	33	master passed
0	spotbugs	232	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	231	master passed
		_ Patch Compile Tests _
+1	mvninstall	237	the patch passed
+1	compile	51	the patch passed
+1	javac	51	the patch passed
-1	checkstyle	71	hbase-server: The patch generated 34 new + 174 unchanged - 23 fixed = 208 total (was 197)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	259	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	729	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	31	the patch passed
-1	findbugs	240	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1	unit	16568	hbase-server in the patch failed.
+1	asflicense	42	The patch does not generate ASF License warnings.
		19470

Reason	Tests
FindBugs	module:hbase-server
	Should org.apache.hadoop.hbase.util.HbckRegionInfo$OnlineEntry be a static inner class? At HbckRegionInfo.java:inner class? At HbckRegionInfo.java:[lines 346-361]
Failed junit tests	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.replication.TestReplicationEndpoint
	hadoop.hbase.regionserver.TestSplitTransactionOnCluster

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/4/artifact/out/Dockerfile
GITHUB PR	#401
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 386de8bdfcfc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-401@2/out/precommit/personality/provided.sh
git revision	master / 06f5c43
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/4/artifact/out/diff-checkstyle-hbase-server.txt
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/4/artifact/out/new-findbugs-hbase-server.html
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/4/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/4/testReport/
Max. process+thread count	4706 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/4/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	118	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	356	master passed
+1	compile	80	master passed
+1	checkstyle	133	master passed
+1	shadedjars	366	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	45	master passed
0	spotbugs	291	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	287	master passed
		_ Patch Compile Tests _
+1	mvninstall	359	the patch passed
+1	compile	76	the patch passed
+1	javac	76	the patch passed
-1	checkstyle	107	hbase-server: The patch generated 2 new + 172 unchanged - 25 fixed = 174 total (was 197)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	376	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1054	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	51	the patch passed
+1	findbugs	321	the patch passed
		_ Other Tests _
-1	unit	13665	hbase-server in the patch failed.
+1	asflicense	26	The patch does not generate ASF License warnings.
		17877

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/6/artifact/out/Dockerfile
GITHUB PR	#401
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 42a4575e49ac 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-401/out/precommit/personality/provided.sh
git revision	master / 06f5c43
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/6/artifact/out/diff-checkstyle-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/6/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/6/testReport/
Max. process+thread count	4587 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/6/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.