-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-22812 InterfaceAudience annotation in CatalogJanitor uses fully… #462
Conversation
Will merge after the qa. |
💔 -1 overall
This message was automatically generated. |
The QA looks fine to me. The test failures are unrelated. |
Actually, @SyedMurtazaHassan the import order is wrong. Could you please rectify it? It's weird that the QA bot didn't point it out as a -1, even though it's pretty obvious here: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/1/artifact/out/diff-checkstyle-hbase-server.txt . Will file a separate jira for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change was made IIRC to try and defeat complaint by checkstyle about import order.
The import order in checkstyle has been giving me grief of late. Would be good to change it to a -0 instead of a -1 vote. Sounds like it might be a bit hard to do though.....
Yes Stack, I definitely think it should be < +1 or else it can be overlooked easily. (-0 being preferred). |
@jatsakthi |
@SyedMurtazaHassan Yes, please. |
@jatsakthi Changed the import order and now the checkstyle issue is gone. |
Thanks for the quick fix @SyedMurtazaHassan . Let's wait for the QA. |
…-qualified name (#462) Signed-off-by: Stack <stack@apache.org> Signed-off-by: Sakthi <sakthi@apache.org>
…-qualified name (#462) Signed-off-by: Stack <stack@apache.org> Signed-off-by: Sakthi <sakthi@apache.org>
…-qualified name (#462) Signed-off-by: Stack <stack@apache.org> Signed-off-by: Sakthi <sakthi@apache.org>
…-qualified name (#462) Signed-off-by: Stack <stack@apache.org> Signed-off-by: Sakthi <sakthi@apache.org>
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
…-qualified name (apache#462) Signed-off-by: Stack <stack@apache.org> Signed-off-by: Sakthi <sakthi@apache.org>
…-qualified name (apache#462) Signed-off-by: Stack <stack@apache.org> Signed-off-by: Sakthi <sakthi@apache.org> (cherry picked from commit 08b1f15) Change-Id: Ic455fb767bb04ff48b5d7aa618325bee8a1d5e1b
…-qualified name