Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-22812 InterfaceAudience annotation in CatalogJanitor uses fully… #462

Merged
merged 2 commits into from
Aug 7, 2019
Merged

HBASE-22812 InterfaceAudience annotation in CatalogJanitor uses fully… #462

merged 2 commits into from
Aug 7, 2019

Conversation

murtazahassan123
Copy link
Contributor

…-qualified name

jatsakthi
jatsakthi previously approved these changes Aug 7, 2019
View reviewed changes
@jatsakthi
Copy link
Member

Will merge after the qa.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 78 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 447 master passed
+1 compile 69 master passed
+1 checkstyle 110 master passed
+1 shadedjars 385 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 48 master passed
0 spotbugs 314 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 312 master passed
_ Patch Compile Tests _
+1 mvninstall 410 the patch passed
+1 compile 70 the patch passed
+1 javac 70 the patch passed
-1 checkstyle 97 hbase-server: The patch generated 1 new + 6 unchanged - 1 fixed = 7 total (was 7)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 365 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1199 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 41 the patch passed
+1 findbugs 306 the patch passed
_ Other Tests _
-1 unit 18777 hbase-server in the patch failed.
+1 asflicense 39 The patch does not generate ASF License warnings.
23231
Reason Tests
Failed junit tests hadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.master.TestAssignmentManagerMetrics
hadoop.hbase.io.hfile.bucket.TestBucketCache
hadoop.hbase.replication.TestReplicationDisableInactivePeer
hadoop.hbase.replication.TestReplicationSmallTests
hadoop.hbase.regionserver.TestSplitTransactionOnCluster
hadoop.hbase.client.TestFromClientSide
hadoop.hbase.replication.TestReplicationSmallTestsSync
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/1/artifact/out/Dockerfile
GITHUB PR #462
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 04844dff8fa1 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-462/out/precommit/personality/provided.sh
git revision master / 07c6bb1
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/1/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/1/testReport/
Max. process+thread count 4939 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@jatsakthi
Copy link
Member

The QA looks fine to me. The test failures are unrelated.

@jatsakthi jatsakthi self-requested a review August 7, 2019 16:39
@jatsakthi
Copy link
Member

Actually, @SyedMurtazaHassan the import order is wrong. Could you please rectify it? It's weird that the QA bot didn't point it out as a -1, even though it's pretty obvious here: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/1/artifact/out/diff-checkstyle-hbase-server.txt . Will file a separate jira for that.

@jatsakthi jatsakthi dismissed their stale review August 7, 2019 16:46

Wrong import order

@jatsakthi jatsakthi removed their request for review August 7, 2019 16:46
saintstack
saintstack reviewed Aug 7, 2019
View reviewed changes
Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change was made IIRC to try and defeat complaint by checkstyle about import order.

The import order in checkstyle has been giving me grief of late. Would be good to change it to a -0 instead of a -1 vote. Sounds like it might be a bit hard to do though.....

@jatsakthi
Copy link
Member

Yes Stack, I definitely think it should be < +1 or else it can be overlooked easily. (-0 being preferred).

@murtazahassan123
Copy link
Contributor Author

@jatsakthi
should i change the import order?

@jatsakthi
Copy link
Member

@SyedMurtazaHassan Yes, please.

@murtazahassan123
Copy link
Contributor Author

@jatsakthi
Thanks for your comments.

Changed the import order and now the checkstyle issue is gone.

@jatsakthi
Copy link
Member

Thanks for the quick fix @SyedMurtazaHassan . Let's wait for the QA.

@jatsakthi jatsakthi merged commit 49839e4 into apache:master Aug 7, 2019
jatsakthi pushed a commit that referenced this pull request Aug 7, 2019
@murtazahassan123 @jatsakthi
HBASE-22812 InterfaceAudience annotation in CatalogJanitor uses fully…
d39736a 
…-qualified name (#462)

Signed-off-by: Stack <stack@apache.org>
Signed-off-by: Sakthi <sakthi@apache.org>
jatsakthi pushed a commit that referenced this pull request Aug 7, 2019
@murtazahassan123 @jatsakthi
HBASE-22812 InterfaceAudience annotation in CatalogJanitor uses fully…
d4d58f3 
…-qualified name (#462)

Signed-off-by: Stack <stack@apache.org>
Signed-off-by: Sakthi <sakthi@apache.org>
jatsakthi pushed a commit that referenced this pull request Aug 7, 2019
@murtazahassan123 @jatsakthi
HBASE-22812 InterfaceAudience annotation in CatalogJanitor uses fully…
08b1f15 
…-qualified name (#462)

Signed-off-by: Stack <stack@apache.org>
Signed-off-by: Sakthi <sakthi@apache.org>
jatsakthi pushed a commit that referenced this pull request Aug 7, 2019
@murtazahassan123 @jatsakthi
HBASE-22812 InterfaceAudience annotation in CatalogJanitor uses fully…
23b44b6 
…-qualified name (#462)

Signed-off-by: Stack <stack@apache.org>
Signed-off-by: Sakthi <sakthi@apache.org>
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 110 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 360 master passed
+1 compile 62 master passed
+1 checkstyle 91 master passed
+1 shadedjars 301 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 39 master passed
0 spotbugs 293 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 292 master passed
_ Patch Compile Tests _
+1 mvninstall 350 the patch passed
+1 compile 63 the patch passed
+1 javac 63 the patch passed
-1 checkstyle 86 hbase-server: The patch generated 1 new + 6 unchanged - 1 fixed = 7 total (was 7)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 300 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1041 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 36 the patch passed
+1 findbugs 285 the patch passed
_ Other Tests _
-1 unit 16235 hbase-server in the patch failed.
+1 asflicense 34 The patch does not generate ASF License warnings.
20119
Reason Tests
Failed junit tests hadoop.hbase.master.TestAssignmentManagerMetrics
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/2/artifact/out/Dockerfile
GITHUB PR #462
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 9d32fb7609b7 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-462/out/precommit/personality/provided.sh
git revision master / a9773ec
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/2/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/2/testReport/
Max. process+thread count 4626 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 46 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 418 master passed
+1 compile 76 master passed
+1 checkstyle 106 master passed
+1 shadedjars 340 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 47 master passed
0 spotbugs 336 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 333 master passed
_ Patch Compile Tests _
+1 mvninstall 384 the patch passed
+1 compile 79 the patch passed
+1 javac 79 the patch passed
+1 checkstyle 122 hbase-server: The patch generated 0 new + 6 unchanged - 1 fixed = 6 total (was 7)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 306 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1009 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 34 the patch passed
+1 findbugs 254 the patch passed
_ Other Tests _
+1 unit 9282 hbase-server in the patch passed.
+1 asflicense 25 The patch does not generate ASF License warnings.
13288
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/3/artifact/out/Dockerfile
GITHUB PR #462
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux ced9debd5fde 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-462/out/precommit/personality/provided.sh
git revision master / a9773ec
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/3/testReport/
Max. process+thread count 4479 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/3/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@murtazahassan123
HBASE-22812 InterfaceAudience annotation in CatalogJanitor uses fully…
4a6d0d7 
…-qualified name (apache#462)

Signed-off-by: Stack <stack@apache.org>
Signed-off-by: Sakthi <sakthi@apache.org>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
@murtazahassan123
HBASE-22812 InterfaceAudience annotation in CatalogJanitor uses fully…
b0d181f 
…-qualified name (apache#462)

Signed-off-by: Stack <stack@apache.org>
Signed-off-by: Sakthi <sakthi@apache.org>
(cherry picked from commit 08b1f15)

Change-Id: Ic455fb767bb04ff48b5d7aa618325bee8a1d5e1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saintstack saintstack saintstack approved these changes

@jatsakthi jatsakthi jatsakthi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@murtazahassan123 @jatsakthi @Apache-HBase @saintstack