HBASE-27339 Improve sasl connection failure log message to include server #4823

apurtell · 2022-10-11T01:48:41Z

Include the remote server name in the logged exception message when the connection setup fails in BlockingRpcConnection.

Add an equivalent log line in NettyRpcConnection.

…rver Include the remote server name in the logged exception message when the connection setup fails in BlockingRpcConnection. Add an equivalent log line in NettyRpcConnection.

Apache9 · 2022-10-11T01:53:00Z

hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java

-          failInit(ch, toIOE(error));
+          IOException ex = toIOE(error);
+          LOG.warn("Exception encountered while connecting to the server " + remoteId.getAddress(), ex);
+          failInit(ch, toIOE(ex));


Should be failInit(ch, ex)?

Yes, once this is addressed, +1 for the PR

Addressed the nit, merging.

Apache-HBase · 2022-10-11T02:12:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 23s	master passed
+1 💚	compile	0m 15s	master passed
+1 💚	shadedjars	4m 6s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 6s	the patch passed
+1 💚	compile	0m 16s	the patch passed
+1 💚	javac	0m 16s	the patch passed
+1 💚	shadedjars	4m 0s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 8s	hbase-client in the patch passed.
		16m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4823
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fcc895ecc733 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `79f853e`
Default Java	Temurin-1.8.0_345-b01
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/1/testReport/
Max. process+thread count	164 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-10-11T02:18:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 51s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 27s	master passed
+1 💚	compile	0m 40s	master passed
+1 💚	checkstyle	0m 17s	master passed
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 40s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 11s	the patch passed
+1 💚	compile	0m 36s	the patch passed
+1 💚	javac	0m 36s	the patch passed
-0 ⚠️	checkstyle	0m 14s	hbase-client: The patch generated 3 new + 2 unchanged - 0 fixed = 5 total (was 2)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	7m 55s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
-1 ❌	spotless	0m 17s	patch has 44 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	0m 46s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		23m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4823
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux b40a7dabe1af 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `79f853e`
Default Java	Temurin-1.8.0_345-b01
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-10-11T02:22:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 32s	master passed
+1 💚	compile	0m 37s	master passed
+1 💚	shadedjars	6m 1s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 35s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 57s	the patch passed
+1 💚	compile	0m 30s	the patch passed
+1 💚	javac	0m 30s	the patch passed
+1 💚	shadedjars	5m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 30s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 25s	hbase-client in the patch passed.
		26m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4823
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7b85759af385 5.4.0-109-generic #123-Ubuntu SMP Fri Apr 8 09:10:54 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `79f853e`
Default Java	Eclipse Adoptium-11.0.16.1+1
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/1/testReport/
Max. process+thread count	192 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

apurtell · 2022-10-11T17:02:31Z

Oh, let me push a spotless fix too.

virajjasani

+1, spotless can be fixed in either next commit or while merging the PR

Apache-HBase · 2022-10-11T17:31:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 23s	master passed
+1 💚	compile	0m 16s	master passed
+1 💚	shadedjars	4m 4s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 3s	the patch passed
+1 💚	compile	0m 14s	the patch passed
+1 💚	javac	0m 14s	the patch passed
+1 💚	shadedjars	3m 56s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 58s	hbase-client in the patch passed.
		16m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4823
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c948e54c5ddf 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f47a52b`
Default Java	Temurin-1.8.0_345-b01
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/2/testReport/
Max. process+thread count	167 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-10-11T17:33:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 47s	master passed
+1 💚	compile	0m 17s	master passed
+1 💚	shadedjars	4m 0s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 17s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 27s	the patch passed
+1 💚	compile	0m 17s	the patch passed
+1 💚	javac	0m 17s	the patch passed
+1 💚	shadedjars	3m 59s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 22s	hbase-client in the patch passed.
		17m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4823
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b2cbdac765cb 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f47a52b`
Default Java	Eclipse Adoptium-11.0.16.1+1
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/2/testReport/
Max. process+thread count	198 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-10-11T17:39:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 33s	master passed
+1 💚	compile	0m 40s	master passed
+1 💚	checkstyle	0m 16s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 43s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 10s	the patch passed
+1 💚	compile	0m 38s	the patch passed
+1 💚	javac	0m 38s	the patch passed
+1 💚	checkstyle	0m 14s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	7m 58s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 46s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		23m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4823
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 75b65e5cee36 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f47a52b`
Default Java	Temurin-1.8.0_345-b01
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…rver (#4823) Include the remote server name in the logged exception message when the connection setup fails in BlockingRpcConnection. Add an equivalent log line in NettyRpcConnection. Signed-off-by: Viraj Jasani <vjasani@apache.org> Conflicts: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java

…rver (#4823) Include the remote server name in the logged exception message when the connection setup fails in BlockingRpcConnection. Add an equivalent log line in NettyRpcConnection. Signed-off-by: Viraj Jasani <vjasani@apache.org>

…rver (#4823) Include the remote server name in the logged exception message when the connection setup fails in BlockingRpcConnection. Add an equivalent log line in NettyRpcConnection. Signed-off-by: Viraj Jasani <vjasani@apache.org> Conflicts: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java

…rver (apache#4823) Include the remote server name in the logged exception message when the connection setup fails in BlockingRpcConnection. Add an equivalent log line in NettyRpcConnection. Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit dfaa638) Change-Id: Ie4389ef9a07cdfaa47cdaf42cd30764b031ddfac

HBASE-27339 Improve sasl connection failure log message to include se…

2a9fbaa

…rver Include the remote server name in the logged exception message when the connection setup fails in BlockingRpcConnection. Add an equivalent log line in NettyRpcConnection.

apurtell requested review from Apache9 and virajjasani October 11, 2022 01:48

Apache9 reviewed Oct 11, 2022

View reviewed changes

Fix pasto

93a23de

virajjasani approved these changes Oct 11, 2022

View reviewed changes

Spotless fixes

e14b2b5

apurtell merged commit 2cc6478 into apache:master Oct 11, 2022

apurtell deleted the HBASE-27339 branch October 11, 2022 17:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27339 Improve sasl connection failure log message to include server #4823

HBASE-27339 Improve sasl connection failure log message to include server #4823

apurtell commented Oct 11, 2022

Apache9 Oct 11, 2022

virajjasani Oct 11, 2022

apurtell Oct 11, 2022

Apache-HBase commented Oct 11, 2022

Apache-HBase commented Oct 11, 2022

Apache-HBase commented Oct 11, 2022

apurtell commented Oct 11, 2022

virajjasani left a comment

Apache-HBase commented Oct 11, 2022

Apache-HBase commented Oct 11, 2022

Apache-HBase commented Oct 11, 2022

HBASE-27339 Improve sasl connection failure log message to include server #4823

HBASE-27339 Improve sasl connection failure log message to include server #4823

Conversation

apurtell commented Oct 11, 2022

Apache9 Oct 11, 2022

Choose a reason for hiding this comment

virajjasani Oct 11, 2022

Choose a reason for hiding this comment

apurtell Oct 11, 2022

Choose a reason for hiding this comment

Apache-HBase commented Oct 11, 2022

Apache-HBase commented Oct 11, 2022

Apache-HBase commented Oct 11, 2022

apurtell commented Oct 11, 2022

virajjasani left a comment

Choose a reason for hiding this comment

Apache-HBase commented Oct 11, 2022

Apache-HBase commented Oct 11, 2022

Apache-HBase commented Oct 11, 2022