HBASE-28082 oldWALs naming can be incompatible with HBase backup #5445

janvanbesien-ngdata · 2023-10-02T11:14:15Z

Make the hostname parsing in BackupUtils#parseHostFromOldLog more lenient by not making any assumptions about the name of the file other than that it starts with a org.apache.hadoop.hbase.ServerName.

Apache-HBase · 2023-10-02T11:47:07Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 15s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 51s	branch-2 passed
+1 💚	compile	0m 26s	branch-2 passed
+1 💚	checkstyle	0m 11s	branch-2 passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 31s	branch-2 passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	2m 33s	root in the patch failed.
-1 ❌	compile	0m 10s	hbase-backup in the patch failed.
-0 ⚠️	javac	0m 10s	hbase-backup in the patch failed.
-0 ⚠️	checkstyle	0m 9s	hbase-backup: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
-0 ⚠️	whitespace	0m 0s	The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 ❌	hadoopcheck	1m 55s	The patch causes 10 errors with Hadoop v2.10.2.
-1 ❌	hadoopcheck	4m 6s	The patch causes 10 errors with Hadoop v3.2.4.
-1 ❌	hadoopcheck	6m 27s	The patch causes 10 errors with Hadoop v3.3.6.
-1 ❌	spotless	0m 37s	patch has 55 errors when running spotless:check, run spotless:apply to fix.
-1 ❌	spotbugs	0m 10s	hbase-backup in the patch failed.
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		16m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5445
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 8037dcbaace7 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `9f6ec47`
Default Java	Eclipse Adoptium-11.0.17+8
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-general-check/output/patch-compile-hbase-backup.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-general-check/output/patch-compile-hbase-backup.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-backup.txt
whitespace	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-general-check/output/whitespace-eol.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-general-check/output/patch-javac-2.10.2.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-general-check/output/patch-javac-3.2.4.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-general-check/output/patch-spotless.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-backup.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-02T11:47:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 44s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 28s	branch-2 passed
+1 💚	compile	0m 13s	branch-2 passed
+1 💚	shadedjars	4m 56s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	branch-2 passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	2m 8s	root in the patch failed.
-1 ❌	compile	0m 8s	hbase-backup in the patch failed.
-0 ⚠️	javac	0m 8s	hbase-backup in the patch failed.
+1 💚	shadedjars	4m 53s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
-1 ❌	unit	0m 8s	hbase-backup in the patch failed.
		17m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5445
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1d643abc0a4a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `9f6ec47`
Default Java	Temurin-1.8.0_352-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-backup.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-backup.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-backup.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/testReport/
Max. process+thread count	67 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-02T11:50:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 49s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 30s	branch-2 passed
+1 💚	compile	0m 23s	branch-2 passed
+1 💚	shadedjars	5m 38s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	branch-2 passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	2m 31s	root in the patch failed.
-1 ❌	compile	0m 8s	hbase-backup in the patch failed.
-0 ⚠️	javac	0m 8s	hbase-backup in the patch failed.
+1 💚	shadedjars	5m 11s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
-1 ❌	unit	0m 9s	hbase-backup in the patch failed.
		19m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5445
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c471c9673ef9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `9f6ec47`
Default Java	Eclipse Adoptium-11.0.17+8
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-backup.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-backup.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-backup.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/testReport/
Max. process+thread count	81 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-02T12:34:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 9s	branch-2 passed
+1 💚	compile	0m 15s	branch-2 passed
+1 💚	shadedjars	4m 57s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 6s	the patch passed
+1 💚	compile	0m 13s	the patch passed
+1 💚	javac	0m 13s	the patch passed
+1 💚	shadedjars	4m 53s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 6s	hbase-backup in the patch passed.
		18m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5445
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e3213d477e6e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `9f6ec47`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/2/testReport/
Max. process+thread count	596 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-02T12:38:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 53s	branch-2 passed
+1 💚	compile	0m 17s	branch-2 passed
+1 💚	shadedjars	6m 0s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 15s	the patch passed
+1 💚	compile	0m 20s	the patch passed
+1 💚	javac	0m 20s	the patch passed
+1 💚	shadedjars	6m 0s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 12s	hbase-backup in the patch passed.
		23m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5445
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 94779ee0545d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `9f6ec47`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/2/testReport/
Max. process+thread count	622 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-02T12:39:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 15s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 32s	branch-2 passed
+1 💚	compile	0m 22s	branch-2 passed
+1 💚	checkstyle	0m 10s	branch-2 passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 28s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 36s	the patch passed
+1 💚	compile	0m 24s	the patch passed
+1 💚	javac	0m 24s	the patch passed
-0 ⚠️	checkstyle	0m 11s	hbase-backup: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
-0 ⚠️	whitespace	0m 0s	The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	hadoopcheck	12m 58s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
-1 ❌	spotless	0m 40s	patch has 49 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	0m 36s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		23m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5445
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 8624217c2e08 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `9f6ec47`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-backup.txt
whitespace	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/2/artifact/yetus-general-check/output/whitespace-eol.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/2/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	77 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-02T13:19:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 44s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 9s	branch-2 passed
+1 💚	compile	0m 13s	branch-2 passed
+1 💚	shadedjars	4m 54s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 10s	the patch passed
+1 💚	compile	0m 13s	the patch passed
+1 💚	javac	0m 13s	the patch passed
+1 💚	shadedjars	4m 54s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 7s	hbase-backup in the patch passed.
		18m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5445
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3a4e2c31beda 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `9f6ec47`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/3/testReport/
Max. process+thread count	591 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-02T13:20:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 32s	branch-2 passed
+1 💚	compile	0m 14s	branch-2 passed
+1 💚	shadedjars	5m 16s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	compile	0m 15s	the patch passed
+1 💚	javac	0m 15s	the patch passed
+1 💚	shadedjars	5m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 4s	hbase-backup in the patch passed.
		20m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5445
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ea5146d1be34 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `9f6ec47`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/3/testReport/
Max. process+thread count	625 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-02T13:24:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 15s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 33s	branch-2 passed
+1 💚	compile	0m 23s	branch-2 passed
+1 💚	checkstyle	0m 10s	branch-2 passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 29s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 34s	the patch passed
+1 💚	compile	0m 23s	the patch passed
+1 💚	javac	0m 23s	the patch passed
+1 💚	checkstyle	0m 10s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 56s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 37s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		23m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5445
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux d833958b432e 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `9f6ec47`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2023-10-06T12:53:11Z

hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupUtils.java

@@ -87,21 +87,26 @@ public Path run() {

  @Test
  public void testFilesystemWalHostNameParsing() throws IOException {
-    String host = "localhost";
+    String host = "a-region-server.domain.com";


I think we should try different patterns of server names here, like 'localhost', ip address, typical hostname, etc.

Apache-HBase · 2023-10-06T13:54:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 26s	branch-2 passed
+1 💚	compile	0m 13s	branch-2 passed
+1 💚	shadedjars	4m 54s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 11s	the patch passed
+1 💚	compile	0m 13s	the patch passed
+1 💚	javac	0m 13s	the patch passed
+1 💚	shadedjars	4m 52s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 6s	hbase-backup in the patch passed.
		19m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5445
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 93c01db926eb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `03c5ac7`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/4/testReport/
Max. process+thread count	588 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-06T13:58:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 22s	branch-2 passed
+1 💚	compile	0m 19s	branch-2 passed
+1 💚	shadedjars	5m 42s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 3s	the patch passed
+1 💚	compile	0m 20s	the patch passed
+1 💚	javac	0m 20s	the patch passed
+1 💚	shadedjars	5m 45s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 12s	hbase-backup in the patch passed.
		23m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5445
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 92377833f8b2 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `03c5ac7`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/4/testReport/
Max. process+thread count	625 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-06T14:01:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 22s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 41s	branch-2 passed
+1 💚	compile	0m 23s	branch-2 passed
+1 💚	checkstyle	0m 11s	branch-2 passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 30s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 30s	the patch passed
+1 💚	compile	0m 24s	the patch passed
+1 💚	javac	0m 24s	the patch passed
+1 💚	checkstyle	0m 9s	the patch passed
-0 ⚠️	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	hadoopcheck	14m 42s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
-1 ❌	spotless	0m 44s	patch has 36 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	0m 38s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		25m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5445
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux cbc2c3e16d59 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `03c5ac7`
Default Java	Eclipse Adoptium-11.0.17+8
whitespace	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/4/artifact/yetus-general-check/output/whitespace-eol.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/4/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Make the hostname parsing in BackupUtils#parseHostFromOldLog more lenient by not making any assumptions about the name of the file other than that it starts with a org.apache.hadoop.hbase.ServerName.

Apache-HBase · 2023-10-06T14:26:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 7s	branch-2 passed
+1 💚	compile	0m 13s	branch-2 passed
+1 💚	shadedjars	4m 52s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 8s	the patch passed
+1 💚	compile	0m 15s	the patch passed
+1 💚	javac	0m 15s	the patch passed
+1 💚	shadedjars	4m 53s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 9s	hbase-backup in the patch passed.
		18m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5445
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d647f1cc039a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `960df9d`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/5/testReport/
Max. process+thread count	587 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-06T14:31:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 49s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 23s	branch-2 passed
+1 💚	compile	0m 19s	branch-2 passed
+1 💚	shadedjars	6m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 15s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
+1 💚	shadedjars	5m 20s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 14s	hbase-backup in the patch passed.
		23m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5445
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9e6201962304 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `960df9d`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/5/testReport/
Max. process+thread count	623 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-06T14:35:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 22s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 34s	branch-2 passed
+1 💚	compile	0m 30s	branch-2 passed
+1 💚	checkstyle	0m 9s	branch-2 passed
+1 💚	spotless	0m 53s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 34s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 21s	the patch passed
+1 💚	compile	0m 29s	the patch passed
+1 💚	javac	0m 29s	the patch passed
+1 💚	checkstyle	0m 10s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	15m 1s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚	spotless	0m 42s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 36s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		28m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5445
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 61662bf58645 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `960df9d`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	77 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5445/5/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Make the hostname parsing in BackupUtils#parseHostFromOldLog more lenient by not making any assumptions about the name of the file other than that it starts with a org.apache.hadoop.hbase.ServerName. Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 9262cbc)

…che#5445) Make the hostname parsing in BackupUtils#parseHostFromOldLog more lenient by not making any assumptions about the name of the file other than that it starts with a org.apache.hadoop.hbase.ServerName. Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 9262cbc)

… HBase backup (apache#5445) Make the hostname parsing in BackupUtils#parseHostFromOldLog more lenient by not making any assumptions about the name of the file other than that it starts with a org.apache.hadoop.hbase.ServerName. Signed-off-by: Duo Zhang <zhangduo@apache.org>

janvanbesien-ngdata force-pushed the HBASE-28082_parse_host_from_oldlog branch from 40d88d9 to 9ff373d Compare October 2, 2023 12:14

janvanbesien-ngdata force-pushed the HBASE-28082_parse_host_from_oldlog branch from 9ff373d to 1a2bfdd Compare October 2, 2023 12:51

Apache9 reviewed Oct 6, 2023

View reviewed changes

janvanbesien-ngdata force-pushed the HBASE-28082_parse_host_from_oldlog branch from 1a2bfdd to 3f5050d Compare October 6, 2023 13:26

HBASE-28082 more lenient WAL hostname parsing

14da0f8

Make the hostname parsing in BackupUtils#parseHostFromOldLog more lenient by not making any assumptions about the name of the file other than that it starts with a org.apache.hadoop.hbase.ServerName.

janvanbesien-ngdata force-pushed the HBASE-28082_parse_host_from_oldlog branch from 3f5050d to 14da0f8 Compare October 6, 2023 14:04

Apache9 approved these changes Oct 7, 2023

View reviewed changes

Apache9 changed the title ~~HBASE-28082 more lenient WAL hostname parsing~~ HBASE-28082 oldWALs naming can be incompatible with HBase backup Oct 7, 2023

Apache9 merged commit 9262cbc into apache:branch-2 Oct 7, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28082 oldWALs naming can be incompatible with HBase backup #5445

HBASE-28082 oldWALs naming can be incompatible with HBase backup #5445

janvanbesien-ngdata commented Oct 2, 2023

Apache-HBase commented Oct 2, 2023

Apache-HBase commented Oct 2, 2023

Apache-HBase commented Oct 2, 2023

Apache-HBase commented Oct 2, 2023

Apache-HBase commented Oct 2, 2023

Apache-HBase commented Oct 2, 2023

Apache-HBase commented Oct 2, 2023

Apache-HBase commented Oct 2, 2023

Apache-HBase commented Oct 2, 2023

Apache9 Oct 6, 2023

janvanbesien-ngdata Oct 6, 2023

Apache-HBase commented Oct 6, 2023

Apache-HBase commented Oct 6, 2023

Apache-HBase commented Oct 6, 2023

Apache-HBase commented Oct 6, 2023

Apache-HBase commented Oct 6, 2023

Apache-HBase commented Oct 6, 2023

HBASE-28082 oldWALs naming can be incompatible with HBase backup #5445

HBASE-28082 oldWALs naming can be incompatible with HBase backup #5445

Conversation

janvanbesien-ngdata commented Oct 2, 2023

Apache-HBase commented Oct 2, 2023

Apache-HBase commented Oct 2, 2023

Apache-HBase commented Oct 2, 2023

Apache-HBase commented Oct 2, 2023

Apache-HBase commented Oct 2, 2023

Apache-HBase commented Oct 2, 2023

Apache-HBase commented Oct 2, 2023

Apache-HBase commented Oct 2, 2023

Apache-HBase commented Oct 2, 2023

Apache9 Oct 6, 2023

Choose a reason for hiding this comment

janvanbesien-ngdata Oct 6, 2023

Choose a reason for hiding this comment

Apache-HBase commented Oct 6, 2023

Apache-HBase commented Oct 6, 2023

Apache-HBase commented Oct 6, 2023

Apache-HBase commented Oct 6, 2023

Apache-HBase commented Oct 6, 2023

Apache-HBase commented Oct 6, 2023