HBASE-22899 logging improvements for snapshot operations w/large manifests #547

rabi-kumar · 2019-08-27T08:21:59Z

HBASE-22899 logging improvements for snapshot operations w/large manifests

…fests

…fests: improved formatting

Apache-HBase · 2019-08-27T21:20:42Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	33	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	346	master passed
+1	compile	58	master passed
+1	checkstyle	84	master passed
+1	shadedjars	272	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	38	master passed
0	spotbugs	257	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	254	master passed
		_ Patch Compile Tests _
+1	mvninstall	294	the patch passed
+1	compile	56	the patch passed
+1	javac	56	the patch passed
-1	checkstyle	77	hbase-server: The patch generated 1 new + 22 unchanged - 0 fixed = 23 total (was 22)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	290	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	960	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	33	the patch passed
+1	findbugs	250	the patch passed
		_ Other Tests _
+1	unit	8973	hbase-server in the patch passed.
+1	asflicense	33	The patch does not generate ASF License warnings.
		12431

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/1/artifact/out/Dockerfile
GITHUB PR	#547
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux a51f30b27f54 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh
git revision	master / `5106f28`
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/1/artifact/out/diff-checkstyle-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/1/testReport/
Max. process+thread count	4764 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet

LGTM overall. Left some NITs. Please fix the Checkstyle issue.

hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java

…fests.Checkstyle and language reformatting in log messages

Apache-HBase · 2019-08-28T08:39:47Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	74	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	353	master passed
+1	compile	58	master passed
+1	checkstyle	92	master passed
+1	shadedjars	306	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	37	master passed
0	spotbugs	261	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	258	master passed
		_ Patch Compile Tests _
+1	mvninstall	329	the patch passed
+1	compile	58	the patch passed
+1	javac	58	the patch passed
-1	checkstyle	89	hbase-server: The patch generated 1 new + 22 unchanged - 0 fixed = 23 total (was 22)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	302	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1040	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	36	the patch passed
+1	findbugs	259	the patch passed
		_ Other Tests _
+1	unit	12775	hbase-server in the patch passed.
+1	asflicense	26	The patch does not generate ASF License warnings.
		16498

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/2/artifact/out/Dockerfile
GITHUB PR	#547
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 25c844b2cf59 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh
git revision	master / `56980fb`
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/2/artifact/out/diff-checkstyle-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/2/testReport/
Max. process+thread count	4679 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

rabi-kumar · 2019-08-28T08:43:42Z

I made the necessary changes as suggested and fixed the check-style issues.

Apache-HBase · 2019-08-28T19:35:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	38	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	339	master passed
+1	compile	56	master passed
+1	checkstyle	81	master passed
+1	shadedjars	286	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	38	master passed
0	spotbugs	242	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	240	master passed
		_ Patch Compile Tests _
+1	mvninstall	302	the patch passed
+1	compile	54	the patch passed
+1	javac	54	the patch passed
+1	checkstyle	75	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	266	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	935	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	36	the patch passed
+1	findbugs	258	the patch passed
		_ Other Tests _
+1	unit	9461	hbase-server in the patch passed.
+1	asflicense	27	The patch does not generate ASF License warnings.
		12889

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/3/artifact/out/Dockerfile
GITHUB PR	#547
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 5a6b56fd9b51 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh
git revision	master / `56980fb`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/3/testReport/
Max. process+thread count	4491 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-29T04:31:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	70	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	354	master passed
+1	compile	55	master passed
+1	checkstyle	89	master passed
+1	shadedjars	300	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	36	master passed
0	spotbugs	254	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	252	master passed
		_ Patch Compile Tests _
+1	mvninstall	330	the patch passed
+1	compile	57	the patch passed
+1	javac	57	the patch passed
+1	checkstyle	89	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	300	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1035	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	36	the patch passed
+1	findbugs	267	the patch passed
		_ Other Tests _
-1	unit	15151	hbase-server in the patch failed.
+1	asflicense	27	The patch does not generate ASF License warnings.
		18862

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSide3

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/4/artifact/out/Dockerfile
GITHUB PR	#547
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 1e4cf2f40257 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh
git revision	master / `56980fb`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/4/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/4/testReport/
Max. process+thread count	4771 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/4/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet

LGTM.

HorizonNet · 2019-08-29T09:37:50Z

@busbey Could you please also take a look as the creator of the ticket?

Apache-HBase · 2019-08-30T00:08:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	75	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	411	master passed
+1	compile	58	master passed
+1	checkstyle	89	master passed
+1	shadedjars	304	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	43	master passed
0	spotbugs	279	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	275	master passed
		_ Patch Compile Tests _
+1	mvninstall	333	the patch passed
+1	compile	58	the patch passed
+1	javac	58	the patch passed
+1	checkstyle	89	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	311	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1046	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	36	the patch passed
+1	findbugs	282	the patch passed
		_ Other Tests _
+1	unit	14119	hbase-server in the patch passed.
+1	asflicense	24	The patch does not generate ASF License warnings.
		17961

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/5/artifact/out/Dockerfile
GITHUB PR	#547
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 3118f2e2914e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh
git revision	master / `83e7794`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/5/testReport/
Max. process+thread count	5155 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/5/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-30T08:00:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	39	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	348	master passed
+1	compile	58	master passed
+1	checkstyle	77	master passed
+1	shadedjars	274	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	40	master passed
0	spotbugs	247	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	244	master passed
		_ Patch Compile Tests _
+1	mvninstall	297	the patch passed
+1	compile	56	the patch passed
+1	javac	56	the patch passed
+1	checkstyle	75	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	270	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	941	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	36	the patch passed
+1	findbugs	327	the patch passed
		_ Other Tests _
+1	unit	10395	hbase-server in the patch passed.
+1	asflicense	29	The patch does not generate ASF License warnings.
		13891

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/6/artifact/out/Dockerfile
GITHUB PR	#547
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux e4dcc698ff5b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh
git revision	master / `090c55f`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/6/testReport/
Max. process+thread count	4390 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/6/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-30T14:16:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	44	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	421	master passed
+1	compile	71	master passed
+1	checkstyle	107	master passed
+1	shadedjars	351	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	46	master passed
0	spotbugs	311	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	309	master passed
		_ Patch Compile Tests _
+1	mvninstall	352	the patch passed
+1	compile	78	the patch passed
+1	javac	78	the patch passed
+1	checkstyle	110	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	357	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1116	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	40	the patch passed
+1	findbugs	302	the patch passed
		_ Other Tests _
+1	unit	9655	hbase-server in the patch passed.
+1	asflicense	25	The patch does not generate ASF License warnings.
		13796

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/7/artifact/out/Dockerfile
GITHUB PR	#547
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux af18517388e1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh
git revision	master / `090c55f`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/7/testReport/
Max. process+thread count	4295 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/7/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-31T16:46:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	38	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	316	master passed
+1	compile	54	master passed
+1	checkstyle	80	master passed
+1	shadedjars	271	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	37	master passed
0	spotbugs	242	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	239	master passed
		_ Patch Compile Tests _
+1	mvninstall	296	the patch passed
+1	compile	58	the patch passed
+1	javac	58	the patch passed
+1	checkstyle	77	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	276	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	952	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	34	the patch passed
+1	findbugs	268	the patch passed
		_ Other Tests _
-1	unit	9499	hbase-server in the patch failed.
+1	asflicense	31	The patch does not generate ASF License warnings.
		12897

Reason	Tests
Failed junit tests	hadoop.hbase.master.assignment.TestOpenRegionProcedureHang

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/8/artifact/out/Dockerfile
GITHUB PR	#547
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 504bfe3606f5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh
git revision	master / `ee5cf0d`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/8/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/8/testReport/
Max. process+thread count	4286 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/8/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-31T23:06:45Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	89	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	339	master passed
+1	compile	63	master passed
+1	checkstyle	90	master passed
+1	shadedjars	297	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	40	master passed
0	spotbugs	278	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	275	master passed
		_ Patch Compile Tests _
+1	mvninstall	312	the patch passed
+1	compile	57	the patch passed
+1	javac	57	the patch passed
+1	checkstyle	80	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	288	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	966	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	34	the patch passed
+1	findbugs	266	the patch passed
		_ Other Tests _
-1	unit	15908	hbase-server in the patch failed.
+1	asflicense	62	The patch does not generate ASF License warnings.
		19556

Reason	Tests
Failed junit tests	hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
	hadoop.hbase.client.TestFromClientSideWithCoprocessor
	hadoop.hbase.master.assignment.TestOpenRegionProcedureHang

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/9/artifact/out/Dockerfile
GITHUB PR	#547
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux a259b9e93339 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh
git revision	master / `b642ee0`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/9/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/9/testReport/
Max. process+thread count	4666 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/9/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-09-01T16:16:39Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	41	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	375	master passed
+1	compile	66	master passed
+1	checkstyle	92	master passed
+1	shadedjars	286	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	37	master passed
0	spotbugs	248	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	245	master passed
		_ Patch Compile Tests _
+1	mvninstall	295	the patch passed
+1	compile	57	the patch passed
+1	javac	57	the patch passed
+1	checkstyle	76	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	269	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	928	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	35	the patch passed
+1	findbugs	253	the patch passed
		_ Other Tests _
-1	unit	10241	hbase-server in the patch failed.
+1	asflicense	34	The patch does not generate ASF License warnings.
		13704

Reason	Tests
Failed junit tests	hadoop.hbase.regionserver.TestEndToEndSplitTransaction
	hadoop.hbase.master.assignment.TestOpenRegionProcedureHang

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/10/artifact/out/Dockerfile
GITHUB PR	#547
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux a32937347c8b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh
git revision	master / `97fbaa6`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/10/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/10/testReport/
Max. process+thread count	4684 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/10/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-09-01T22:29:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	36	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	447	master passed
+1	compile	74	master passed
+1	checkstyle	106	master passed
+1	shadedjars	348	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	43	master passed
0	spotbugs	332	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	329	master passed
		_ Patch Compile Tests _
+1	mvninstall	402	the patch passed
+1	compile	69	the patch passed
+1	javac	69	the patch passed
+1	checkstyle	110	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	370	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1233	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	43	the patch passed
+1	findbugs	296	the patch passed
		_ Other Tests _
+1	unit	10197	hbase-server in the patch passed.
+1	asflicense	29	The patch does not generate ASF License warnings.
		14595

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/11/artifact/out/Dockerfile
GITHUB PR	#547
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 90ac87c0f59e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh
git revision	master / `345c21d`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/11/testReport/
Max. process+thread count	4295 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/11/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-09-02T06:39:17Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	73	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	433	master passed
+1	compile	59	master passed
+1	checkstyle	97	master passed
+1	shadedjars	302	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	37	master passed
0	spotbugs	286	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	283	master passed
		_ Patch Compile Tests _
+1	mvninstall	330	the patch passed
+1	compile	59	the patch passed
+1	javac	59	the patch passed
+1	checkstyle	88	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	305	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1076	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	37	the patch passed
+1	findbugs	282	the patch passed
		_ Other Tests _
-1	unit	17346	hbase-server in the patch failed.
+1	asflicense	24	The patch does not generate ASF License warnings.
		21245

Reason	Tests
Failed junit tests	hadoop.hbase.namespace.TestNamespaceAuditor
	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.util.TestFromClientSide3WoUnsafe
	hadoop.hbase.client.TestFromClientSideWithCoprocessor
	hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
	hadoop.hbase.master.TestSplitWALManager

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/12/artifact/out/Dockerfile
GITHUB PR	#547
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 30cf7b2cdd62 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh
git revision	master / `a5ef6b2`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/12/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/12/testReport/
Max. process+thread count	4863 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/12/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-09-02T18:39:42Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	77	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	363	master passed
+1	compile	66	master passed
+1	checkstyle	96	master passed
+1	shadedjars	392	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	58	master passed
0	spotbugs	347	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	343	master passed
		_ Patch Compile Tests _
+1	mvninstall	444	the patch passed
+1	compile	60	the patch passed
+1	javac	60	the patch passed
+1	checkstyle	90	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	303	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1121	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	43	the patch passed
+1	findbugs	295	the patch passed
		_ Other Tests _
-1	unit	16428	hbase-server in the patch failed.
+1	asflicense	27	The patch does not generate ASF License warnings.
		20697

Reason	Tests
Failed junit tests	hadoop.hbase.namespace.TestNamespaceAuditor
	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush
	hadoop.hbase.client.TestFromClientSideWithCoprocessor
	hadoop.hbase.master.TestSplitWALManager

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/13/artifact/out/Dockerfile
GITHUB PR	#547
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 08aa7cec5e77 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh
git revision	master / `8e8bd8b`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/13/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/13/testReport/
Max. process+thread count	4777 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/13/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

saintstack · 2019-09-14T17:17:10Z

Merged to Master.

…fests (#547) Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>

…fests (apache#547) Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>

…fests (apache#547) Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> (cherry picked from commit 84cb443) Change-Id: I5a2b2ab9232701b30ded5d2ed9dd4323c391236a

rabi-kumar added 3 commits August 26, 2019 16:16

HBASE-22899 logging improvements for snapshot operations w/large mani…

47c06ce

…fests

HBASE-22899 logging improvements for snapshot operations w/large mani…

ce8b14a

…fests: improved formatting

HBASE-22899 logging improvements for snapshot operations w/large mani…

0519f67

…fests: improved formatting

HorizonNet requested changes Aug 27, 2019

View reviewed changes

HBASE-22899 logging improvements for snapshot operations w/large mani…

8bc487b

…fests.Checkstyle and language reformatting in log messages

HorizonNet approved these changes Aug 29, 2019

View reviewed changes

HorizonNet requested a review from busbey August 29, 2019 09:37

saintstack merged commit a09c0c8 into apache:master Sep 14, 2019

asfgit pushed a commit that referenced this pull request Sep 14, 2019

HBASE-22899 logging improvements for snapshot operations w/large mani…

cfce7a7

…fests (#547) Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>

asfgit pushed a commit that referenced this pull request Sep 14, 2019

HBASE-22899 logging improvements for snapshot operations w/large mani…

84cb443

…fests (#547) Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>

infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020

HBASE-22899 logging improvements for snapshot operations w/large mani…

8118f9d

…fests (apache#547) Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-22899 logging improvements for snapshot operations w/large manifests #547

HBASE-22899 logging improvements for snapshot operations w/large manifests #547

rabi-kumar commented Aug 27, 2019

Apache-HBase commented Aug 27, 2019

HorizonNet left a comment

Apache-HBase commented Aug 28, 2019

rabi-kumar commented Aug 28, 2019

Apache-HBase commented Aug 28, 2019

Apache-HBase commented Aug 29, 2019

HorizonNet left a comment

HorizonNet commented Aug 29, 2019

Apache-HBase commented Aug 30, 2019

Apache-HBase commented Aug 30, 2019

Apache-HBase commented Aug 30, 2019

Apache-HBase commented Aug 31, 2019

Apache-HBase commented Aug 31, 2019

Apache-HBase commented Sep 1, 2019

Apache-HBase commented Sep 1, 2019

Apache-HBase commented Sep 2, 2019

Apache-HBase commented Sep 2, 2019

saintstack commented Sep 14, 2019

HBASE-22899 logging improvements for snapshot operations w/large manifests #547

HBASE-22899 logging improvements for snapshot operations w/large manifests #547

Conversation

rabi-kumar commented Aug 27, 2019

Apache-HBase commented Aug 27, 2019

HorizonNet left a comment

Choose a reason for hiding this comment

Apache-HBase commented Aug 28, 2019

rabi-kumar commented Aug 28, 2019

Apache-HBase commented Aug 28, 2019

Apache-HBase commented Aug 29, 2019

HorizonNet left a comment

Choose a reason for hiding this comment

HorizonNet commented Aug 29, 2019

Apache-HBase commented Aug 30, 2019

Apache-HBase commented Aug 30, 2019

Apache-HBase commented Aug 30, 2019

Apache-HBase commented Aug 31, 2019

Apache-HBase commented Aug 31, 2019

Apache-HBase commented Sep 1, 2019

Apache-HBase commented Sep 1, 2019

Apache-HBase commented Sep 2, 2019

Apache-HBase commented Sep 2, 2019

saintstack commented Sep 14, 2019