Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-28242: Adapts ProfileServlet for async-profiler 2.x #5566

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lfrancke
Copy link
Member

@lfrancke lfrancke commented Dec 6, 2023

  • Adds settings that are available in async-profiler 2.0 and later and removes those that don't exist anymore.
  • Adds support for the itimer event, renames "branches" to "branch-instructions"
  • Removes support for SVG and SUMMARY output and makes FLAMEGRAPH the default

- Adds settings that are available in async-profiler 2.0 and later and removes those that don't exist anymore.
- Adds support for the itimer event, renames "branches" to "branch-instructions"
- Removes support for SVG and SUMMARY output and makes FLAMEGRAPH the default
@lfrancke lfrancke marked this pull request as draft December 6, 2023 23:16
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for branch
+1 💚 mvninstall 3m 4s master passed
+1 💚 compile 5m 7s master passed
+1 💚 checkstyle 1m 13s master passed
+0 🆗 refguide 2m 40s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotless 0m 43s branch has no errors when running spotless:check.
+1 💚 spotbugs 7m 35s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 53s the patch passed
+1 💚 compile 5m 7s the patch passed
-0 ⚠️ javac 5m 7s root generated 2 new + 922 unchanged - 1 fixed = 924 total (was 923)
+1 💚 checkstyle 1m 11s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+0 🆗 refguide 2m 6s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 hadoopcheck 10m 41s Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚 spotless 0m 41s patch has no errors when running spotless:check.
+1 💚 spotbugs 7m 58s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 18s The patch does not generate ASF License warnings.
59m 0s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5566
JIRA Issue HBASE-28242
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile refguide
uname Linux d842d76dffba 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6e421e9
Default Java Eclipse Adoptium-11.0.17+8
refguide https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5566/1/yetus-general-check/output/branch-site/book.html
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt
refguide https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5566/1/yetus-general-check/output/patch-site/book.html
Max. process+thread count 176 (vs. ulimit of 30000)
modules C: hbase-http . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 55s master passed
+1 💚 compile 2m 4s master passed
+1 💚 shadedjars 4m 57s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 8s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 2m 41s the patch passed
+1 💚 compile 2m 1s the patch passed
+1 💚 javac 2m 1s the patch passed
+1 💚 shadedjars 4m 57s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 14s the patch passed
_ Other Tests _
+1 💚 unit 297m 9s root in the patch passed.
328m 39s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5566
JIRA Issue HBASE-28242
Optional Tests javac javadoc unit shadedjars compile
uname Linux c579ed525fcc 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6e421e9
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/1/testReport/
Max. process+thread count 8460 (vs. ulimit of 30000)
modules C: hbase-http . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 2m 36s master passed
+1 💚 compile 1m 36s master passed
+1 💚 shadedjars 5m 13s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 31s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 2m 16s the patch passed
+1 💚 compile 1m 37s the patch passed
+1 💚 javac 1m 37s the patch passed
+1 💚 shadedjars 5m 10s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 32s the patch passed
_ Other Tests _
-1 ❌ unit 352m 15s root in the patch failed.
379m 15s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5566
JIRA Issue HBASE-28242
Optional Tests javac javadoc unit shadedjars compile
uname Linux a649a4e59937 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6e421e9
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/1/testReport/
Max. process+thread count 4694 (vs. ulimit of 30000)
modules C: hbase-http . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 26s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 2m 52s master passed
+1 💚 compile 5m 2s master passed
+1 💚 checkstyle 1m 11s master passed
+0 🆗 refguide 2m 7s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotless 0m 42s branch has no errors when running spotless:check.
+1 💚 spotbugs 7m 31s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 2m 44s the patch passed
+1 💚 compile 5m 1s the patch passed
-0 ⚠️ javac 5m 1s root generated 1 new + 923 unchanged - 0 fixed = 924 total (was 923)
+1 💚 checkstyle 1m 15s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+0 🆗 refguide 2m 8s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 hadoopcheck 10m 45s Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚 spotless 0m 41s patch has no errors when running spotless:check.
+1 💚 spotbugs 7m 50s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 17s The patch does not generate ASF License warnings.
57m 31s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5566
JIRA Issue HBASE-28242
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile refguide
uname Linux 534232e902ba 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6e421e9
Default Java Eclipse Adoptium-11.0.17+8
refguide https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5566/2/yetus-general-check/output/branch-site/book.html
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/2/artifact/yetus-general-check/output/diff-compile-javac-root.txt
refguide https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5566/2/yetus-general-check/output/patch-site/book.html
Max. process+thread count 177 (vs. ulimit of 30000)
modules C: hbase-http . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/2/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 2m 57s master passed
+1 💚 compile 2m 2s master passed
+1 💚 shadedjars 4m 56s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 11s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 42s the patch passed
+1 💚 compile 2m 2s the patch passed
+1 💚 javac 2m 2s the patch passed
+1 💚 shadedjars 4m 54s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 9s the patch passed
_ Other Tests _
-1 ❌ unit 286m 48s root in the patch failed.
316m 34s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5566
JIRA Issue HBASE-28242
Optional Tests javac javadoc unit shadedjars compile
uname Linux 441d60b47ca5 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6e421e9
Default Java Eclipse Adoptium-11.0.17+8
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/2/testReport/
Max. process+thread count 5505 (vs. ulimit of 30000)
modules C: hbase-http . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 31s master passed
+1 💚 compile 1m 38s master passed
+1 💚 shadedjars 4m 44s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 36s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 17s the patch passed
+1 💚 compile 1m 42s the patch passed
+1 💚 javac 1m 42s the patch passed
+1 💚 shadedjars 4m 42s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 35s the patch passed
_ Other Tests _
-1 ❌ unit 429m 27s root in the patch failed.
457m 19s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5566
JIRA Issue HBASE-28242
Optional Tests javac javadoc unit shadedjars compile
uname Linux 3abebc2928a0 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6e421e9
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/2/testReport/
Max. process+thread count 5086 (vs. ulimit of 30000)
modules C: hbase-http . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@lfrancke
Copy link
Member Author

The test failures seem unrelated.
Can someone explain to me what the difference between all those Jenkins runs is?

@lfrancke lfrancke marked this pull request as ready for review December 12, 2023 12:50
@Apache9
Copy link
Contributor

Apache9 commented Dec 25, 2023

The test failures seem unrelated. Can someone explain to me what the difference between all those Jenkins runs is?

The general check is mostly for testing compiling and install.

They other two checks are for running tests against jdk8 and jdk11.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 11s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 30s master passed
+1 💚 compile 5m 29s master passed
+1 💚 checkstyle 1m 28s master passed
+0 🆗 refguide 2m 39s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotless 0m 41s branch has no errors when running spotless:check.
+1 💚 spotbugs 7m 16s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 35s the patch passed
+1 💚 compile 4m 54s the patch passed
-0 ⚠️ javac 4m 54s root generated 1 new + 923 unchanged - 0 fixed = 924 total (was 923)
+1 💚 checkstyle 1m 3s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+0 🆗 refguide 1m 57s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 hadoopcheck 10m 3s Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚 spotless 0m 40s patch has no errors when running spotless:check.
+1 💚 spotbugs 7m 26s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 17s The patch does not generate ASF License warnings.
60m 5s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5566
JIRA Issue HBASE-28242
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile refguide
uname Linux d192018cf3ed 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 75801a5
Default Java Eclipse Adoptium-11.0.17+8
refguide https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5566/3/yetus-general-check/output/branch-site/book.html
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/3/artifact/yetus-general-check/output/diff-compile-javac-root.txt
refguide https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5566/3/yetus-general-check/output/patch-site/book.html
Max. process+thread count 178 (vs. ulimit of 30000)
modules C: hbase-http . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/3/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 55s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for branch
+1 💚 mvninstall 4m 20s master passed
+1 💚 compile 2m 48s master passed
+1 💚 shadedjars 9m 45s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 48s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for patch
+1 💚 mvninstall 4m 55s the patch passed
+1 💚 compile 3m 18s the patch passed
+1 💚 javac 3m 18s the patch passed
+1 💚 shadedjars 7m 49s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 15s the patch passed
_ Other Tests _
+1 💚 unit 304m 47s root in the patch passed.
354m 32s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5566
JIRA Issue HBASE-28242
Optional Tests javac javadoc unit shadedjars compile
uname Linux 8828f970bcfe 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 75801a5
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/3/testReport/
Max. process+thread count 8584 (vs. ulimit of 30000)
modules C: hbase-http . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/3/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 40s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for branch
+1 💚 mvninstall 2m 24s master passed
+1 💚 compile 1m 39s master passed
+1 💚 shadedjars 4m 44s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 37s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 22s the patch passed
+1 💚 compile 1m 39s the patch passed
+1 💚 javac 1m 39s the patch passed
+1 💚 shadedjars 4m 41s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 37s the patch passed
_ Other Tests _
+1 💚 unit 394m 26s root in the patch passed.
422m 46s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5566
JIRA Issue HBASE-28242
Optional Tests javac javadoc unit shadedjars compile
uname Linux e33b02ec501f 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 75801a5
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/3/testReport/
Max. process+thread count 8166 (vs. ulimit of 30000)
modules C: hbase-http . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/3/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 35s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 1s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 2m 57s master passed
+1 💚 compile 4m 58s master passed
+1 💚 checkstyle 1m 8s master passed
+0 🆗 refguide 2m 50s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotless 0m 44s branch has no errors when running spotless:check.
+1 💚 spotbugs 7m 43s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 43s the patch passed
+1 💚 compile 4m 55s the patch passed
-0 ⚠️ javac 4m 55s root generated 2 new + 922 unchanged - 1 fixed = 924 total (was 923)
+1 💚 checkstyle 1m 2s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+0 🆗 refguide 2m 13s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 hadoopcheck 4m 46s Patch does not cause any errors with Hadoop 3.3.6.
+1 💚 spotless 0m 41s patch has no errors when running spotless:check.
+1 💚 spotbugs 8m 0s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 22s The patch does not generate ASF License warnings.
52m 26s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5566
JIRA Issue HBASE-28242
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile refguide
uname Linux 33e76c78f194 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4aeabdc
Default Java Eclipse Adoptium-11.0.17+8
refguide https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5566/4/yetus-general-check/output/branch-site/book.html
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/4/artifact/yetus-general-check/output/diff-compile-javac-root.txt
refguide https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5566/4/yetus-general-check/output/patch-site/book.html
Max. process+thread count 176 (vs. ulimit of 30000)
modules C: hbase-http . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/4/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for branch
+1 💚 mvninstall 2m 53s master passed
+1 💚 compile 1m 59s master passed
+1 💚 shadedjars 5m 7s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 10s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 2m 45s the patch passed
+1 💚 compile 2m 1s the patch passed
+1 💚 javac 2m 1s the patch passed
+1 💚 shadedjars 5m 9s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 15s the patch passed
_ Other Tests _
-1 ❌ unit 253m 47s root in the patch failed.
284m 40s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5566
JIRA Issue HBASE-28242
Optional Tests javac javadoc unit shadedjars compile
uname Linux bfd43c0ae365 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4aeabdc
Default Java Eclipse Adoptium-11.0.17+8
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/4/testReport/
Max. process+thread count 5608 (vs. ulimit of 30000)
modules C: hbase-http . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/4/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 2m 35s master passed
+1 💚 compile 1m 42s master passed
+1 💚 shadedjars 4m 56s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 38s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 23s the patch passed
+1 💚 compile 1m 40s the patch passed
+1 💚 javac 1m 40s the patch passed
+1 💚 shadedjars 4m 56s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 38s the patch passed
_ Other Tests _
-1 ❌ unit 347m 23s root in the patch failed.
375m 32s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5566
JIRA Issue HBASE-28242
Optional Tests javac javadoc unit shadedjars compile
uname Linux d559c4216056 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4aeabdc
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/4/testReport/
Max. process+thread count 5256 (vs. ulimit of 30000)
modules C: hbase-http . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5566/4/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@jojochuang
Copy link
Contributor

Yeah makes sense, even 3.0 is released. the last 1.x release was 2+ years ago.

@lfrancke
Copy link
Member Author

Yeah, I did start a thread on the mailing list and need to get around to update this PR.

@lfrancke lfrancke marked this pull request as draft February 20, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants