HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
TestMasterShutdown seems not related, let's fix the failed UT |
chenxu14
force-pushed
the
HBASE-22802
branch
from
37d18f1
to
8967cb3
Compare
openinx
reviewed
Sep 5, 2019
| while (buffsIterator.hasNext()) { | ||
| ByteBuffer buffer = buffsIterator.next(); | ||
| while (buffer.hasRemaining()) { | ||
| int len = channel.write(curItem, offset); |
There was a problem hiding this comment.
Better to use buffer instead of curItem here, otherwise seems strange here although no much difference in logics. Also maybe we can try to combine the buffsIterator and curItem & curItemIndex into one iterator, seems they are doing the same thing , say tracking the current buffer.
There was a problem hiding this comment.
Better to use buffer instead of curItem here
nice find, use buffer instead
maybe we can try to combine the buffsIterator and curItem & curItemIndex into one iterator
I think it's not easy to do that, the curItem is referenced in so many methods, maybe we should keep the current logic to avoid possible BUGs.
| public static RefCnt create() { | ||
| return new RefCnt(ByteBuffAllocator.NONE); | ||
| } | ||
| public static final RefCnt NONE = new RefCnt(ByteBuffAllocator.NONE) { |
There was a problem hiding this comment.
Is this right ? before we will create a RefCnt which will still increase/decrement the its reference count value, but with a NONE de-allocator to deallocate the memory (means donothing).... now we will create a RefCnt with reference count value to be 1, and never change... I'm afraid that if upper layer depends one the ref cnt value, then will be messed up..
There was a problem hiding this comment.
The RefCnt#NONE is mainly to avoid the creation of temporary objects, but your worries are necessary, will revert it.
chenxu14
force-pushed
the
HBASE-22802
branch
from
8967cb3
to
21b2b87
Compare
|
💔 -1 overall
This message was automatically generated. |
chenxu14
force-pushed
the
HBASE-22802
branch
from
21b2b87
to
ebb76e4
Compare
openinx
approved these changes
Sep 9, 2019
asfgit
pushed a commit
that referenced
this pull request
Sep 9, 2019
|
💔 -1 overall
This message was automatically generated. |
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.