HBASE-28613 Use streaming when marshalling protobuf REST output #5943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
subrat-mishra
approved these changes
May 27, 2024
| // The Jetty 9.4 HttpOutput default commit size is 32K/4 = 8K. We use that size to avoid | ||
| // double buffering (and copying) in HttpOutput. If we ever increase the HttpOutput commit size, | ||
| // we need to adjust this accordingly. We should also revisit this when Jetty is upgraded. | ||
| static final int BUFFER_SIZE = 8 * 1024; |
There was a problem hiding this comment.
nit: static/final is redundant as all the fields in an interface are implicitly static/final/public.
| return messageFromObject().toByteArray(); | ||
| } | ||
|
|
||
| public Message messageFromObject(); |
There was a problem hiding this comment.
nit: Modifier 'public' is also redundant for interface members. It can be removed.
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
ankitsinghal
approved these changes
May 28, 2024
Comment on lines
+54
to
+57
| default byte[] createProtobufOutput() { | ||
| return messageFromObject().toByteArray(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Now this will not be used anywhere? Should we remove it?
There was a problem hiding this comment.
While being marked as Interfacetype.PRIVATE, this is in fact used by all tests, and has to be used by client code as well.
If we removed this, we'd have to change all protobuf tests, and all existing client code using protobuf would have to be rewritten.
Ideally, we'd have some kind of public interface for marshalling/unmarshalling the REST structures client side, or we'd have them hooked up to the rest framework client code, but we don't.
The existing REST Client class relies on passing marshalled byte arrays everywhere. There may be a way to provide a more elegant Jax-RS based client, but that would only apply to new clients.
stoty
added a commit
that referenced
this pull request
May 28, 2024
Signed-off-by: Ankit Singhal <ankit@apache.org> (cherry picked from commit d1d8b4d)
stoty
added a commit
that referenced
this pull request
May 28, 2024
Signed-off-by: Ankit Singhal <ankit@apache.org> (cherry picked from commit d1d8b4d)
stoty
added a commit
that referenced
this pull request
May 28, 2024
Signed-off-by: Ankit Singhal <ankit@apache.org> (cherry picked from commit d1d8b4d)
stoty
added a commit
that referenced
this pull request
May 28, 2024
Signed-off-by: Ankit Singhal <ankit@apache.org> (cherry picked from commit d1d8b4d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.