Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "HBASE-28879 Bump hbase-thirdparty to 4.1.9" to branch-2.6 #6298

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Backport "HBASE-28879 Bump hbase-thirdparty to 4.1.9" to branch-2.6 #6298

merged 5 commits into from
Sep 30, 2024

Conversation

ndimiduk
Copy link
Member

ndimiduk
ndimiduk commented Sep 25, 2024
View reviewed changes
pom.xml
@@ -610,7 +610,7 @@
<external.protoc.version>${external.protobuf.version}</external.protoc.version>
<!--Version of protobuf that hbase uses internally (we shade our pb)
Must match what is out in hbase-thirdparty include. -->
<internal.protobuf.version>4.26.1</internal.protobuf.version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we missed syncing the internal protobuf version when we bumped to hbase-thirdparty-4.1.8.

@ndimiduk ndimiduk changed the title Backport "Test with hbase-thirdparty 4.1.9RC0" to branch-2.6 Backport "HBASE-28879 Bump hbase-thirdparty to 4.1.9" to branch-2.6 Sep 25, 2024
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@ndimiduk ndimiduk force-pushed the hbase-thirdparty-4.1.9rc0-branch-2.6 branch from ae28089 to c2294c2 Compare September 26, 2024 09:16
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@ndimiduk ndimiduk force-pushed the hbase-thirdparty-4.1.9rc0-branch-2.6 branch from c2294c2 to ecd95df Compare September 27, 2024 12:41
@ndimiduk ndimiduk marked this pull request as ready for review September 27, 2024 12:42
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 7s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2.6 Compile Tests _
+1 💚 mvninstall 4m 40s branch-2.6 passed
+1 💚 compile 8m 32s branch-2.6 passed
+1 💚 spotless 1m 0s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 41s the patch passed
+1 💚 compile 8m 22s the patch passed
-0 ⚠️ javac 8m 22s /results-compile-javac-root.txt root generated 4 new + 1236 unchanged - 3 fixed = 1240 total (was 1239)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 xmllint 0m 0s No new issues.
+1 💚 hadoopcheck 18m 21s Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚 spotless 0m 56s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 13s The patch does not generate ASF License warnings.
49m 34s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6298/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6298
Optional Tests dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
uname Linux 5a8e8047cc82 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / ecd95df
Default Java Eclipse Adoptium-11.0.23+9
Max. process+thread count 74 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6298/4/console
versions git=2.34.1 maven=3.9.8 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 5s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚 mvninstall 4m 39s branch-2.6 passed
+1 💚 compile 3m 5s branch-2.6 passed
+1 💚 javadoc 2m 48s branch-2.6 passed
+1 💚 shadedjars 8m 56s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 49s the patch passed
+1 💚 compile 3m 21s the patch passed
+1 💚 javac 3m 21s the patch passed
+1 💚 javadoc 3m 3s the patch passed
+1 💚 shadedjars 8m 34s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 262m 34s /patch-unit-root.txt root in the patch failed.
308m 23s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6298/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6298
Optional Tests javac javadoc unit shadedjars compile
uname Linux fb6941db033b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / ecd95df
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6298/4/testReport/
Max. process+thread count 5042 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6298/4/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 44s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚 mvninstall 3m 5s branch-2.6 passed
+1 💚 compile 2m 10s branch-2.6 passed
+1 💚 javadoc 1m 58s branch-2.6 passed
+1 💚 shadedjars 5m 26s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 55s the patch passed
+1 💚 compile 2m 10s the patch passed
+1 💚 javac 2m 10s the patch passed
+1 💚 javadoc 1m 53s the patch passed
+1 💚 shadedjars 5m 30s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 302m 53s root in the patch passed.
335m 34s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6298/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #6298
Optional Tests javac javadoc unit shadedjars compile
uname Linux af7641e001e2 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / ecd95df
Default Java Eclipse Adoptium-11.0.23+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6298/4/testReport/
Max. process+thread count 8347 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6298/4/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 58s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚 mvninstall 3m 16s branch-2.6 passed
+1 💚 compile 2m 12s branch-2.6 passed
+1 💚 javadoc 2m 19s branch-2.6 passed
+1 💚 shadedjars 6m 38s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 44s the patch passed
+1 💚 compile 2m 3s the patch passed
+1 💚 javac 2m 3s the patch passed
-0 ⚠️ javadoc 1m 52s /results-javadoc-javadoc-root.txt root generated 10 new + 86 unchanged - 10 fixed = 96 total (was 96)
+1 💚 shadedjars 5m 49s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 455m 5s /patch-unit-root.txt root in the patch failed.
489m 29s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6298/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #6298
Optional Tests javac javadoc unit shadedjars compile
uname Linux 5236fcf0de4c 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / ecd95df
Default Java Temurin-1.8.0_412-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6298/4/testReport/
Max. process+thread count 7743 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6298/4/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk ndimiduk merged commit 988c84a into apache:branch-2.6 Sep 30, 2024
1 check failed
@ndimiduk ndimiduk deleted the hbase-thirdparty-4.1.9rc0-branch-2.6 branch September 30, 2024 10:47
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Sep 30, 2024
@ndimiduk
Revert "Backport "HBASE-28879 Bump hbase-thirdparty to 4.1.9" to bran…
1e08657 
…ch-2.6 (apache#6298)"

This reverts commit 988c84a.
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Sep 30, 2024
@ndimiduk
HBASE-28879 Bump hbase-thirdparty to 4.1.9 (apache#6298)
cb69aa4 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Nihal Jain <nihaljain@apache.org>
ndimiduk added a commit that referenced this pull request Sep 30, 2024
@ndimiduk
Revert "Backport "HBASE-28879 Bump hbase-thirdparty to 4.1.9" to bran…
f2aa061 
…ch-2.6 (#6298)"

This reverts commit 988c84a.
ndimiduk added a commit that referenced this pull request Sep 30, 2024
@ndimiduk
HBASE-28879 Bump hbase-thirdparty to 4.1.9 (#6298)
37b706a 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndimiduk @Apache-HBase