Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-23208 Unit formatting in Master & RS UI #752

Closed
wants to merge 1 commit into from

Conversation

karthikhw
Copy link
Contributor

ProcV2 use org.apache.hadoop.hbase.procedure2.util.StringUtils#humanTimeDiff(long) and humanSize(double) where it returns human readable string. I think it would good if we format the string before we return it.

The same format will apply to master and regionserver logs. I hope no one will concern about this format change.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
💙 reexec 1m 32s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💛 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
💚 mvninstall 6m 40s master passed
💚 compile 0m 18s master passed
💚 checkstyle 0m 16s master passed
💚 shadedjars 5m 1s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 0m 16s master passed
💙 spotbugs 0m 39s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 0m 36s master passed
_ Patch Compile Tests _
💚 mvninstall 5m 30s the patch passed
💚 compile 0m 18s the patch passed
💚 javac 0m 18s the patch passed
💚 checkstyle 0m 14s the patch passed
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 5m 1s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 17m 15s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚 javadoc 0m 15s the patch passed
💚 findbugs 0m 41s the patch passed
_ Other Tests _
💚 unit 3m 31s hbase-procedure in the patch passed.
💚 asflicense 0m 13s The patch does not generate ASF License warnings.
54m 26s
Subsystem Report/Notes
Docker Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-752/1/artifact/out/Dockerfile
GITHUB PR #752
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux f245907ec953 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-752/out/precommit/personality/provided.sh
git revision master / 59fc163
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-752/1/testReport/
Max. process+thread count 279 (vs. ulimit of 10000)
modules C: hbase-procedure U: hbase-procedure
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-752/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@binlijin
Copy link
Contributor

LGTM

@busbey
Copy link
Contributor

busbey commented Oct 29, 2019

merged

@busbey busbey closed this Oct 29, 2019
@busbey
Copy link
Contributor

busbey commented Oct 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants