Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-23242: [checkstyle] Make LineLength a child of Checker module. #783

Closed
wants to merge 1 commit into from

Conversation

bharathv
Copy link
Contributor

@bharathv bharathv commented Nov 1, 2019

As per checkstyle docs[1], it should be placed under Checker. Otherwise
intellij complains to import this configuration.

[1] https://checkstyle.sourceforge.io/config_sizes.html#LineLength

As per checkstyle docs[1], it should be placed under Checker. Otherwise
intellij complains to import this configuration.

[1] https://checkstyle.sourceforge.io/config_sizes.html#LineLength
@bharathv
Copy link
Contributor Author

bharathv commented Nov 1, 2019

@saintstack You seemed to have touched this file recently. Can you please take a look? Thanks.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 3m 26s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 @author 0m 0s The patch does not contain any @author tags.
💛 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
💚 mvninstall 5m 50s master passed
💚 checkstyle 2m 52s master passed
💚 javadoc 0m 12s master passed
_ Patch Compile Tests _
💚 mvninstall 5m 30s the patch passed
💔 checkstyle 0m 10s The patch fails to run checkstyle in root
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 xml 0m 1s The patch has no ill-formed XML file.
💚 javadoc 0m 11s the patch passed
_ Other Tests _
💚 unit 0m 11s hbase-checkstyle in the patch passed.
💚 asflicense 0m 12s The patch does not generate ASF License warnings.
19m 45s
Subsystem Report/Notes
Docker Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-783/1/artifact/out/Dockerfile
GITHUB PR #783
JIRA Issue HBASE-23242
Optional Tests dupname asflicense checkstyle javac javadoc unit xml
uname Linux ba1d27fbf0d9 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-783/out/precommit/personality/provided.sh
git revision master / b8a4504
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-783/1/artifact/out//home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-783/out/maven-patch-checkstyle-root.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-783/1/testReport/
Max. process+thread count 86 (vs. ulimit of 10000)
modules C: hbase-checkstyle U: hbase-checkstyle
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-783/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@bharathv
Copy link
Contributor Author

bharathv commented Nov 2, 2019

It looks like hbase pulls in an older version of checkstyle and the xml is valid for that version. Intellij defaults to v8.25 which is incompatible (rules have changed). Luckily one can select the checkstyle version in Intellij. So we don't need this hbase side change anymore. We still have to fix the file if we upgrade the checkstyle version but that can be done as a part of a separate change I think.

@bharathv bharathv closed this Nov 2, 2019
@bharathv bharathv deleted the HBASE-23242 branch November 2, 2019 22:07
@busbey
Copy link
Contributor

busbey commented Nov 2, 2019

thanks for chasing this down!

@ndimiduk
Copy link
Member

This came up as well in my chat over on checkstyle/checkstyle#7236.

@romani
Copy link

romani commented Nov 29, 2019

Intellij defaults to v8.25 which is incompatible

right now Eclipse and Idea plugins support latest checkstyle (8.26), so update to latest should not problem, but config must be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants