-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-23242: [checkstyle] Make LineLength a child of Checker module. #783
Conversation
As per checkstyle docs[1], it should be placed under Checker. Otherwise intellij complains to import this configuration. [1] https://checkstyle.sourceforge.io/config_sizes.html#LineLength
@saintstack You seemed to have touched this file recently. Can you please take a look? Thanks. |
💔 -1 overall
This message was automatically generated. |
It looks like hbase pulls in an older version of checkstyle and the xml is valid for that version. Intellij defaults to v8.25 which is incompatible (rules have changed). Luckily one can select the checkstyle version in Intellij. So we don't need this hbase side change anymore. We still have to fix the file if we upgrade the checkstyle version but that can be done as a part of a separate change I think. |
thanks for chasing this down! |
This came up as well in my chat over on checkstyle/checkstyle#7236. |
right now Eclipse and Idea plugins support latest checkstyle (8.26), so update to latest should not problem, but config must be changed. |
As per checkstyle docs[1], it should be placed under Checker. Otherwise
intellij complains to import this configuration.
[1] https://checkstyle.sourceforge.io/config_sizes.html#LineLength