HBASE-23264 Resolve a TODO of BucketAllocator: "Why we add the extra … #801

bsglz · 2019-11-06T11:39:48Z

…1024 bytes? Slop?"

Apache-HBase · 2019-11-06T15:28:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
💙	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
💚	dupname	0m 0s	No case conflicting files found.
💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
💚	@author	0m 0s	The patch does not contain any @author tags.
💛	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
💚	mvninstall	5m 27s	master passed
💚	compile	0m 58s	master passed
💚	checkstyle	1m 18s	master passed
💚	shadedjars	4m 39s	branch has no errors when building our shaded downstream artifacts.
💚	javadoc	0m 38s	master passed
💙	spotbugs	4m 5s	Used deprecated FindBugs config; considering switching to SpotBugs.
💚	findbugs	4m 4s	master passed
		_ Patch Compile Tests _
💚	mvninstall	4m 56s	the patch passed
💚	compile	0m 55s	the patch passed
💚	javac	0m 55s	the patch passed
💚	checkstyle	1m 16s	the patch passed
💚	whitespace	0m 0s	The patch has no whitespace issues.
💚	shadedjars	4m 30s	patch has no errors when building our shaded downstream artifacts.
💚	hadoopcheck	15m 30s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚	javadoc	0m 36s	the patch passed
💚	findbugs	4m 12s	the patch passed
		_ Other Tests _
💚	unit	161m 36s	hbase-server in the patch passed.
💚	asflicense	0m 35s	The patch does not generate ASF License warnings.
		218m 4s

Subsystem	Report/Notes
Docker	Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-801/1/artifact/out/Dockerfile
GITHUB PR	#801
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 2c6000119889 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-801/out/precommit/personality/provided.sh
git revision	master / `f0f7fae`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-801/1/testReport/
Max. process+thread count	4510 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-801/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

virajjasani

Except one minor comment, looks good.

virajjasani · 2020-04-26T09:13:39Z

hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java

@@ -269,8 +269,9 @@ public String toString() {

  // Default block size in hbase is 64K, so we choose more sizes near 64K, you'd better
  // reset it according to your cluster's block size distribution
+  // The real block size in hfile may a little larger than the size we configured ,


The real block size in hfile maybe a little larger.....

fixed,thanks for review.

…1024 bytes? Slop?"

virajjasani

+1

Apache-HBase · 2020-04-26T10:12:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 53s	master passed
+1 💚	checkstyle	1m 13s	master passed
+1 💚	spotbugs	2m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 49s	the patch passed
+1 💚	checkstyle	1m 12s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 35s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 20s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		36m 23s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-801/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#801
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 2766e88757ac 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e96ad0a`
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-801/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

#801) Signed-off-by: Viraj Jasani <vjasani@apache.org>

Apache-HBase · 2020-04-26T12:14:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 42s	master passed
+1 💚	compile	0m 56s	master passed
+1 💚	shadedjars	4m 56s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 17s	the patch passed
+1 💚	compile	0m 56s	the patch passed
+1 💚	javac	0m 56s	the patch passed
+1 💚	shadedjars	5m 0s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
-1 ❌	unit	135m 7s	hbase-server in the patch failed.
		157m 47s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-801/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#801
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux dd6b49b6e195 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e96ad0a`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-801/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-801/2/testReport/
Max. process+thread count	4567 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-801/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-26T12:18:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 42s	master passed
+1 💚	compile	1m 12s	master passed
+1 💚	shadedjars	6m 36s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 45s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 13s	the patch passed
+1 💚	compile	1m 26s	the patch passed
+1 💚	javac	1m 26s	the patch passed
+1 💚	shadedjars	6m 45s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 43s	hbase-server in the patch failed.
		_ Other Tests _
-1 ❌	unit	132m 5s	hbase-server in the patch failed.
		162m 11s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-801/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#801
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 68736b93d8d2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e96ad0a`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-801/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-801/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-801/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-801/2/testReport/
Max. process+thread count	3670 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-801/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack · 2020-04-27T20:47:05Z

+1

apache#801) Signed-off-by: Viraj Jasani <vjasani@apache.org>

apache#801) Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit ead2281) Change-Id: Ieb44c7aca8ee335b80767222474feeefe2f7ee6b

HBASE-23264 Resolve a TODO of BucketAllocator: "Why we add the extra …

2cd78ad

…1024 bytes? Slop?"

virajjasani reviewed Apr 26, 2020

View reviewed changes

HBASE-23264 Resolve a TODO of BucketAllocator: "Why we add the extra …

dd1c4a3

…1024 bytes? Slop?"

virajjasani approved these changes Apr 26, 2020

View reviewed changes

virajjasani merged commit ec0d9d7 into apache:master Apr 26, 2020

virajjasani pushed a commit that referenced this pull request Apr 26, 2020

HBASE-23264 Resolve a TODO of BucketAllocator: "Why we add the extra … (

ee5283e

#801) Signed-off-by: Viraj Jasani <vjasani@apache.org>

virajjasani pushed a commit that referenced this pull request Apr 26, 2020

HBASE-23264 Resolve a TODO of BucketAllocator: "Why we add the extra … (

40b07bf

#801) Signed-off-by: Viraj Jasani <vjasani@apache.org>

virajjasani pushed a commit that referenced this pull request Apr 26, 2020

HBASE-23264 Resolve a TODO of BucketAllocator: "Why we add the extra … (

178005e

#801) Signed-off-by: Viraj Jasani <vjasani@apache.org>

virajjasani pushed a commit that referenced this pull request Apr 26, 2020

HBASE-23264 Resolve a TODO of BucketAllocator: "Why we add the extra … (

ead2281

#801) Signed-off-by: Viraj Jasani <vjasani@apache.org>

infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020

HBASE-23264 Resolve a TODO of BucketAllocator: "Why we add the extra … (

5350b4c

apache#801) Signed-off-by: Viraj Jasani <vjasani@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-23264 Resolve a TODO of BucketAllocator: "Why we add the extra … #801

HBASE-23264 Resolve a TODO of BucketAllocator: "Why we add the extra … #801

bsglz commented Nov 6, 2019

Apache-HBase commented Nov 6, 2019

virajjasani left a comment

virajjasani Apr 26, 2020

bsglz Apr 26, 2020

virajjasani left a comment

Apache-HBase commented Apr 26, 2020

Apache-HBase commented Apr 26, 2020

Apache-HBase commented Apr 26, 2020

saintstack commented Apr 27, 2020

HBASE-23264 Resolve a TODO of BucketAllocator: "Why we add the extra … #801

HBASE-23264 Resolve a TODO of BucketAllocator: "Why we add the extra … #801

Conversation

bsglz commented Nov 6, 2019

Apache-HBase commented Nov 6, 2019

virajjasani left a comment

Choose a reason for hiding this comment

virajjasani Apr 26, 2020

Choose a reason for hiding this comment

bsglz Apr 26, 2020

Choose a reason for hiding this comment

virajjasani left a comment

Choose a reason for hiding this comment

Apache-HBase commented Apr 26, 2020

Apache-HBase commented Apr 26, 2020

Apache-HBase commented Apr 26, 2020

saintstack commented Apr 27, 2020