HBASE-23315 Miscellaneous HBCK Report page cleanup #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
saintstack
commented
Nov 18, 2019
saintstack
commented
- Add a bit of javadoc around SerialReplicationChecker.
- Miniscule edit to the profiler jsp page and then a bit of doc on how to make it work that might help.
- Add some detail if NPE getting BitSetNode to help w/ debug.
- Change HbckChore to log region names instead of encoded names; helps doing diagnostics; can take region name and query in shell to find out all about the region according to hbase:meta.
- Add some fix-it help inline in the HBCK Report page – how to fix.
- Add counts in procedures page so can see if making progress; move listing of WALs to end of the page.
|
💔 -1 overall
This message was automatically generated. |
* Add a bit of javadoc around SerialReplicationChecker. * Miniscule edit to the profiler jsp page and then a bit of doc on how to make it work that might help. * Add some detail if NPE getting BitSetNode to help w/ debug. * Change HbckChore to log region names instead of encoded names; helps doing diagnostics; can take region name and query in shell to find out all about the region according to hbase:meta. * Add some fix-it help inline in the HBCK Report page – how to fix. * Add counts in procedures page so can see if making progress; move listing of WALs to end of the page.
saintstack
force-pushed
the
HBASE-23315
branch
from
5b3cec4
to
a8b99f6
Compare
|
💔 -1 overall
This message was automatically generated. |
|
Merging these small changes by hand with fix for the above checkstyle too-long-lines complaint |
ndimiduk
reviewed
Nov 22, 2019
| <p> | ||
| <span> | ||
| The below are Regions we've lost account of. To be safe, run bulk load of any data found in these Region orphan directories back into the HBase cluster. | ||
| First make sure hbase:meta is in healthy state; run 'hbkc2 fixMeta' to be sure. Once this is done, per Region below, run a bulk |
| <span> | ||
| The below are Regions we've lost account of. To be safe, run bulk load of any data found in these Region orphan directories back into the HBase cluster. | ||
| First make sure hbase:meta is in healthy state; run 'hbkc2 fixMeta' to be sure. Once this is done, per Region below, run a bulk | ||
| load -- '$ hbase completebulkload REGION_DIR_PATH TABLE_NAME' -- and then delete the desiccated directory content (HFiles are removed upon successful load; all that is left are empty directories |
There was a problem hiding this comment.
Yuck. In a table with lots of busted regions, this completeBulkLoad would be tedious. Maybe we need a new hbck2 bulkloadOrphanedRegions command that can identify the orphans, bulk load them, and clean up the husks.
| @@ -81,11 +81,14 @@ | |||
| <th>Errors</th> | |||
| <th>Parameters</th> | |||
| </tr> | |||
| <% for (Procedure<?> proc : procedures) { | |||
| <% | |||
There was a problem hiding this comment.
I can't believe we're still actively maintaining JSP in 2020.
|
Belated +1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.