Made DemoClient python 3.0 compatible .. #988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue is the DemoClient.py is not updated for python 3.X. Python 2.X support has ended. Updating this to 3.0. Please see https://issues.apache.org/jira/browse/HBASE-23644
|
💔 -1 overall
This message was automatically generated. |
Closed issue https://issues.apache.org/jira/browse/HBASE-23644. Updated DemoClient.py to work with python 3.0, thrift compiler 0.13 and python thrift 0.13 package which are the latest. Please note even with thrift-0.9.3 DemoClient.py was not compatible with python 3.X.
|
💔 -1 overall
This message was automatically generated. |
|
Does this still work with python 2? Or is it python 3 only? I'd be fine with the master branch being python 3 only if we can make branch-2 python 2 and python 3. This could be done with mutliple examples if needed. |
|
The file DemoClient.py that I made a new pull request in
https://github.com/apache/hbase works with python 3.X. I'm not sure what
the issue with github is, it has broken heart with -1 on top with some
error from pylint. I'm not sure what I need to do to get it fixed. If you
can let me know, I can get it committed.
…On Mon, Jan 6, 2020 at 9:34 AM Sean Busbey ***@***.***> wrote:
Does this still work with python 2? Or is it python 3 only?
I'd be fine with the master branch being python 3 only if we can make
branch-2 python 2 and python 3. This could be done with mutliple examples
if needed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#988?email_source=notifications&email_token=ALFG3HQ2EC6MW4OXB3F26B3Q4NFOZA5CNFSM4KCVOL62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIFZPOQ#issuecomment-571185082>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALFG3HQV4E55L6A4AERW7J3Q4NFOZANCNFSM4KCVOL6Q>
.
|
|
@pytalkweb We're running pylint from the build. Could you please check your changes with pylint? |
|
It seems problem might be with script that runs pylint as stderr.txt
says there is no such option —score. Please see below.
Usage: pylint [options] module_or_package
Check that a module satisfies a coding standard (and more !).
pylint --help
Display this help message and exit.
pylint --help-msg <msg-id>[,<msg-id>]
Display help messages about given message identifiers and exit.
pylint: error: no such option: --score
Regards, Madhu
…On Fri, Jan 24, 2020 at 9:02 AM Jan Hentschel ***@***.***> wrote:
@pytalkweb <https://github.com/pytalkweb> We're running pylint from the
build. Could you please check your changes with pylint?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#988?email_source=notifications&email_token=ALFG3HQ4HGAZODJLFNTTIKLQ7L7JBA5CNFSM4KCVOL62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ3B7AI#issuecomment-578166657>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALFG3HTCLLCDIFAWXGCCAWLQ7L7JBANCNFSM4KCVOL6Q>
.
|
|
The pylint problems could be the same as in #1088. |
|
Just to reiterate here, I would be fine with this being Python 3 only in the master branch, but to do that we need an option to maintain python 2 for branch-2 / branch-1 and hopefully opt-in to python 3 on branch-2 at least. |
|
Will close out unless update inside next week. Thanks. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Closing abandoned PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue is the DemoClient.py is not updated for python 3.X. Python 2.X support has ended. Updating this to 3.0. Please see
https://issues.apache.org/jira/browse/HBASE-23644