Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HELIX-555] Fix deficiency in ClusterStateVerifier api #12

Merged
merged 1 commit into from Nov 21, 2014

Conversation

atcurtis
Copy link
Contributor

@kanakb
Copy link
Member

kanakb commented Nov 21, 2014

It looks like the original code already used ZkClientPool. How does this change improve the situation?

@kanakb
Copy link
Member

kanakb commented Nov 21, 2014

Or are there a bunch of tests/tools that create their own ZK client in addition to the one created by ClusterStateVerifier?

@kanakb
Copy link
Member

kanakb commented Nov 21, 2014

OK, in that case, merged.

@asfgit asfgit merged commit b2794e7 into apache:helix-0.6.x Nov 21, 2014
micahstubbs added a commit to micahstubbs/helix that referenced this pull request Jun 1, 2022
parent ed990b8
author Micah Stubbs <micah.stubbs@gmail.com> 1651701734 -0700
committer Micah Stubbs <micah.stubbs@gmail.com> 1654124891 -0700

# This is a combination of 2 commits.
# This is the 1st commit message:

parent ed990b8
author Micah Stubbs <micah.stubbs@gmail.com> 1651701734 -0700
committer Micah Stubbs <micah.stubbs@gmail.com> 1654124832 -0700

ng update @angular/cli --from=5.2.11 --to=6 --migrate-only

npm i -D rxjs-tslint, add rxjs specific linting rules, add lint:tslint alternative linting script

npm install @angular/cdk@6.1.0

# This is the commit message apache#2:

npm install @angular/{animations,cdk,common,compiler,compiler-cli,core,forms,material,platform-browser,platform-browser-dynamic,platform-server,router}@6.1.0

# This is the commit message apache#5:

npm i ajv@6.9.1

# This is the commit message apache#6:

npm i codelyzer@6.0.1

# This is the commit message apache#7:

npm i ngx-clipboard@11.1.5

# This is the commit message apache#8:

npm i tsickle@0.32.1

# This is the commit message apache#9:

restore rxjs-compat@6.0.0-rc.0 to fix rxjs issue at npm run build

# This is the commit message apache#10:

register proxy.conf.json in ng serve builder in angular.json

# This is the commit message apache#11:

WIP state with new Reactive Form

# This is the commit message apache#12:

Revert "WIP state with new Reactive Form"

This reverts commit f9e2e37.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants