Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HELIX-537] Shutdown executors #8

Merged
merged 1 commit into from Nov 12, 2014
Merged

Conversation

atcurtis
Copy link
Contributor

@kanakb
Copy link
Member

kanakb commented Nov 12, 2014

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /Users/kanak/Developer/incubator-helix/helix-core/src/main/java/org/apache/helix/task/TaskStateModel.java:[70,2] missing return statement
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE

TaskStateModel#shutdown has return type boolean, but returns nothing.

@atcurtis
Copy link
Contributor Author

Oops,

I pushed the wrong commit to github. I’ll force push the correct one to my repo.

On Nov 11, 2014, at 8:42 PM, Kanak Biscuitwala notifications@github.com wrote:

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /Users/kanak/Developer/incubator-helix/helix-core/src/main/java/org/apache/helix/task/TaskStateModel.java:[70,2] missing return statement
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE

TaskStateModel#shutdown has return type boolean, but returns nothing.


Reply to this email directly or view it on GitHub.

@kanakb
Copy link
Member

kanakb commented Nov 12, 2014

LGTM, tests pass, will merge.

@asfgit asfgit merged commit 8d464cf into apache:helix-0.6.x Nov 12, 2014
micahstubbs added a commit to micahstubbs/helix that referenced this pull request Jun 1, 2022
parent ed990b8
author Micah Stubbs <micah.stubbs@gmail.com> 1651701734 -0700
committer Micah Stubbs <micah.stubbs@gmail.com> 1654121552 -0700

# This is a combination of 2 commits.
# This is the 1st commit message:

parent ed990b8
author Micah Stubbs <micah.stubbs@gmail.com> 1651701734 -0700
committer Micah Stubbs <micah.stubbs@gmail.com> 1654121488 -0700

ng update @angular/cli --from=5.2.11 --to=6 --migrate-only

add engines, remove volta since it conflicts with necessary global angular-cli

ngx-dag@0.0.2 --> @swimlane/ngx-graph@6.0.0

npm i -D rxjs-tslint, add rxjs specific linting rules, add lint:tslint alternative linting script

npm install @angular/cdk@6.1.0

# This is the commit message apache#2:

npm install @angular/{animations,cdk,common,compiler,compiler-cli,core,forms,material,platform-browser,platform-browser-dynamic,platform-server,router}@6.1.0

# This is the commit message apache#5:

npm i ajv@6.9.1

# This is the commit message apache#6:

npm i codelyzer@6.0.1

# This is the commit message apache#7:

npm i ngx-clipboard@11.1.5

# This is the commit message apache#8:

npm i tsickle@0.32.1

# This is the commit message apache#9:

restore rxjs-compat@6.0.0-rc.0 to fix rxjs issue at npm run build

# This is the commit message apache#10:

WIP state with new Reactive Form

# This is the commit message apache#11:

Revert "WIP state with new Reactive Form"

This reverts commit f9e2e37.
micahstubbs added a commit to micahstubbs/helix that referenced this pull request Jun 1, 2022
parent ed990b8
author Micah Stubbs <micah.stubbs@gmail.com> 1651701734 -0700
committer Micah Stubbs <micah.stubbs@gmail.com> 1654123923 -0700

# This is a combination of 2 commits.
# This is the 1st commit message:

parent ed990b8
author Micah Stubbs <micah.stubbs@gmail.com> 1651701734 -0700
committer Micah Stubbs <micah.stubbs@gmail.com> 1654123883 -0700

ng update @angular/cli --from=5.2.11 --to=6 --migrate-only

npm i -D rxjs-tslint, add rxjs specific linting rules, add lint:tslint alternative linting script

npm install @angular/cdk@6.1.0

# This is the commit message apache#2:

npm install @angular/{animations,cdk,common,compiler,compiler-cli,core,forms,material,platform-browser,platform-browser-dynamic,platform-server,router}@6.1.0

# This is the commit message apache#5:

npm i ajv@6.9.1

# This is the commit message apache#6:

npm i codelyzer@6.0.1

# This is the commit message apache#7:

npm i ngx-clipboard@11.1.5

# This is the commit message apache#8:

npm i tsickle@0.32.1

# This is the commit message apache#9:

restore rxjs-compat@6.0.0-rc.0 to fix rxjs issue at npm run build

# This is the commit message apache#10:

WIP state with new Reactive Form

# This is the commit message apache#11:

Revert "WIP state with new Reactive Form"

This reverts commit f9e2e37.
micahstubbs added a commit to micahstubbs/helix that referenced this pull request Jun 1, 2022
parent ed990b8
author Micah Stubbs <micah.stubbs@gmail.com> 1651701734 -0700
committer Micah Stubbs <micah.stubbs@gmail.com> 1654124422 -0700

# This is a combination of 2 commits.
# This is the 1st commit message:

parent ed990b8
author Micah Stubbs <micah.stubbs@gmail.com> 1651701734 -0700
committer Micah Stubbs <micah.stubbs@gmail.com> 1654124376 -0700

ng update @angular/cli --from=5.2.11 --to=6 --migrate-only

npm i -D rxjs-tslint, add rxjs specific linting rules, add lint:tslint alternative linting script

npm install @angular/cdk@6.1.0

# This is the commit message apache#2:

npm install @angular/{animations,cdk,common,compiler,compiler-cli,core,forms,material,platform-browser,platform-browser-dynamic,platform-server,router}@6.1.0

# This is the commit message apache#5:

npm i ajv@6.9.1

# This is the commit message apache#6:

npm i codelyzer@6.0.1

# This is the commit message apache#7:

npm i ngx-clipboard@11.1.5

# This is the commit message apache#8:

npm i tsickle@0.32.1

# This is the commit message apache#9:

restore rxjs-compat@6.0.0-rc.0 to fix rxjs issue at npm run build

# This is the commit message apache#10:

WIP state with new Reactive Form

# This is the commit message apache#11:

Revert "WIP state with new Reactive Form"

This reverts commit f9e2e37.
micahstubbs added a commit to micahstubbs/helix that referenced this pull request Jun 1, 2022
parent ed990b8
author Micah Stubbs <micah.stubbs@gmail.com> 1651701734 -0700
committer Micah Stubbs <micah.stubbs@gmail.com> 1654124891 -0700

# This is a combination of 2 commits.
# This is the 1st commit message:

parent ed990b8
author Micah Stubbs <micah.stubbs@gmail.com> 1651701734 -0700
committer Micah Stubbs <micah.stubbs@gmail.com> 1654124832 -0700

ng update @angular/cli --from=5.2.11 --to=6 --migrate-only

npm i -D rxjs-tslint, add rxjs specific linting rules, add lint:tslint alternative linting script

npm install @angular/cdk@6.1.0

# This is the commit message apache#2:

npm install @angular/{animations,cdk,common,compiler,compiler-cli,core,forms,material,platform-browser,platform-browser-dynamic,platform-server,router}@6.1.0

# This is the commit message apache#5:

npm i ajv@6.9.1

# This is the commit message apache#6:

npm i codelyzer@6.0.1

# This is the commit message apache#7:

npm i ngx-clipboard@11.1.5

# This is the commit message apache#8:

npm i tsickle@0.32.1

# This is the commit message apache#9:

restore rxjs-compat@6.0.0-rc.0 to fix rxjs issue at npm run build

# This is the commit message apache#10:

register proxy.conf.json in ng serve builder in angular.json

# This is the commit message apache#11:

WIP state with new Reactive Form

# This is the commit message apache#12:

Revert "WIP state with new Reactive Form"

This reverts commit f9e2e37.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants