[HELIX-525] Add integration tests to verify that dropping a partition from resource ...#7
Merged
asfgit merged 1 commit intoapache:masterfrom Oct 22, 2014
lei-xia:master
Merged
[HELIX-525] Add integration tests to verify that dropping a partition from resource ...#7asfgit merged 1 commit intoapache:masterfrom lei-xia:master
asfgit merged 1 commit intoapache:masterfrom
lei-xia:master
Conversation
Member
There was a problem hiding this comment.
Why is the default rebalance behavior insufficient for CUSTOMIZED mode?
…ce ideal-state should bring partition to initial state and then DROPPED state (for AUTO, SEMI_AUTO, and CUSTOM modes)
Member
Author
|
It is actually not necessary, thanks for pointing out. I updated it, also use TestNG dataprovider to supply RebalanceMode to avoid write one test method for each mode. I will apply the same strategy to many of our existing tests to testing code redundancy in following checkins if you guys are happy with it. |
Member
|
LGTM, thanks! |
micahstubbs
added a commit
to micahstubbs/helix
that referenced
this pull request
Jun 1, 2022
parent ed990b8 author Micah Stubbs <micah.stubbs@gmail.com> 1651701734 -0700 committer Micah Stubbs <micah.stubbs@gmail.com> 1654121552 -0700 # This is a combination of 2 commits. # This is the 1st commit message: parent ed990b8 author Micah Stubbs <micah.stubbs@gmail.com> 1651701734 -0700 committer Micah Stubbs <micah.stubbs@gmail.com> 1654121488 -0700 ng update @angular/cli --from=5.2.11 --to=6 --migrate-only add engines, remove volta since it conflicts with necessary global angular-cli ngx-dag@0.0.2 --> @swimlane/ngx-graph@6.0.0 npm i -D rxjs-tslint, add rxjs specific linting rules, add lint:tslint alternative linting script npm install @angular/cdk@6.1.0 # This is the commit message apache#2: npm install @angular/{animations,cdk,common,compiler,compiler-cli,core,forms,material,platform-browser,platform-browser-dynamic,platform-server,router}@6.1.0 # This is the commit message apache#5: npm i ajv@6.9.1 # This is the commit message apache#6: npm i codelyzer@6.0.1 # This is the commit message apache#7: npm i ngx-clipboard@11.1.5 # This is the commit message apache#8: npm i tsickle@0.32.1 # This is the commit message apache#9: restore rxjs-compat@6.0.0-rc.0 to fix rxjs issue at npm run build # This is the commit message apache#10: WIP state with new Reactive Form # This is the commit message apache#11: Revert "WIP state with new Reactive Form" This reverts commit f9e2e37.
micahstubbs
added a commit
to micahstubbs/helix
that referenced
this pull request
Jun 1, 2022
parent ed990b8 author Micah Stubbs <micah.stubbs@gmail.com> 1651701734 -0700 committer Micah Stubbs <micah.stubbs@gmail.com> 1654123923 -0700 # This is a combination of 2 commits. # This is the 1st commit message: parent ed990b8 author Micah Stubbs <micah.stubbs@gmail.com> 1651701734 -0700 committer Micah Stubbs <micah.stubbs@gmail.com> 1654123883 -0700 ng update @angular/cli --from=5.2.11 --to=6 --migrate-only npm i -D rxjs-tslint, add rxjs specific linting rules, add lint:tslint alternative linting script npm install @angular/cdk@6.1.0 # This is the commit message apache#2: npm install @angular/{animations,cdk,common,compiler,compiler-cli,core,forms,material,platform-browser,platform-browser-dynamic,platform-server,router}@6.1.0 # This is the commit message apache#5: npm i ajv@6.9.1 # This is the commit message apache#6: npm i codelyzer@6.0.1 # This is the commit message apache#7: npm i ngx-clipboard@11.1.5 # This is the commit message apache#8: npm i tsickle@0.32.1 # This is the commit message apache#9: restore rxjs-compat@6.0.0-rc.0 to fix rxjs issue at npm run build # This is the commit message apache#10: WIP state with new Reactive Form # This is the commit message apache#11: Revert "WIP state with new Reactive Form" This reverts commit f9e2e37.
micahstubbs
added a commit
to micahstubbs/helix
that referenced
this pull request
Jun 1, 2022
parent ed990b8 author Micah Stubbs <micah.stubbs@gmail.com> 1651701734 -0700 committer Micah Stubbs <micah.stubbs@gmail.com> 1654124422 -0700 # This is a combination of 2 commits. # This is the 1st commit message: parent ed990b8 author Micah Stubbs <micah.stubbs@gmail.com> 1651701734 -0700 committer Micah Stubbs <micah.stubbs@gmail.com> 1654124376 -0700 ng update @angular/cli --from=5.2.11 --to=6 --migrate-only npm i -D rxjs-tslint, add rxjs specific linting rules, add lint:tslint alternative linting script npm install @angular/cdk@6.1.0 # This is the commit message apache#2: npm install @angular/{animations,cdk,common,compiler,compiler-cli,core,forms,material,platform-browser,platform-browser-dynamic,platform-server,router}@6.1.0 # This is the commit message apache#5: npm i ajv@6.9.1 # This is the commit message apache#6: npm i codelyzer@6.0.1 # This is the commit message apache#7: npm i ngx-clipboard@11.1.5 # This is the commit message apache#8: npm i tsickle@0.32.1 # This is the commit message apache#9: restore rxjs-compat@6.0.0-rc.0 to fix rxjs issue at npm run build # This is the commit message apache#10: WIP state with new Reactive Form # This is the commit message apache#11: Revert "WIP state with new Reactive Form" This reverts commit f9e2e37.
micahstubbs
added a commit
to micahstubbs/helix
that referenced
this pull request
Jun 1, 2022
parent ed990b8 author Micah Stubbs <micah.stubbs@gmail.com> 1651701734 -0700 committer Micah Stubbs <micah.stubbs@gmail.com> 1654124891 -0700 # This is a combination of 2 commits. # This is the 1st commit message: parent ed990b8 author Micah Stubbs <micah.stubbs@gmail.com> 1651701734 -0700 committer Micah Stubbs <micah.stubbs@gmail.com> 1654124832 -0700 ng update @angular/cli --from=5.2.11 --to=6 --migrate-only npm i -D rxjs-tslint, add rxjs specific linting rules, add lint:tslint alternative linting script npm install @angular/cdk@6.1.0 # This is the commit message apache#2: npm install @angular/{animations,cdk,common,compiler,compiler-cli,core,forms,material,platform-browser,platform-browser-dynamic,platform-server,router}@6.1.0 # This is the commit message apache#5: npm i ajv@6.9.1 # This is the commit message apache#6: npm i codelyzer@6.0.1 # This is the commit message apache#7: npm i ngx-clipboard@11.1.5 # This is the commit message apache#8: npm i tsickle@0.32.1 # This is the commit message apache#9: restore rxjs-compat@6.0.0-rc.0 to fix rxjs issue at npm run build # This is the commit message apache#10: register proxy.conf.json in ng serve builder in angular.json # This is the commit message apache#11: WIP state with new Reactive Form # This is the commit message apache#12: Revert "WIP state with new Reactive Form" This reverts commit f9e2e37.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add integration tests to verify that dropping a partition from resource ideal-state should bring partition to initial state and then DROPPED state (for AUTO, SEMI_AUTO, and CUSTOM modes).