Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iceberg-aliyun: Switch tests to JUnit5 + AssertJ-style assertions #9081

Closed
nastra opened this issue Nov 15, 2023 · 2 comments · Fixed by #9122
Closed

iceberg-aliyun: Switch tests to JUnit5 + AssertJ-style assertions #9081

nastra opened this issue Nov 15, 2023 · 2 comments · Fixed by #9122
Labels
beginner Issues for apache iceberg beginners, enjoy to contribute ! good first issue Good for newcomers

Comments

@nastra
Copy link
Contributor

nastra commented Nov 15, 2023

Feature Request / Improvement

The goal is to switch all imports to JUni5 imports and to use AssertJ-style assertions

Query engine

None
@nastra nastra added good first issue Good for newcomers beginner Issues for apache iceberg beginners, enjoy to contribute ! labels Nov 15, 2023
@lisirrx
Copy link
Contributor

lisirrx commented Nov 20, 2023

@nastra Hi, I have read the discussion in #7160 and read some packages which are already changed to JUnit5. I want to have a try.

@nastra
Copy link
Contributor Author

nastra commented Nov 20, 2023

@lisirrx great, feel free to go ahead and open a PR once you have something and tag me for a review

@lisirrx lisirrx mentioned this issue Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner Issues for apache iceberg beginners, enjoy to contribute ! good first issue Good for newcomers
Projects
JUnit4 to JUnit5 Migration
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Aliyun: Switch iceberg-aliyun's tests to Junit5 lisirrx/iceberg
2 participants
@nastra @lisirrx