Spark 3:5 Migrate tests to JUnit5 in source directory

[chinmay-bhat]

This PR contains the part of the files to migrate for Spark 3.5v in the source directory. The remaining files will be migrated in a seperate PR.

Related to PR : #9341

Issue: #9086

TODO:

• self-review

[nastra]

can you please run ./gradlew spotlessApply to fix any formatting?

[nastra]

@chinmay-bhat it looks like the actual/expected part is the wrong way in the AssertJ assertions

[chinmay-bhat]

Thanks for the review. Yes, I assumed the convention was the other way. Will update all the files.

[chinmay-bhat]

Changes made:

1. fix assertThat() to consistently use (actual, expected) convention
2. update tempDir access to protected only when temp is used in subclasses.

Notes:

1. partially updated TestSparkReadProjection.java to be fully updated with parameterized annotations in next PR.

[chinmay-bhat]

Also, file TestInternalRowWrapper extends RecordWrapperTest.

RecordWrapperTest.java is also used by iceberg-flink and uses JUnit4.
Do we need to make a copy of RecordWrapperTest in JUnit5 to migrate TestInternalRowWrapper? The copy and original RecordWrapperTest will be available at the same time. Maybe in another PR?

I haven't added my changes to TestInternalRowWrapper to this PR for that reason.

[nastra]

We should be able to just switch the imports in RecordWrapperTest to JUnit5. That should make the subclasses run with JUnit in Spark + Flink. Converting the Flink subclasses to AssertJ doesn't have to be done within this PR though

[chinmay-bhat]

I don't think that would work. See line 106.
We use Assert:assertEquals through the AssertMethod interface. If we switch the imports, we would have to change the interface & its downstream functions.

[nastra]

I don't think that would work. See line 106. We use Assert:assertEquals through the AssertMethod interface. If we switch the imports, we would have to change the interface & its downstream functions.

The imports I meant is the imports for @Test, not for the Assert class

[chinmay-bhat]

gotcha, I've made all the changes. Do let me know if anymore changes are to be made.

Once this PR is merged, I'll continue work on the remaining files (parameterize and non-parameterize)

[nastra]

I left two minor comments, once those are addressed this can go in

[chinmay-bhat]

changes made!

[chinmay-bhat]

Since this PR depends on #9341, I added a patch of files changed in #9341. Commit 4f88900.

As long as we merge #9341 first, this PR should be good to go :)

[chinmay-bhat]

hmm it seems like even after we merged #9341 into main, Github doesn't recognise and ignore the changes in this PR that now exist in main. Do you recommend that I rebase onto main and force push?

[nastra]

yes you need a rebase + force push

[chinmay-bhat]

done!

Also, I added the parameterized annotations to CatalogTestBase, since SparkCatalogTestBase was parameterized but CatalogTestBase was surprisingly not.