Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement OPTIONAL MATCH #175

Merged
merged 12 commits into from
Jan 26, 2022
Merged

feat: Implement OPTIONAL MATCH #175

merged 12 commits into from
Jan 26, 2022

Conversation

emotionbug
Copy link
Contributor

@emotionbug emotionbug commented Jan 20, 2022 •
edited
Loading

This implements the OPTIONAL MATCH clause. Internally, it is implemented using LEFT JOIN LATERAL of PostgreSQL.
Apart from the OPTIONAL MATCH implementation, it also includes code that solves the problem of ORDER BY Clause.

Previous PR : #149
Jira : https://issues.apache.org/jira/projects/AGE2/issues/AGE2-508

@jrgemignani
Copy link
Contributor

There are some minor formatting (coding standard) issues that need to be addressed.

Additionally, I would like to see some more commenting of functions.

jrgemignani
jrgemignani reviewed Jan 20, 2022
View reviewed changes
Copy link
Contributor

@jrgemignani jrgemignani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding is good! You just need to make sure that the code conforms to AGE's coding standard which changed from PG and AgensGraph.

Also, please add in a bit more comments into the code.

regress/sql/cypher_match.sql Outdated Show resolved Hide resolved
src/backend/parser/cypher_clause.c Outdated Show resolved Hide resolved
src/backend/parser/cypher_clause.c Outdated Show resolved Hide resolved
src/backend/parser/cypher_clause.c Outdated Show resolved Hide resolved
src/backend/parser/cypher_clause.c Outdated Show resolved Hide resolved
src/backend/parser/cypher_clause.c Show resolved Hide resolved
@jrgemignani
Copy link
Contributor

Please resolve the conflicts listed above.

@emotionbug
Merge branch 'master' into optional_match_rebase
1ad97ee 
# Conflicts:
#	src/backend/parser/cypher_gram.y
@emotionbug
Copy link
Contributor Author

Wait...

@emotionbug
Copy link
Contributor Author

Fixed.

@emotionbug
Copy link
Contributor Author

@jrgemignani

@jrgemignani jrgemignani merged commit 8a660da into apache:master Jan 26, 2022
muhammadshoaib pushed a commit to muhammadshoaib/age that referenced this pull request Feb 18, 2022
@emotionbug @muhammadshoaib
feat: Implement OPTIONAL MATCH (apache#175)
bbdd52f 
* feat: Implement `OPTIONAL MATCH`

* Reflect review.

* Reflect review

* Reflect review

* Reflect review

* Reflect review

* Reflect Review

* Reflect review

* Reflect review

* Fix broken
@dtylor dtylor mentioned this pull request Mar 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrgemignani jrgemignani jrgemignani left review comments

@JoshInnis JoshInnis JoshInnis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emotionbug @jrgemignani @JoshInnis