Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commons-lang3 to 3.3.2 #1125

Merged
merged 1 commit into from
Jan 14, 2016
Merged

Conversation

sjcorbett
Copy link
Contributor

Matches Alien4Cloud version, used by brooklyn-tosca.

@aledsage
Copy link
Contributor

aledsage commented Jan 7, 2016

Not sure this change is enough. Looking at mvn dependency:tree, it also has:

[INFO] +- io.swagger:swagger-core:jar:1.5.3:compile
[INFO] |  +- org.apache.commons:commons-lang3:jar:3.1:compile

Do we need an excludes in the swagger-core dependency (from brooklyn-utils-rest-swagger)? Will this break swagger?

Matches Alien4Cloud version, used by brooklyn-tosca
@sjcorbett
Copy link
Contributor Author

@aledsage Thanks for checking this. I've excluded swagger-core's dependency on commons-lang3. As far as I can tell - manual experimentation with various GET/POST/DELETE requests - Swagger continues to function.

@aledsage
Copy link
Contributor

Thanks @sjcorbett - merging now.

@asfgit asfgit merged commit 4f4c4a5 into apache:master Jan 14, 2016
asfgit pushed a commit that referenced this pull request Jan 14, 2016
@sjcorbett sjcorbett deleted the dependency-versions branch February 3, 2016 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants