Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ENCODE_KEY helm values inputs #133

Open
nimjor opened this issue May 18, 2023 · 2 comments
Open

Add ENCODE_KEY helm values inputs #133

nimjor opened this issue May 18, 2023 · 2 comments

Comments

@nimjor
Copy link

nimjor commented May 18, 2023

We recently found out the hard way about the encKey used to encrypt things in the database. It would be helpful for users deploying on kubernetes if the default values file contained references to this feature so that it is more obvious that it can be set (rather than generated by a container that may not persist).

My suggestion is to add inputs in the values file like:

# This is the string used to encrypt sensitive things like PATs in the database.
# Alternatively, you may supply this value to the `lake` container directly as environment variable `ENCODE_KEY`
# If unset, a key will be created dynamically, in which case you should retrieve it and store it somewhere secure and persistent
encodeKey:
  secretName: "" # the name of the Secret containing this encryption key
  secretKey: "" # the name of the key within that Secret which contains the encryption key as its value
@abeizn
Copy link
Contributor

abeizn commented May 19, 2023

@klesh Can you take a look at this issue?

@klesh
Copy link
Contributor

klesh commented May 19, 2023

@klesh Can you take a look at this issue?

Sure, it is a legitimate request.
@nimjor Please keep a tab on #5235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants