-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug][Config-ui] Adding data scope succeeds but the scope is never listed #5853
Comments
Wired. Does the backend have any logs? |
I'll recheck all running components, and get back to you. |
So I tried to re-add and see that in the
And the
I imagine none of that is helping. |
I'm actually experiencing the exact same issue on the GitHub collector on the same version of DevLake (0.18.0-beta4). Looks suspiciously like a pagination limit or something, but I haven't looked through source to confirm yet. |
@nathan-nicholson @renflo I think you are correct, it is the pagination limit
|
@mintsweet we should add support for pagination for the scope lists. |
@klesh that would be great, I understand the project is in incubation and it's perhaps not what you want to focus on solving now but for me that is a blocker. If implementing "the correct/long term solution" is to cumbersome perhaps going KISS would work: remove the limit totally or make it arbitrarily high (10000) for example. |
@renflo Yup, I agree with you. |
Hi, @renflo , After some discussion, we decided to support pagination on v0.19 and remove it from v0.18 because cherry-picking is quite hard between them. |
Search before asking
What happened
Ia have a gitlab connection which works for many projects using it. I am creating a new devlake project but I can't manage to add a new data scope to it. Each time I go through the wizard to add the data scope, it terminates successfully (message under) but when I get back to the connection at
https://<devlake-ui-host>/connections/gitlab/2
it does not list the new data scope, which implicitly means that I can't configure this new project as I can't assign it a data scope, which is a blocker for me.What do you expect to happen
I am expecting to find the new data scope in the list of scopes so I can select and use it.
How to reproduce
Make sure to do 3-5 more than 50 times, I suspect there could be a limit somewhere, see next section..
I could reproduce this behavior with several repositories on my gitlab connection, so it does not seem to be related to the repositories themselves.
Anything else
I notice that I have 50 datascopes listed in this connection. Could there be a limitation in your code which only returns 50 datascope objects? I find it peculiar that it stops at such a round number.
I find no suspicious message in config-ui's logs.
Version
0.18.0beta4
Are you willing to submit PR?
Code of Conduct
The text was updated successfully, but these errors were encountered: