Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][GitHub] Missing Pull Request data when changing the Time Range in Sync Policy #7704

Closed
2 of 3 tasks
d4x1 opened this issue Jul 8, 2024 · 2 comments
Closed
2 of 3 tasks
Labels
component/config-ui This issue or PR relates to config-ui priority/low This issue is not important severity/p1 This bug affects functionality or significantly affect ux Stale type/bug This issue is a bug

Comments

@d4x1
Copy link
Contributor

d4x1 commented Jul 8, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

Some users set up a new project whose connection is GitHub with onboarding guide, because #7703, graphql API is not enabled.This produces two records in pull_requests table.
When users update the time range in project's sync policy config, and click COLLECT DATA. The new pipeline is triggered and finished successfully.
But the data in pull_requests table is incorrected: it still has only two records, but the new time range has more pull requests definitely.

What do you expect to happen

When Time Range option in Sync Policy Config changes, all pull requests should be fetched according to the new time range.

How to reproduce

Ses "what happened"

Anything else

No response

Version

2e56bdd

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@d4x1 d4x1 added type/bug This issue is a bug priority/low This issue is not important labels Jul 8, 2024
@dosubot dosubot bot added component/config-ui This issue or PR relates to config-ui severity/p1 This bug affects functionality or significantly affect ux labels Jul 8, 2024
@d4x1
Copy link
Contributor Author

d4x1 commented Jul 8, 2024

I think it's related to GitHub's PR collector, but due to the small rate limit in GitHub restful API. We should use graphql as much as possible.

Copy link

github-actions bot commented Sep 7, 2024

This issue has been automatically marked as stale because it has been inactive for 60 days. It will be closed in next 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Sep 7, 2024
@klesh klesh closed this as completed Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config-ui This issue or PR relates to config-ui priority/low This issue is not important severity/p1 This bug affects functionality or significantly affect ux Stale type/bug This issue is a bug
Projects
None yet
Development

No branches or pull requests

2 participants