Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][ui] when edit the work flow,the selected connecting line has no style change,but the others have get bigger (1.3.0版本工作流编辑时被选中的line样式不变,其他未被选中的line变粗) #3553

Closed
zoulx-0717 opened this issue Aug 19, 2020 · 11 comments
Labels
bug Something isn't working
Milestone

Comments

@zoulx-0717
Copy link

工作流定义的时候,通过‘’箭头选择器‘’选中line的时候,被选中的line样式不变,未被选中的其他line样式却变粗,而且当鼠标移入变粗了的未被选中的line时,变粗的line又恢复原样,这样的话当我想删除某一条线的时候,我不知道我选中了哪条line

@zoulx-0717 zoulx-0717 added the question Further information is requested label Aug 19, 2020
@xingchun-chen
Copy link
Contributor

Please update the title in English

@break60
Copy link
Contributor

break60 commented Aug 20, 2020

When the connection is changed to a Bezier line, when the connection is selected, the total connection path is selected. This is caused by the fill attribute in the svg path. Currently, the fill attribute is not added to the connection when the connection is selected, and it cannot be changed. Interested friends can also study this problem together
连线改成贝塞尔线时,选中连线时是选择的总个连线路径,这个是svg path里面有个fill属性导致,目前选中连线时不给连线增加fill属性,改不了,有兴趣的小伙伴也可以一起研究下这个问题

@zoulx-0717
Copy link
Author

Solved Method:
First,you can remove all the 'HoverPaintStyle'attribute when the dag init in 'dag.vue'.
Secondly,you should remove all the 'fill' attribute in 'setSvgColor' function in 'dag/source/plugin/util.js' and add a selected color that you want when '.map($(e.canvas)[0].childNodes'.
Method End.
Additional remarks:although cancled the hover style of the connecting line,you can know which line you have selected clearly if you do this.
解决办法:
首先,当dag初始化的时候,你要删除所有的‘HoverPaintStyle’属性在‘dag.vue’文件中。
其次,你要删除‘setSvgColor‘函数中’的所有的’fill‘属性并且添加一个你想要的颜色在‘_.map($(e.canvas)[0].childNodes'的时候在dag/_source/plugin/util.js' 文件中。
方法结束。
补充说明:这样做的话虽然取消了连接线的鼠标悬停样式,但是你可以清楚地知道你选中的是哪条线。

@zoulx-0717 zoulx-0717 changed the title 1.3.0版本工作流编辑时被选中的line样式不变,其他未被选中的line变粗 [1.3.0]version:when edit the work flow,the selected connecting line has no style change,but the others have get bigger 1.3.0版本工作流编辑时被选中的line样式不变,其他未被选中的line变粗 Aug 21, 2020
@break60
Copy link
Contributor

break60 commented Aug 21, 2020

Did you try it locally?
Is the shadow part resolved?

@zoulx-0717
Copy link
Author

Did you try it locally?
Is the shadow part resolved?

Yes,I did and you can try as my way.
By the way,I can not understand the 'shadow part' you said.

@zoulx-0717
Copy link
Author

Maybe this is not the best way,but I think

Did you try it locally?
Is the shadow part resolved?

@break60 maybe I know what you mean,the 'shadow part' means the hover style?I remove the hover style like I said above.

@break60
Copy link
Contributor

break60 commented Aug 21, 2020

Maybe this is not the best way,but I think

Did you try it locally?
Is the shadow part resolved?

@break60 maybe I know what you mean,the 'shadow part' means the hover style?I remove the hover style like I said above.

Try it locally according to your method, it's ok, but I didn't add the distinguishing color, can you pr up?

@zoulx-0717
Copy link
Author

@break60 ok, wait a moment

@break60
Copy link
Contributor

break60 commented Aug 21, 2020

@break60 ok, wait a moment

👌

@zoulx-0717
Copy link
Author

@break60 ok, wait a moment

👌

@break60 because there is trouble with my git,I cant not pr up. If it's convenient for you,you can pr up my way for our family.

@break60
Copy link
Contributor

break60 commented Aug 21, 2020

@break60 ok, wait a moment

👌

@break60 because there is trouble with my git,I cant not pr up. If it's convenient for you,you can pr up my way for our family.

Ok, let me mention this pr

@xingchun-chen xingchun-chen added this to the 1.3.3-release milestone Sep 10, 2020
@xingchun-chen xingchun-chen changed the title [1.3.0]version:when edit the work flow,the selected connecting line has no style change,but the others have get bigger 1.3.0版本工作流编辑时被选中的line样式不变,其他未被选中的line变粗 [Bug][ui] when edit the work flow,the selected connecting line has no style change,but the others have get bigger (1.3.0版本工作流编辑时被选中的line样式不变,其他未被选中的line变粗) Sep 22, 2020
@xingchun-chen xingchun-chen added bug Something isn't working and removed question Further information is requested labels Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants