lifecycle stage refactor to ensure proper start and stop ordering of servers and announcements #7234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianm
reviewed
Mar 12, 2019
| @@ -65,7 +65,7 @@ | |||
| * Read and store derivatives information from dataSource table frequently. | |||
| * When optimize query, DerivativesManager offers the information about derivatives. | |||
| */ | |||
| @ManageLifecycleLast | |||
| @ManageLifecycleAnnouncements | |||
There was a problem hiding this comment.
Why is this in @ManageLifecycleAnnouncements? It doesn't seem to be doing announcements?
There was a problem hiding this comment.
Good question, I'll see if I can dig up why it was marked @ManageLifecycleLast prior to this PR...
There was a problem hiding this comment.
There is no reason in the initial PR, it was already in the first commit and not an explicit response to review afaict. Looking over what it is doing, it doesn't seem like it would need to be in the last stage, I will move it to just @ManageLifecycle
There was a problem hiding this comment.
Ok, moved it to Lifecycle.Stage.NORMAL, thanks for review!
gianm
approved these changes
Mar 12, 2019
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Mar 14, 2019
…servers and announcements (apache#7234) * lifecycle stage refactor to ensure proper ordering of servers and announcements * move DerivativeDataSourceManager to Lifecycle.Stage.NORMAL
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Apr 8, 2019
…servers and announcements (apache#7234) * lifecycle stage refactor to ensure proper ordering of servers and announcements * move DerivativeDataSourceManager to Lifecycle.Stage.NORMAL
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Apr 14, 2019
…servers and announcements (apache#7234) * lifecycle stage refactor to ensure proper ordering of servers and announcements * move DerivativeDataSourceManager to Lifecycle.Stage.NORMAL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced by #7215.
HttpServerInventoryViewuses the 'discovery' announcement so would correctly identify servers that disappear, butAbstractCuratorServerInventoryViewwatches another announcement that stops later, causing the 'server disappeared' event to happen after jetty has stopped.This PR resolves this issue by slightly reworking the
Lifecycle.Stageenumeration and renaming them to be more relevant to their intended usage, to quote the javadocs:This has the very nice behavior that all announcements can be unannounced prior to stopping the server, meaning
druid.server.http.unannouncePropagationDelayshould apply to all announcements to give adequate time for the rest of the cluster to notice all announcements are gone.Logs of shutdown after this PR for curator based segment management:
and for http segment management: